)]}'
{"cinder/volume/drivers/zfssa/zfssanfs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"31d1e5bef6321d60af38223d64679faaf7a4151d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                self.configuration.max_over_subscription_ratio,"},{"line_number":115,"context_line":"                supports_auto\u003dFalse))"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        if not self.configuration.max_over_subscription_ratio \u003e\u003d 1:"},{"line_number":118,"context_line":"            msg \u003d _(\"Config \u0027max_over_subscription_ratio\u0027 invalid. Must be \u003e\u003d \""},{"line_number":119,"context_line":"                    \"1: %s\") % self.configuration.max_over_subscription_ratio"},{"line_number":120,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a9bf49a9","line":117,"updated":"2018-06-22 06:44:36.000000000","message":"I\u0027m not sure but if a unit case can be added where a value will can pass and \u003e0 condition will fail\n\nhttps://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/drivers/test_zfssa.py#L1120\n\na value like 0.5 can be specified to check for a test with self.assertRaises(exception.NfsException,...\n\nSince the tests pass with \u003e0 and \u003e\u003d1 and there doesn\u0027t exist a test case to state the difference between the two","commit_id":"83a394bfe7227e32097f13447f9545bce097111c"}]}