)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0a4e379e149a94f4f2d4878b410e5a7fe569b0f4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DS8K: correct behavior and return value for terminate_connection method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In terminate_connection method, if the host cann\u0027t be found in the"},{"line_number":10,"context_line":"storage and the lun type is non-replication, driver will log an error"},{"line_number":11,"context_line":"instead of raising an exception and the return value should be"},{"line_number":12,"context_line":"lowercase."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_d73a05cb","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":48},"updated":"2018-06-27 12:34:48.000000000","message":"can\u0027t","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"25a6346c05ebff127d830f283f4c5110afc48cd7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DS8K: correct behavior and return value for terminate_connection method"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In terminate_connection method, if the host cann\u0027t be found in the"},{"line_number":10,"context_line":"storage and the lun type is non-replication, driver will log an error"},{"line_number":11,"context_line":"instead of raising an exception and the return value should be"},{"line_number":12,"context_line":"lowercase."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_4c1df175","line":9,"range":{"start_line":9,"start_character":44,"end_line":9,"end_character":48},"in_reply_to":"5f7c97a3_d73a05cb","updated":"2018-07-04 05:27:59.000000000","message":"Thank you very much for your comment. It will be address in the new patch","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"}],"cinder/tests/unit/volume/drivers/ibm/test_ds8k_proxy.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"771c12baeb9b94bfef5a333097ec6acf24318dbf","unresolved":false,"context_lines":[{"line_number":2917,"context_line":"        mock_get_host_ports.side_effect \u003d [host_ports]"},{"line_number":2918,"context_line":"        mock_get_mappings.side_effect \u003d [mappings]"},{"line_number":2919,"context_line":"        ret_info \u003d self.driver.terminate_connection(volume, TEST_CONNECTOR)"},{"line_number":2920,"context_line":"        self.assertTrue("},{"line_number":2921,"context_line":"            list(ret_info[\u0027data\u0027][\u0027initiator_target_map\u0027].keys())[0] in"},{"line_number":2922,"context_line":"            [TEST_SOURCE_WWPN_1, TEST_SOURCE_WWPN_2])"},{"line_number":2923,"context_line":"        self.assertTrue("},{"line_number":2924,"context_line":"            list(ret_info[\u0027data\u0027][\u0027initiator_target_map\u0027].keys())[1] in"},{"line_number":2925,"context_line":"            [TEST_SOURCE_WWPN_1, TEST_SOURCE_WWPN_2])"},{"line_number":2926,"context_line":""},{"line_number":2927,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027_get_host_ports\u0027)"},{"line_number":2928,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027_get_mappings\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_0aa22bfd","line":2925,"range":{"start_line":2920,"start_character":7,"end_line":2925,"end_character":53},"updated":"2018-07-02 17:56:12.000000000","message":"Please, change it to something like:\nself.assertEqual(sort(list(ret_info[\u0027data\u0027][\u0027initiator_target_map\u0027].keys(), [TEST_SOURCE_WWPN_1, TEST_SOURCE_WWPN_2])","commit_id":"a4da6994859ec13df9f666e4cd328fa767e2ae90"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"25a6346c05ebff127d830f283f4c5110afc48cd7","unresolved":false,"context_lines":[{"line_number":2917,"context_line":"        mock_get_host_ports.side_effect \u003d [host_ports]"},{"line_number":2918,"context_line":"        mock_get_mappings.side_effect \u003d [mappings]"},{"line_number":2919,"context_line":"        ret_info \u003d self.driver.terminate_connection(volume, TEST_CONNECTOR)"},{"line_number":2920,"context_line":"        self.assertTrue("},{"line_number":2921,"context_line":"            list(ret_info[\u0027data\u0027][\u0027initiator_target_map\u0027].keys())[0] in"},{"line_number":2922,"context_line":"            [TEST_SOURCE_WWPN_1, TEST_SOURCE_WWPN_2])"},{"line_number":2923,"context_line":"        self.assertTrue("},{"line_number":2924,"context_line":"            list(ret_info[\u0027data\u0027][\u0027initiator_target_map\u0027].keys())[1] in"},{"line_number":2925,"context_line":"            [TEST_SOURCE_WWPN_1, TEST_SOURCE_WWPN_2])"},{"line_number":2926,"context_line":""},{"line_number":2927,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027_get_host_ports\u0027)"},{"line_number":2928,"context_line":"    @mock.patch.object(helper.DS8KCommonHelper, \u0027_get_mappings\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_9ad66926","line":2925,"range":{"start_line":2920,"start_character":7,"end_line":2925,"end_character":53},"in_reply_to":"5f7c97a3_0aa22bfd","updated":"2018-07-04 05:27:59.000000000","message":"Thank you very much for your comment. It will be addressed in new patch.","commit_id":"a4da6994859ec13df9f666e4cd328fa767e2ae90"}],"cinder/volume/drivers/ibm/ibm_storage/ds8k_proxy.py":[{"author":{"_account_id":14532,"name":"Gerald McBrearty","email":"gfm@us.ibm.com","username":"gfm"},"change_message_id":"7a8aab6778eb00c3d00186fa8c6e308916f542de","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            if host_id is None or not vol_mapped:"},{"line_number":1082,"context_line":"                if host_id is None and not lun.type_replication:"},{"line_number":1083,"context_line":"                    msg \u003d (_(\u0027Failed to find the Host information.\u0027))"},{"line_number":1084,"context_line":"                    LOG.error(msg)"},{"line_number":1085,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"},{"line_number":1086,"context_line":"                    LOG.warning(\"Volume %(vol)s is already not mapped to \""},{"line_number":1087,"context_line":"                                \"host %(host)s.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_928c9b80","line":1084,"updated":"2018-06-27 14:07:37.000000000","message":"I would recommend changing this to a LOG.warning. \nThere is nothing that needs to fixed.\n\nAnd agree you should return here.","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"df0e91c192c9cecbdb7b848922d9f30af2564512","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"            if host_id is None or not vol_mapped:"},{"line_number":1082,"context_line":"                if host_id is None and not lun.type_replication:"},{"line_number":1083,"context_line":"                    msg \u003d (_(\u0027Failed to find the Host information.\u0027))"},{"line_number":1084,"context_line":"                    LOG.error(msg)"},{"line_number":1085,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"},{"line_number":1086,"context_line":"                    LOG.warning(\"Volume %(vol)s is already not mapped to \""},{"line_number":1087,"context_line":"                                \"host %(host)s.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8c354948","line":1084,"in_reply_to":"5f7c97a3_928c9b80","updated":"2018-06-28 05:59:55.000000000","message":"Thank you for your comment.It will be addressed in the new patch.","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0a4e379e149a94f4f2d4878b410e5a7fe569b0f4","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                    LOG.error(msg)"},{"line_number":1085,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"},{"line_number":1086,"context_line":"                    LOG.warning(\"Volume %(vol)s is already not mapped to \""},{"line_number":1087,"context_line":"                                \"host %(host)s.\","},{"line_number":1088,"context_line":"                                {\u0027vol\u0027: lun.ds_id, \u0027host\u0027: host_id})"},{"line_number":1089,"context_line":"                    return ret_info"},{"line_number":1090,"context_line":"                if lun.type_replication:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_f76381db","line":1087,"range":{"start_line":1087,"start_character":38,"end_line":1087,"end_character":46},"updated":"2018-06-27 12:34:48.000000000","message":"This will look a little odd stating \"not mapped to host None\". It might be better to change the previous if-block to return instead of the original raise.","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"df0e91c192c9cecbdb7b848922d9f30af2564512","unresolved":false,"context_lines":[{"line_number":1084,"context_line":"                    LOG.error(msg)"},{"line_number":1085,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"},{"line_number":1086,"context_line":"                    LOG.warning(\"Volume %(vol)s is already not mapped to \""},{"line_number":1087,"context_line":"                                \"host %(host)s.\","},{"line_number":1088,"context_line":"                                {\u0027vol\u0027: lun.ds_id, \u0027host\u0027: host_id})"},{"line_number":1089,"context_line":"                    return ret_info"},{"line_number":1090,"context_line":"                if lun.type_replication:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8c8309cc","line":1087,"range":{"start_line":1087,"start_character":38,"end_line":1087,"end_character":46},"in_reply_to":"5f7c97a3_f76381db","updated":"2018-06-28 05:59:55.000000000","message":"Thank you very much for your comment. “not mapped to host None” will not happen since the condition is host id is not None","commit_id":"a43cf46fae56544a8f9fd5802afe3d2d7e0c6e7e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5baf03630892fc700b8d7bf3c635a778af908688","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"                backend_helper.check_vol_mapped_to_host(connector, lun.ds_id))"},{"line_number":1081,"context_line":"            if host_id is None or not vol_mapped:"},{"line_number":1082,"context_line":"                if host_id is None and not lun.type_replication:"},{"line_number":1083,"context_line":"                    msg \u003d (_(\u0027Failed to find the Host information.\u0027))"},{"line_number":1084,"context_line":"                    LOG.warning(msg)"},{"line_number":1085,"context_line":"                    return ret_info"},{"line_number":1086,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_28657d45","line":1083,"range":{"start_line":1083,"start_character":27,"end_line":1083,"end_character":29},"updated":"2018-07-04 20:59:09.000000000","message":"Translation should now be removed from this if it is only being used for the log message.","commit_id":"66b143956a3aa84a9717d4a22d9073a0828eb928"},{"author":{"_account_id":26422,"name":"Peng Wang","email":"wangpww@cn.ibm.com","username":"wangpeng"},"change_message_id":"2fceaf4ed2dc21b6a3b2e8316cfe9efdb219f27c","unresolved":false,"context_lines":[{"line_number":1080,"context_line":"                backend_helper.check_vol_mapped_to_host(connector, lun.ds_id))"},{"line_number":1081,"context_line":"            if host_id is None or not vol_mapped:"},{"line_number":1082,"context_line":"                if host_id is None and not lun.type_replication:"},{"line_number":1083,"context_line":"                    msg \u003d (_(\u0027Failed to find the Host information.\u0027))"},{"line_number":1084,"context_line":"                    LOG.warning(msg)"},{"line_number":1085,"context_line":"                    return ret_info"},{"line_number":1086,"context_line":"                if host_id and not lun.type_replication and not vol_mapped:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_ff02dc07","line":1083,"range":{"start_line":1083,"start_character":27,"end_line":1083,"end_character":29},"in_reply_to":"5f7c97a3_28657d45","updated":"2018-07-05 01:12:06.000000000","message":"Thank you very much for your comment. It will be addressed in the new patch","commit_id":"66b143956a3aa84a9717d4a22d9073a0828eb928"}]}