)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b43ec79c6fe7e9abd3f96e72013fd7af6a67e24","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.interval \u003d self.configuration.safe_get(\u0027interval\u0027)"},{"line_number":157,"context_line":"        self.retries \u003d self.configuration.safe_get(\u0027retries\u0027)"},{"line_number":158,"context_line":"        self.snapvx_unlink_limit \u003d self.configuration.safe_get("},{"line_number":159,"context_line":"            \u0027utils.VMAX_SNAPVX_UNLINK_LIMIT\u0027)"},{"line_number":160,"context_line":"        self.pool_info[\u0027backend_name\u0027] \u003d ("},{"line_number":161,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027))"},{"line_number":162,"context_line":"        mosr \u003d volume_utils.get_max_over_subscription_ratio("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_f38647b7","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":44},"updated":"2018-07-20 13:02:22.000000000","message":"Isn\u0027t this suppose to be the value of utils.VMAX_SNAPVX_UNLINK_LIMIT and not the name of the const?","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"290d23fa28f31dfac0116607f3bf46c44816fbca","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.interval \u003d self.configuration.safe_get(\u0027interval\u0027)"},{"line_number":157,"context_line":"        self.retries \u003d self.configuration.safe_get(\u0027retries\u0027)"},{"line_number":158,"context_line":"        self.snapvx_unlink_limit \u003d self.configuration.safe_get("},{"line_number":159,"context_line":"            \u0027utils.VMAX_SNAPVX_UNLINK_LIMIT\u0027)"},{"line_number":160,"context_line":"        self.pool_info[\u0027backend_name\u0027] \u003d ("},{"line_number":161,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027))"},{"line_number":162,"context_line":"        mosr \u003d volume_utils.get_max_over_subscription_ratio("}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_b78adb62","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":44},"in_reply_to":"5f7c97a3_f38647b7","updated":"2018-07-23 07:40:54.000000000","message":"This is actually supposed to be the name of the const. We get the actual unlink limit value by retrieving the value from config.","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f9882e3b02af8e30a1abcaaf82286437cd3a7a08","unresolved":false,"context_lines":[{"line_number":66,"context_line":"               help\u003d\u0027Use this value to specify \u0027"},{"line_number":67,"context_line":"                    \u0027the maximum number of unlinks \u0027"},{"line_number":68,"context_line":"                    \u0027for the temporary snapshots \u0027"},{"line_number":69,"context_line":"                    \u0027before a clone operation\u0027),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027initiator_check\u0027,"},{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Use this value to enable \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_c81cf615","line":69,"range":{"start_line":69,"start_character":44,"end_line":69,"end_character":46},"updated":"2018-07-30 12:53:33.000000000","message":"Suggest a \u0027.\u0027 for consistency here.","commit_id":"19974144c441122137eec5cdff8684069ceb64a4"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"cdcba4a009c66f054bd7d564cd8ab829652d7750","unresolved":false,"context_lines":[{"line_number":66,"context_line":"               help\u003d\u0027Use this value to specify \u0027"},{"line_number":67,"context_line":"                    \u0027the maximum number of unlinks \u0027"},{"line_number":68,"context_line":"                    \u0027for the temporary snapshots \u0027"},{"line_number":69,"context_line":"                    \u0027before a clone operation\u0027),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027initiator_check\u0027,"},{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Use this value to enable \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_b0754e35","line":69,"range":{"start_line":69,"start_character":44,"end_line":69,"end_character":46},"in_reply_to":"5f7c97a3_c81cf615","updated":"2018-07-31 09:46:44.000000000","message":"Done","commit_id":"19974144c441122137eec5cdff8684069ceb64a4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e8bb442196546710f50722ef89d187ccb4552c5c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.interval \u003d self.configuration.safe_get(\u0027interval\u0027)"},{"line_number":157,"context_line":"        self.retries \u003d self.configuration.safe_get(\u0027retries\u0027)"},{"line_number":158,"context_line":"        self.snapvx_unlink_limit \u003d self.configuration.safe_get("},{"line_number":159,"context_line":"            \u0027utils.VMAX_SNAPVX_UNLINK_LIMIT\u0027)"},{"line_number":160,"context_line":"        self.pool_info[\u0027backend_name\u0027] \u003d ("},{"line_number":161,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027))"},{"line_number":162,"context_line":"        mosr \u003d volume_utils.get_max_over_subscription_ratio("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d4ad15e8","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":44},"updated":"2018-08-02 19:03:36.000000000","message":"This looks wrong?\n\nDoesn\u0027t it need to be w/o quotes, or \"vmax_snapvx_unlink_limit\"?\n\n(FWIW I think that referencing option names like this is a bad idea anyway.  It\u0027s a bunch of hoops to jump through for anyone grepping the code to look at how to configure the driver.)","commit_id":"db15c97d7b675aba2dc8862b2d609940e8aed51b"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"789efa39a72dde1802de79acd4f872988c376611","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        self.interval \u003d self.configuration.safe_get(\u0027interval\u0027)"},{"line_number":157,"context_line":"        self.retries \u003d self.configuration.safe_get(\u0027retries\u0027)"},{"line_number":158,"context_line":"        self.snapvx_unlink_limit \u003d self.configuration.safe_get("},{"line_number":159,"context_line":"            \u0027utils.VMAX_SNAPVX_UNLINK_LIMIT\u0027)"},{"line_number":160,"context_line":"        self.pool_info[\u0027backend_name\u0027] \u003d ("},{"line_number":161,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027))"},{"line_number":162,"context_line":"        mosr \u003d volume_utils.get_max_over_subscription_ratio("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_52c4ac94","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":44},"in_reply_to":"5f7c97a3_d4ad15e8","updated":"2018-08-03 06:22:16.000000000","message":"Removed the quotes. We will need to handle the comment about referencing the name directly separately as we have a bunch of codes which currently fetches the config values in this way.","commit_id":"db15c97d7b675aba2dc8862b2d609940e8aed51b"}],"cinder/volume/drivers/dell_emc/vmax/rest.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"311f655694d06419cf99fb240b6c13356840c92d","unresolved":false,"context_lines":[{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"        :param array: the array serial number"},{"line_number":1906,"context_line":"        :param source_device_id: source device id"},{"line_number":1907,"context_line":"        :param snap_name: the snapshot name"},{"line_number":1908,"context_line":"        :param state: filter for state of the link"},{"line_number":1909,"context_line":"        :returns: linked_device_list or empty list"},{"line_number":1910,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_acccc0bb","line":1907,"updated":"2018-06-28 10:19:33.000000000","message":"missing\n:param generation: generation number of snapvx","commit_id":"7e80c90036972ebfd3d07ce0c8ccc390187f5edb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b43ec79c6fe7e9abd3f96e72013fd7af6a67e24","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":1623,"context_line":"        :param ttl: time to live in hours, defaults to 0"},{"line_number":1624,"context_line":"        \"\"\""},{"line_number":1625,"context_line":"        if int(ttl) \u003e 0:"},{"line_number":1626,"context_line":"            payload \u003d {\"deviceNameListSource\": [{\"name\": device_id}],"},{"line_number":1627,"context_line":"                       \"bothSides\": \u0027false\u0027, \"star\": \u0027false\u0027,"},{"line_number":1628,"context_line":"                       \"force\": \u0027false\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_93c4b30f","line":1625,"updated":"2018-07-20 13:02:22.000000000","message":"Would be cleaner to keep this how it was, then add:\n\npayload \u003d {...}\n\nif int(ttl) \u003e 0:\n    payload[\u0027timeToLive\u0027] \u003d ttl\n    payload[\u0027timeInHours\u0027] \u003d \u0027true\u0027","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"290d23fa28f31dfac0116607f3bf46c44816fbca","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"        :param extra_specs: the extra specifications"},{"line_number":1623,"context_line":"        :param ttl: time to live in hours, defaults to 0"},{"line_number":1624,"context_line":"        \"\"\""},{"line_number":1625,"context_line":"        if int(ttl) \u003e 0:"},{"line_number":1626,"context_line":"            payload \u003d {\"deviceNameListSource\": [{\"name\": device_id}],"},{"line_number":1627,"context_line":"                       \"bothSides\": \u0027false\u0027, \"star\": \u0027false\u0027,"},{"line_number":1628,"context_line":"                       \"force\": \u0027false\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_97ba3fde","line":1625,"in_reply_to":"5f7c97a3_93c4b30f","updated":"2018-07-23 07:40:54.000000000","message":"Done","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"8b43ec79c6fe7e9abd3f96e72013fd7af6a67e24","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        :return: snap_name"},{"line_number":317,"context_line":"        \"\"\""},{"line_number":318,"context_line":"        snap_name \u003d (\"temp-%(device)s-\""},{"line_number":319,"context_line":"                     % {\u0027device\u0027: source_device_id}) + CLONE_SNAPSHOT_NAME"},{"line_number":320,"context_line":"        return snap_name"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_939273fb","line":319,"range":{"start_line":319,"start_character":53,"end_line":319,"end_character":54},"updated":"2018-07-20 13:02:22.000000000","message":"Add this into the string formatting rather than concatenating and formatting.","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"290d23fa28f31dfac0116607f3bf46c44816fbca","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        :return: snap_name"},{"line_number":317,"context_line":"        \"\"\""},{"line_number":318,"context_line":"        snap_name \u003d (\"temp-%(device)s-\""},{"line_number":319,"context_line":"                     % {\u0027device\u0027: source_device_id}) + CLONE_SNAPSHOT_NAME"},{"line_number":320,"context_line":"        return snap_name"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"5f7c97a3_97e79f46","line":319,"range":{"start_line":319,"start_character":53,"end_line":319,"end_character":54},"in_reply_to":"5f7c97a3_939273fb","updated":"2018-07-23 07:40:54.000000000","message":"Done","commit_id":"a33fd229179602e296bfe392b6972374fb1a65c2"}]}