)]}'
{"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"39d672fc79ffc1fcf13d9bfad5affaf1d2abe3fa","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    @ddt.data(False, True)"},{"line_number":345,"context_line":"    @mock.patch.object(driver.RBDDriver, \u0027_enable_replication\u0027)"},{"line_number":346,"context_line":"    def test_enable_replication_if_needed_non_replicated(self, enabled,"},{"line_number":347,"context_line":"                                                         mock_enable):"},{"line_number":348,"context_line":"        self.driver._is_replication_enabled \u003d enabled"},{"line_number":349,"context_line":"        res \u003d self.driver._enable_replication_if_needed(self.volume_a)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_84edd4f1","line":346,"updated":"2018-07-02 16:31:42.000000000","message":"Just a basic check somewhere around here that sets the config option and verifies the right args are passed through to the call.","commit_id":"2401aa27b3e54485757acf310501dc2eb79b2fad"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"624e941459ab1aa74ae81943e00345c43103285e","unresolved":false,"context_lines":[{"line_number":483,"context_line":"        order \u003d int(math.log(chunk_size, 2))"},{"line_number":484,"context_line":"        self.mock_rbd.RBD.return_value.create.assert_called_once_with("},{"line_number":485,"context_line":"            client.ioctx, self.volume_a.name, self.volume_a.size * units.Gi,"},{"line_number":486,"context_line":"            order, old_format\u003dFalse, features\u003dclient.features, "},{"line_number":487,"context_line":"            data_pool\u003dself.cfg.rbd_data_pool)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        client.__enter__.assert_called_once_with()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_4e8a60bc","line":486,"range":{"start_line":486,"start_character":60,"end_line":486,"end_character":63},"updated":"2018-07-03 15:27:10.000000000","message":"You have a blank space at EOL here.","commit_id":"c97e067b82fc21dbbae19748eb4304368d83c75c"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"641ac5127f94683abcbe85eb469ff15790bef239","unresolved":false,"context_lines":[{"line_number":62,"context_line":"               help\u003d\u0027The RADOS pool where rbd volumes are stored\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027rbd_data_pool\u0027,"},{"line_number":64,"context_line":"               default\u003dNone,"},{"line_number":65,"context_line":"               help\u003d\u0027The RADOS pool where rbd erasure coded volume data are stored\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027rbd_user\u0027,"},{"line_number":67,"context_line":"               help\u003d\u0027The RADOS client name for accessing rbd volumes \u0027"},{"line_number":68,"context_line":"                    \u0027- only set when using cephx authentication\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f9ff9432","line":65,"updated":"2018-07-02 15:32:56.000000000","message":"Need a line break here to keep it within 80 characters wide.","commit_id":"469141f3d281dd0d714c6b511ea198529f23fc94"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a4b33a7625ed7240b2614c2443e08a4d9439d2e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"               default\u003d\u0027rbd\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027The RADOS pool where rbd volumes are stored\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027rbd_data_pool\u0027,"},{"line_number":64,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":65,"context_line":"               help\u003d\u0027The RADOS pool for rbd erasure coded volume data\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027rbd_user\u0027,"},{"line_number":67,"context_line":"               help\u003d\u0027The RADOS client name for accessing rbd volumes \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_e72a6f2d","line":64,"updated":"2018-07-03 17:40:01.000000000","message":"Using a default of None will let you remove some of the checks in the code below.","commit_id":"c97e067b82fc21dbbae19748eb4304368d83c75c"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6041ea48507a3a8e7f3f875d39c155dc0548abaa","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    cfg.StrOpt(\u0027rbd_pool\u0027,"},{"line_number":61,"context_line":"               default\u003d\u0027rbd\u0027,"},{"line_number":62,"context_line":"               help\u003d\u0027The RADOS pool where rbd volumes are stored\u0027),"},{"line_number":63,"context_line":"    cfg.StrOpt(\u0027rbd_data_pool\u0027,"},{"line_number":64,"context_line":"               default\u003dNone,"},{"line_number":65,"context_line":"               help\u003d\u0027The RADOS pool for rbd erasure coded volume data\u0027),"},{"line_number":66,"context_line":"    cfg.StrOpt(\u0027rbd_user\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_13ddb540","line":63,"updated":"2018-07-12 19:09:37.000000000","message":"the name of this is confusing between rbd_pool and rbd_data_pool.   Since this is for an erasure coded pool, why not call it rbd_erasure_pool ?","commit_id":"de3db0a2b32f2948681e01d87e04f0b177309001"}],"releasenotes/notes/feature-rbd-erasure-coded-pool-a69d276469c568b7.yaml":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e6fb4e45aa6d64470461b722d404e5f10b652e11","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    In the Ceph Luminous release erasure coding for RBD devices was added. To"},{"line_number":5,"context_line":"    enable this functionality a new pool for is created with an erasure coding"},{"line_number":6,"context_line":"    profile. The data for the RBD device is stored in this new pool specified"},{"line_number":7,"context_line":"    by rbd_data_pool while the metadata for the RBD device must be stored in a"},{"line_number":8,"context_line":"    replicated pool specified by rbd_pool. The url for the RBD device uses the"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_0b5d3115","line":5,"range":{"start_line":5,"start_character":40,"end_line":5,"end_character":45},"updated":"2018-07-03 22:10:49.000000000","message":"remove \u0027for\u0027","commit_id":"ece910e436e20262f531fe49e0a01de1d9d91da1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2a4b27494caf9f0bd767711a5b526a1d082eefa7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    In the Ceph Luminous release erasure coding for RBD devices was added. To"},{"line_number":5,"context_line":"    enable this functionality a new pool for is created with an erasure coding"},{"line_number":6,"context_line":"    profile. The data for the RBD device is stored in this new pool specified"},{"line_number":7,"context_line":"    by rbd_data_pool while the metadata for the RBD device must be stored in a"},{"line_number":8,"context_line":"    replicated pool specified by rbd_pool. The url for the RBD device uses the"},{"line_number":9,"context_line":"    rbd_pool like a traditional replicated RBD device, the erasure coded pool"},{"line_number":10,"context_line":"    is only referenced during creation and cloning."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_8b214152","line":7,"range":{"start_line":7,"start_character":7,"end_line":7,"end_character":20},"updated":"2018-07-03 22:32:09.000000000","message":"Can you put this inside `` so it gets formatted in the output to make it more obvious it\u0027s a config option?","commit_id":"ece910e436e20262f531fe49e0a01de1d9d91da1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2a4b27494caf9f0bd767711a5b526a1d082eefa7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    enable this functionality a new pool for is created with an erasure coding"},{"line_number":6,"context_line":"    profile. The data for the RBD device is stored in this new pool specified"},{"line_number":7,"context_line":"    by rbd_data_pool while the metadata for the RBD device must be stored in a"},{"line_number":8,"context_line":"    replicated pool specified by rbd_pool. The url for the RBD device uses the"},{"line_number":9,"context_line":"    rbd_pool like a traditional replicated RBD device, the erasure coded pool"},{"line_number":10,"context_line":"    is only referenced during creation and cloning."},{"line_number":11,"context_line":"issues:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_4b1fa908","line":8,"range":{"start_line":8,"start_character":33,"end_line":8,"end_character":41},"updated":"2018-07-03 22:32:09.000000000","message":"These too.","commit_id":"ece910e436e20262f531fe49e0a01de1d9d91da1"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2a4b27494caf9f0bd767711a5b526a1d082eefa7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    RBD devices must store their metadata in OMAP which is not present in"},{"line_number":14,"context_line":"    erasure coded pools. Therefore both a replicated and erasure coded pool"},{"line_number":15,"context_line":"    are requried to use erasure coded RBD devices."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_eb30f5a0","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":16},"updated":"2018-07-03 22:32:09.000000000","message":"required","commit_id":"ece910e436e20262f531fe49e0a01de1d9d91da1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"766ab1a2102a3890249307eb07bef0eaa753a4e9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - |"},{"line_number":13,"context_line":"    RBD devices must store their metadata in OMAP which is not present in"},{"line_number":14,"context_line":"    erasure coded pools. Therefore both a replicated and erasure coded pool"},{"line_number":15,"context_line":"    are requried to use erasure coded RBD devices."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_9a44d61a","line":15,"range":{"start_line":15,"start_character":8,"end_line":15,"end_character":16},"in_reply_to":"5f7c97a3_eb30f5a0","updated":"2018-07-09 14:07:41.000000000","message":"This isn\u0027t a known issue -- this is a detail about this using this new optional feature.\n\nIncluding this in \"issues\" will list it as a \"Known Issue\" in the release notes which is for bugs etc, not notes like this.","commit_id":"ece910e436e20262f531fe49e0a01de1d9d91da1"}]}