)]}'
{"cinder/volume/drivers/pure.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            volume.volume_type)"},{"line_number":985,"context_line":"        if replication_type \u003d\u003d REPLICATION_TYPE_SYNC:"},{"line_number":986,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch("},{"line_number":987,"context_line":"                \"Unable to managed volume with type requiring sync\""},{"line_number":988,"context_line":"                \" replication enabled.\")"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def _validate_manage_existing_ref(self, existing_ref, is_snap\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2dc5ca5d","line":987,"updated":"2018-07-25 21:07:04.000000000","message":"Needs _()","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            volume.volume_type)"},{"line_number":985,"context_line":"        if replication_type \u003d\u003d REPLICATION_TYPE_SYNC:"},{"line_number":986,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch("},{"line_number":987,"context_line":"                \"Unable to managed volume with type requiring sync\""},{"line_number":988,"context_line":"                \" replication enabled.\")"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def _validate_manage_existing_ref(self, existing_ref, is_snap\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_195ff010","line":987,"in_reply_to":"5f7c97a3_2dc5ca5d","updated":"2018-07-26 01:23:39.000000000","message":"Done","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        if not is_snap and \u0027::\u0027 in ref_vol_name:"},{"line_number":1012,"context_line":"            # Don\u0027t allow for managing volumes in a pod"},{"line_number":1013,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":1014,"context_line":"                \"Unable to manage volume in a Pod\")"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        current_array \u003d self._get_current_array()"},{"line_number":1017,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_edbef2cc","line":1014,"updated":"2018-07-25 21:07:04.000000000","message":"Same.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        if not is_snap and \u0027::\u0027 in ref_vol_name:"},{"line_number":1012,"context_line":"            # Don\u0027t allow for managing volumes in a pod"},{"line_number":1013,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":1014,"context_line":"                \"Unable to manage volume in a Pod\")"},{"line_number":1015,"context_line":""},{"line_number":1016,"context_line":"        current_array \u003d self._get_current_array()"},{"line_number":1017,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_b95d9c17","line":1014,"in_reply_to":"5f7c97a3_edbef2cc","updated":"2018-07-26 01:23:39.000000000","message":"Done","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"        if REPLICATION_TYPE_SYNC in self._group_potential_repl_types(pgroup):"},{"line_number":1550,"context_line":"            base_name \u003d REPLICATION_POD_NAME + \"::\""},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":"        return base_name + \"consisgroup-%s-cinder\" % pgroup.id"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    @staticmethod"},{"line_number":1555,"context_line":"    def _get_pgroup_snap_suffix(group_snapshot):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cd71b647","line":1552,"updated":"2018-07-25 21:07:04.000000000","message":"Would be better to do the string formatting all in one go and get rid of the concatenation.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":1549,"context_line":"        if REPLICATION_TYPE_SYNC in self._group_potential_repl_types(pgroup):"},{"line_number":1550,"context_line":"            base_name \u003d REPLICATION_POD_NAME + \"::\""},{"line_number":1551,"context_line":""},{"line_number":1552,"context_line":"        return base_name + \"consisgroup-%s-cinder\" % pgroup.id"},{"line_number":1553,"context_line":""},{"line_number":1554,"context_line":"    @staticmethod"},{"line_number":1555,"context_line":"    def _get_pgroup_snap_suffix(group_snapshot):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_19a4d004","line":1552,"in_reply_to":"5f7c97a3_cd71b647","updated":"2018-07-26 01:23:39.000000000","message":"Done","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"        # determine one to use. Stop now."},{"line_number":1822,"context_line":"        if not secondary_array:"},{"line_number":1823,"context_line":"            raise exception.PureDriverException("},{"line_number":1824,"context_line":"                reason\u003d_(\"Unable to find viable secondary array from\""},{"line_number":1825,"context_line":"                         \"configured targets: %(targets)s.\") %"},{"line_number":1826,"context_line":"                {\"targets\": six.text_type(self._replication_target_arrays)}"},{"line_number":1827,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ad8c7a2d","line":1824,"range":{"start_line":1824,"start_character":68,"end_line":1824,"end_character":69},"updated":"2018-07-25 21:07:04.000000000","message":"Needs space on the end.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":1821,"context_line":"        # determine one to use. Stop now."},{"line_number":1822,"context_line":"        if not secondary_array:"},{"line_number":1823,"context_line":"            raise exception.PureDriverException("},{"line_number":1824,"context_line":"                reason\u003d_(\"Unable to find viable secondary array from\""},{"line_number":1825,"context_line":"                         \"configured targets: %(targets)s.\") %"},{"line_number":1826,"context_line":"                {\"targets\": six.text_type(self._replication_target_arrays)}"},{"line_number":1827,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d9adf8e7","line":1824,"range":{"start_line":1824,"start_character":68,"end_line":1824,"end_character":69},"in_reply_to":"5f7c97a3_ad8c7a2d","updated":"2018-07-26 01:23:39.000000000","message":"Done","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"                if err.code \u003d\u003d 400 and ("},{"line_number":2081,"context_line":"                        ERR_MSG_PENDING_ERADICATION in err.text):"},{"line_number":2082,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":2083,"context_line":"                    LOG.warning(\"Pod %s is deleted but not\""},{"line_number":2084,"context_line":"                                \" eradicated - will recreate.\", name)"},{"line_number":2085,"context_line":"                    source_array.eradicate_pod(name)"},{"line_number":2086,"context_line":"                    self._create_pod_if_not_exist(source_array, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_cd70d60c","line":2083,"updated":"2018-07-25 21:07:04.000000000","message":"Is this safe to do?","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":2080,"context_line":"                if err.code \u003d\u003d 400 and ("},{"line_number":2081,"context_line":"                        ERR_MSG_PENDING_ERADICATION in err.text):"},{"line_number":2082,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":2083,"context_line":"                    LOG.warning(\"Pod %s is deleted but not\""},{"line_number":2084,"context_line":"                                \" eradicated - will recreate.\", name)"},{"line_number":2085,"context_line":"                    source_array.eradicate_pod(name)"},{"line_number":2086,"context_line":"                    self._create_pod_if_not_exist(source_array, name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_198db07c","line":2083,"in_reply_to":"5f7c97a3_cd70d60c","updated":"2018-07-26 01:23:39.000000000","message":"Should be fine, at the point that the pod was in this state the volumes for it have already been deleted too. This is mostly to ease some annoying behavior when doing development/testing of the sync rep stuff.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"        chap_username \u003d None"},{"line_number":2320,"context_line":"        chap_password \u003d None"},{"line_number":2321,"context_line":"        if self.configuration.use_chap_auth:"},{"line_number":2322,"context_line":"            (chap_username, chap_password) \u003d \\"},{"line_number":2323,"context_line":"                self._get_chap_credentials(connector[\u0027host\u0027],"},{"line_number":2324,"context_line":"                                           connector[\"initiator\"])"},{"line_number":2325,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_2d4b8ab2","line":2322,"range":{"start_line":2322,"start_character":45,"end_line":2322,"end_character":46},"updated":"2018-07-25 21:07:04.000000000","message":"Please don\u0027t use \\ for spanning multiple lines.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":2319,"context_line":"        chap_username \u003d None"},{"line_number":2320,"context_line":"        chap_password \u003d None"},{"line_number":2321,"context_line":"        if self.configuration.use_chap_auth:"},{"line_number":2322,"context_line":"            (chap_username, chap_password) \u003d \\"},{"line_number":2323,"context_line":"                self._get_chap_credentials(connector[\u0027host\u0027],"},{"line_number":2324,"context_line":"                                           connector[\"initiator\"])"},{"line_number":2325,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f9d6b454","line":2322,"range":{"start_line":2322,"start_character":45,"end_line":2322,"end_character":46},"in_reply_to":"5f7c97a3_2d4b8ab2","updated":"2018-07-26 01:23:39.000000000","message":"Done","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5a1a2a4b59db31075629c81615b5ee36b30ca7a8","unresolved":false,"context_lines":[{"line_number":984,"context_line":"            volume.volume_type)"},{"line_number":985,"context_line":"        if replication_type \u003d\u003d REPLICATION_TYPE_SYNC:"},{"line_number":986,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch("},{"line_number":987,"context_line":"                _(\"Unable to managed volume with type requiring sync\""},{"line_number":988,"context_line":"                  \" replication enabled.\"))"},{"line_number":989,"context_line":""},{"line_number":990,"context_line":"    def _validate_manage_existing_ref(self, existing_ref, is_snap\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_72dcec70","line":987,"range":{"start_line":987,"start_character":29,"end_line":987,"end_character":36},"updated":"2018-07-26 14:59:11.000000000","message":"manage","commit_id":"715069f6155ca292dbe1bddef7b6bd1ec8ea0ccc"}],"doc/source/configuration/block-storage/drivers/pure-storage-driver.rst":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1eb99d361f177ebed46111ee1ca3a88808208dcd","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The ``REPLICATION_TYPE`` value for the ``type`` key can be either ``sync`` or ``async``"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If the ``type`` is ``sync`` volumes will be created in a stretched Pod. This requires"},{"line_number":222,"context_line":"two arrays pre-configured with Active Cluster enabled. You can optionally specify"},{"line_number":223,"context_line":"``uniform`` as ``true`` or ``false``, this will instruct the driver that data paths"},{"line_number":224,"context_line":"are uniform between arrays in the cluster and data connections should be made to both"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_8d8f3ed2","line":221,"updated":"2018-07-25 21:07:04.000000000","message":"Please try to keep lines, other than maybe code blocks, within 80 characters.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"},{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"0185eb975610999748e5552214d6a64add3c2b0f","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"The ``REPLICATION_TYPE`` value for the ``type`` key can be either ``sync`` or ``async``"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"If the ``type`` is ``sync`` volumes will be created in a stretched Pod. This requires"},{"line_number":222,"context_line":"two arrays pre-configured with Active Cluster enabled. You can optionally specify"},{"line_number":223,"context_line":"``uniform`` as ``true`` or ``false``, this will instruct the driver that data paths"},{"line_number":224,"context_line":"are uniform between arrays in the cluster and data connections should be made to both"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5f7c97a3_797064a8","line":221,"in_reply_to":"5f7c97a3_8d8f3ed2","updated":"2018-07-26 01:23:39.000000000","message":"Fixed! I got lazy and assumed some linter would fail tox but I guess not.","commit_id":"d549b58b831c5fca0a037f60ea8ee3c8168e27a2"}]}