)]}'
{"cinder/tests/unit/api/v3/fakes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c9e9cd88b0b4507082f1ff4b55fea99f10a5b95","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    return volume"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def fake_volume_create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":99,"context_line":"                       image_id\u003dNone, volume_type\u003dNone, metadata\u003dNone,"},{"line_number":100,"context_line":"                       availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":101,"context_line":"                       scheduler_hints\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_af9fdb63","line":98,"updated":"2018-08-17 05:49:31.000000000","message":"i quite don\u0027t see the point of adding these parameters individually as they can be derived from kwargs (**param)","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"680d1d92feaae0b7cd5a93286268efc3b452dc6c","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    return volume"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def fake_volume_create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":99,"context_line":"                       image_id\u003dNone, volume_type\u003dNone, metadata\u003dNone,"},{"line_number":100,"context_line":"                       availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":101,"context_line":"                       scheduler_hints\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_b5abfad3","line":98,"in_reply_to":"3f79a3b5_af9fdb63","updated":"2018-08-24 15:28:14.000000000","message":"if i remember correctly, the problem was the \"group_id\" argument, which was incorrect; it has been renamed to \"group\".\n\nAnd since I was changing this method\u0027s signature, I added all the other arguments, so the autospec could be more effective. Autospecs are supposed to ensure that the method signature is respected, and having **kwargs in the method signature just undermines its purpose.","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"148507befb27c7410965f32d53d575bd8b410fd6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    return volume"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"def fake_volume_create(self, context, size, name, description, snapshot\u003dNone,"},{"line_number":99,"context_line":"                       image_id\u003dNone, volume_type\u003dNone, metadata\u003dNone,"},{"line_number":100,"context_line":"                       availability_zone\u003dNone, source_volume\u003dNone,"},{"line_number":101,"context_line":"                       scheduler_hints\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_bc73b315","line":98,"in_reply_to":"3f79a3b5_b5abfad3","updated":"2018-08-28 05:10:52.000000000","message":"The group_id point seems valid enough but adding arguments for autospecs purpose disturbs the consistency of the project.\nSince in every other function, the parameters are passed as **kwargs, IMO this shouldn\u0027t be changed.","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c9e9cd88b0b4507082f1ff4b55fea99f10a5b95","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    vol[\u0027size\u0027] \u003d size"},{"line_number":108,"context_line":"    vol[\u0027display_name\u0027] \u003d name"},{"line_number":109,"context_line":"    vol[\u0027display_description\u0027] \u003d description"},{"line_number":110,"context_line":"    source_volume \u003d param.get(\u0027source_volume\u0027) or {}"},{"line_number":111,"context_line":"    vol[\u0027source_volid\u0027] \u003d source_volume.get(\u0027id\u0027)"},{"line_number":112,"context_line":"    vol[\u0027bootable\u0027] \u003d False"},{"line_number":113,"context_line":"    vol[\u0027volume_attachment\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ef9cf36b","line":110,"updated":"2018-08-17 05:49:31.000000000","message":"here param is undefined since you replaced the kwargs with individual variables","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c9e9cd88b0b4507082f1ff4b55fea99f10a5b95","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    vol[\u0027source_volid\u0027] \u003d source_volume.get(\u0027id\u0027)"},{"line_number":112,"context_line":"    vol[\u0027bootable\u0027] \u003d False"},{"line_number":113,"context_line":"    vol[\u0027volume_attachment\u0027] \u003d []"},{"line_number":114,"context_line":"    vol[\u0027multiattach\u0027] \u003d utils.get_bool_param(\u0027multiattach\u0027, param)"},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        vol[\u0027snapshot_id\u0027] \u003d snapshot[\u0027id\u0027]"},{"line_number":117,"context_line":"    except (KeyError, TypeError):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_af883b22","line":114,"updated":"2018-08-17 05:49:31.000000000","message":"ditto","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c9e9cd88b0b4507082f1ff4b55fea99f10a5b95","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        vol[\u0027snapshot_id\u0027] \u003d snapshot[\u0027id\u0027]"},{"line_number":117,"context_line":"    except (KeyError, TypeError):"},{"line_number":118,"context_line":"        vol[\u0027snapshot_id\u0027] \u003d None"},{"line_number":119,"context_line":"    vol[\u0027availability_zone\u0027] \u003d param.get(\u0027availability_zone\u0027, \u0027fakeaz\u0027)"},{"line_number":120,"context_line":"    if group_id:"},{"line_number":121,"context_line":"        vol[\u0027group_id\u0027] \u003d group"},{"line_number":122,"context_line":"    return vol"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_0f9a8f6d","line":119,"updated":"2018-08-17 05:49:31.000000000","message":"ditto","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3c9e9cd88b0b4507082f1ff4b55fea99f10a5b95","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    except (KeyError, TypeError):"},{"line_number":118,"context_line":"        vol[\u0027snapshot_id\u0027] \u003d None"},{"line_number":119,"context_line":"    vol[\u0027availability_zone\u0027] \u003d param.get(\u0027availability_zone\u0027, \u0027fakeaz\u0027)"},{"line_number":120,"context_line":"    if group_id:"},{"line_number":121,"context_line":"        vol[\u0027group_id\u0027] \u003d group"},{"line_number":122,"context_line":"    return vol"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_6f822303","line":120,"updated":"2018-08-17 05:49:31.000000000","message":"ditto","commit_id":"97cf5408a7bc406b3be763009d1fad729a914841"}]}