)]}'
{"cinder/scheduler/weights/goodness.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"0ff1fd71c5370c9c451acdd78b8ed9884c53da63","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                host_caps[\u0027goodness_function\u0027] is not None):"},{"line_number":127,"context_line":"            goodness_function \u003d six.text_type(host_caps[\u0027goodness_function\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        qos_specs \u003d weight_properties.get(\u0027qos_specs\u0027, {}) or {}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        volume_type \u003d weight_properties.get(\u0027volume_type\u0027, {}) or {}"},{"line_number":132,"context_line":"        extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_fcb00b00","line":129,"updated":"2018-07-12 17:28:27.000000000","message":"I\u0027m not sure why the or {} is required here, as the get() call has a default {} that is supposed to be returned if the \u0027qos_specs\u0027 key isn\u0027t found.","commit_id":"0d938d7b41f60a4c0bc28c3cdb361609f346758b"},{"author":{"_account_id":24638,"name":"Eric M Gonzalez (tasker)","email":"eric@awnix.com","username":"egrh3"},"change_message_id":"0bcc28140d6428ca0c976ea1157457ef968dcd4b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                host_caps[\u0027goodness_function\u0027] is not None):"},{"line_number":127,"context_line":"            goodness_function \u003d six.text_type(host_caps[\u0027goodness_function\u0027])"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        qos_specs \u003d weight_properties.get(\u0027qos_specs\u0027, {}) or {}"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        volume_type \u003d weight_properties.get(\u0027volume_type\u0027, {}) or {}"},{"line_number":132,"context_line":"        extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_f171fae0","line":129,"in_reply_to":"5f7c97a3_fcb00b00","updated":"2018-07-13 18:28:35.000000000","message":"The extra \"or {}\" is in case `qos_specs` is there and is assigned `None`. I\u0027ve added it here as a catch in case that ever happens.","commit_id":"0d938d7b41f60a4c0bc28c3cdb361609f346758b"}]}