)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1834edfca51a9e978e965ce805de44c909e3af61","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  AttributeError: \u0027module\u0027 object has no attribute \u0027nvmcli\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] I3cff61b4cde16e00ad23d534c5281a2f1afcd29f"},{"line_number":16,"context_line":"[2] http://10.212.19.4:8080/job/NVMe/1291/console"},{"line_number":17,"context_line":"[3] http://13.74.249.42/NVMe/1291_r-dcs94/logs/c-vol.service.log.gz"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I5d457e5005e64b8857592b1686a5d8075f5f7c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_f2979c38","line":16,"range":{"start_line":16,"start_character":11,"end_line":16,"end_character":13},"updated":"2018-07-16 12:58:05.000000000","message":"Linking to an internal URL doesn\u0027t really do much good.","commit_id":"37a817594ec69d7eee365cde8053f83ab6710dd5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"038c4dca97560f1278ef01430576ec57edd3b350","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  AttributeError: \u0027module\u0027 object has no attribute \u0027nvmcli\u0027"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1] I3cff61b4cde16e00ad23d534c5281a2f1afcd29f"},{"line_number":16,"context_line":"[2] http://13.74.249.42/NVMe/1291_r-dcs94/console.html.gz"},{"line_number":17,"context_line":"[3] http://13.74.249.42/NVMe/1291_r-dcs94/logs/c-vol.service.log.gz"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I5d457e5005e64b8857592b1686a5d8075f5f7c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_e3126c61","line":16,"updated":"2018-07-16 14:54:07.000000000","message":"These links will be gone in no time.  Please don\u0027t leave them in commit messages.","commit_id":"744e292b1f5e54bdeed71ddb50b8901dbaf2cd28"}],"cinder/volume/targets/nvmet.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b20a5a419a1883c490b18133b6a00c884f0c82b6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder import exception"},{"line_number":23,"context_line":"import cinder.privsep.nvmcli"},{"line_number":24,"context_line":"import cinder.privsep.utils"},{"line_number":25,"context_line":"from cinder import utils"},{"line_number":26,"context_line":"from cinder.volume.targets import nvmeof"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_dcf0afdd","line":23,"updated":"2018-07-12 17:24:07.000000000","message":"why not \nfrom cinder.privesp import nvmcli ?\nand then use it like nvmcli.restore()","commit_id":"30ac186731cba0a605e63e82754aa7dff4a090ba"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b20a5a419a1883c490b18133b6a00c884f0c82b6","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder import exception"},{"line_number":23,"context_line":"import cinder.privsep.nvmcli"},{"line_number":24,"context_line":"import cinder.privsep.utils"},{"line_number":25,"context_line":"from cinder import utils"},{"line_number":26,"context_line":"from cinder.volume.targets import nvmeof"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_3ce44342","line":24,"updated":"2018-07-12 17:24:07.000000000","message":"this doesn\u0027t seem to even be used.","commit_id":"30ac186731cba0a605e63e82754aa7dff4a090ba"},{"author":{"_account_id":14807,"name":"Lenny","email":"lennyb@mellanox.com","username":"lennyb"},"change_message_id":"72efbe0d92ec2590478c842895acec3c567f84d2","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from cinder import exception"},{"line_number":23,"context_line":"import cinder.privsep.nvmcli"},{"line_number":24,"context_line":"import cinder.privsep.utils"},{"line_number":25,"context_line":"from cinder import utils"},{"line_number":26,"context_line":"from cinder.volume.targets import nvmeof"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a1ea429d","line":24,"in_reply_to":"5f7c97a3_3ce44342","updated":"2018-07-15 12:51:38.000000000","message":"this is used in line 195 and 211","commit_id":"30ac186731cba0a605e63e82754aa7dff4a090ba"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b20a5a419a1883c490b18133b6a00c884f0c82b6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            tmp_fd.write(json.dumps(nvmf_subsystems))"},{"line_number":80,"context_line":"            tmp_fd.flush()"},{"line_number":81,"context_line":"            try:"},{"line_number":82,"context_line":"                out, err \u003d cinder.privsep.nvmcli.restore(tmp_fd.name)"},{"line_number":83,"context_line":"            except putils.ProcessExecutionError:"},{"line_number":84,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":85,"context_line":"                    LOG.exception(\u0027Error from nvmetcli restore\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5c2edf42","line":82,"updated":"2018-07-12 17:24:07.000000000","message":"why not use the nvmcli.restore here instead of cinder.privsep.nvmcli?","commit_id":"30ac186731cba0a605e63e82754aa7dff4a090ba"},{"author":{"_account_id":27621,"name":"Vishakha Agarwal","email":"agarwalvishakha18@gmail.com","username":"Vishakha"},"change_message_id":"24ad747a90cc0e82cb771a2b587447b0b33f2f5a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import cinder.privsep.utils"},{"line_number":24,"context_line":"from cinder import utils"},{"line_number":25,"context_line":"from cinder.privsep import nvmcli"},{"line_number":26,"context_line":"from cinder.volume.targets import nvmeof"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8a8956c8","line":26,"updated":"2018-07-16 06:36:42.000000000","message":"Import is not in alphabetical order.Kindly check.","commit_id":"b90ce04459aff6ce250f12d0957a747e6fb040f8"}]}
