)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"80af825da8f9d1b64aa2030b5199f3f95a3052d0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     KIYOHIRO ADACHI \u003cadachi@mxs.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-26 15:54:17 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed some misspelled methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027_update_volume_status\u0027 to \u0027_update_volume_stats\u0027"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BZy4%3D","line":7,"updated":"2013-11-26 14:00:35.000000000","message":"Please be more descriptive in the title, perhaps \"Fix _update_volume_stats typos\"","commit_id":"7c9e9fe025747217e368bc78c8a9961dd3951280"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"eb3b3f440ed238f86cc21389cb06b34fc4f37ff1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     KIYOHIRO ADACHI \u003cadachi@mxs.nes.nec.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-26 15:54:17 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed some misspelled methods"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\u0027_update_volume_status\u0027 to \u0027_update_volume_stats\u0027"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BXLE%3D","line":7,"in_reply_to":"AAAATn%2F%2BZy4%3D","updated":"2013-11-26 22:25:06.000000000","message":"I have skipped too much. Thanks!","commit_id":"7c9e9fe025747217e368bc78c8a9961dd3951280"}],"cinder/tests/test_eqlx.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"d74e750c047a1756ec58ff9818983de29a2f63c8","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        self.assertEqual(self.driver._stats[\u0027total_capacity_gb\u0027], 111.0)"},{"line_number":229,"context_line":"        self.assertEqual(self.driver._stats[\u0027free_capacity_gb\u0027], 11.0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_update_volume_stats2(self):"},{"line_number":232,"context_line":"        self.driver._eql_execute \u003d self.mox.\\"},{"line_number":233,"context_line":"            CreateMock(self.driver._eql_execute)"},{"line_number":234,"context_line":"        self.driver._eql_execute(\u0027pool\u0027, \u0027select\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQ1o%3D","line":231,"updated":"2013-11-28 07:37:22.000000000","message":"A comment stating how it is different from the above def might be useful, or probably you can change the def name? Not really an issue.","commit_id":"018ba6302b0f5b909e9f32f44a14c21313a2663e"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"2d0480c33c4a9c1491c25651a613bfed34262766","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        self.assertEqual(self.driver._stats[\u0027total_capacity_gb\u0027], 111.0)"},{"line_number":229,"context_line":"        self.assertEqual(self.driver._stats[\u0027free_capacity_gb\u0027], 11.0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_update_volume_stats2(self):"},{"line_number":232,"context_line":"        self.driver._eql_execute \u003d self.mox.\\"},{"line_number":233,"context_line":"            CreateMock(self.driver._eql_execute)"},{"line_number":234,"context_line":"        self.driver._eql_execute(\u0027pool\u0027, \u0027select\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BQW0%3D","line":231,"in_reply_to":"AAAATn%2F%2BQ1o%3D","updated":"2013-11-28 09:30:59.000000000","message":"Do you think the def name \u0027test_get_volume_stats\u0027 is better than \u0027test_update_volume_stats2\u0027 ? If so, I would like to be that. Thank you for your comment!","commit_id":"018ba6302b0f5b909e9f32f44a14c21313a2663e"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"6a7d27e22733ca8b624deee4de3804cd44bd7320","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        self.assertEqual(self.driver._stats[\u0027total_capacity_gb\u0027], 111.0)"},{"line_number":229,"context_line":"        self.assertEqual(self.driver._stats[\u0027free_capacity_gb\u0027], 11.0)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_update_volume_stats2(self):"},{"line_number":232,"context_line":"        self.driver._eql_execute \u003d self.mox.\\"},{"line_number":233,"context_line":"            CreateMock(self.driver._eql_execute)"},{"line_number":234,"context_line":"        self.driver._eql_execute(\u0027pool\u0027, \u0027select\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BKpU%3D","line":231,"in_reply_to":"AAAATn%2F%2BQW0%3D","updated":"2013-11-30 05:21:14.000000000","message":"I agree test_get_volume_stats would be better.","commit_id":"018ba6302b0f5b909e9f32f44a14c21313a2663e"}],"cinder/volume/drivers/eqlx.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"80af825da8f9d1b64aa2030b5199f3f95a3052d0","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return scale * float(val.partition(part)[0])"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def _update_volume_stats(self):"},{"line_number":245,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.debug(_(\"Updating volume stats\"))"},{"line_number":248,"context_line":"        data \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BZ0k%3D","line":245,"updated":"2013-11-26 14:00:35.000000000","message":"instead of \"volume group\", should probably be \"eqlx group\" (volume group is for LVM)","commit_id":"7c9e9fe025747217e368bc78c8a9961dd3951280"},{"author":{"_account_id":7236,"name":"Kiyohiro Adachi","email":"kiy-adachi@vx.jp.nec.com","username":"kadachi"},"change_message_id":"eb3b3f440ed238f86cc21389cb06b34fc4f37ff1","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        return scale * float(val.partition(part)[0])"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def _update_volume_stats(self):"},{"line_number":245,"context_line":"        \"\"\"Retrieve stats info from volume group.\"\"\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.debug(_(\"Updating volume stats\"))"},{"line_number":248,"context_line":"        data \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXK0%3D","line":245,"in_reply_to":"AAAATn%2F%2BZ0k%3D","updated":"2013-11-26 22:25:06.000000000","message":"I got it. Thanks.","commit_id":"7c9e9fe025747217e368bc78c8a9961dd3951280"}]}
