)]}'
{"cinder/api/v3/group_snapshots.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"ea2f89c93296fd56c8093fccd6285f4202efa7aa","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            LOG.exception(e.msg)"},{"line_number":92,"context_line":"            raise e"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_5bbf84c9","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":32},"updated":"2018-07-26 20:43:09.000000000","message":"This should be translated.  We have passed the point of accepting those changes so this need to be held for Stein.  Also, I agree that logging the action may be more than we want to do.","commit_id":"7605c1fcde1c1e94bbd0e43b4aba94972bb21e22"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"aa9f4fcf51d8afc874a35e9734d22c969770d693","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            LOG.exception(e.msg)"},{"line_number":92,"context_line":"            raise e"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d8115a5e","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":32},"updated":"2018-07-26 20:26:19.000000000","message":"nit: I\u0027m not sure if you want to log this (not sure if it reveals the policy that failed authorization) but I\u0027ll leave that as an open-ended question for core reviewers.","commit_id":"7605c1fcde1c1e94bbd0e43b4aba94972bb21e22"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"4b8ba5d3d8fac1fce6e882e715a5e7c77f3e8f21","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            LOG.exception(e.msg)"},{"line_number":92,"context_line":"            raise e"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_82cb5b71","line":91,"range":{"start_line":91,"start_character":25,"end_line":91,"end_character":32},"in_reply_to":"5f7c97a3_5bbf84c9","updated":"2018-07-27 16:27:50.000000000","message":"Thanks for the review. I will remove the logging of the action in next PS.","commit_id":"7605c1fcde1c1e94bbd0e43b4aba94972bb21e22"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"1931c69afb3178804762d90338375a0b3b27fe2f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            LOG.exception(e.msg)"},{"line_number":92,"context_line":"            raise e"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9b319cf1","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":32},"in_reply_to":"5f7c97a3_d8115a5e","updated":"2018-07-26 20:28:10.000000000","message":"It does show the policy action that fails authorization","commit_id":"7605c1fcde1c1e94bbd0e43b4aba94972bb21e22"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2a8853428cab17f24950b545084dd902fc2506d8","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except exception.GroupSnapshotNotFound:"},{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_16d9cc26","line":90,"range":{"start_line":90,"start_character":44,"end_line":90,"end_character":49},"updated":"2018-07-27 21:21:01.000000000","message":"Don\u0027t need this part, same pattern as L87-89 applies","commit_id":"9b2eeb3a952b2bc26c970c7b2a8c133627e7a9f2"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"fc0a46f0c5fba7ab6d4cd4d61e1885ad6d9e7644","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        except exception.GroupSnapshotNotFound:"},{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ef7c3823","line":90,"range":{"start_line":90,"start_character":44,"end_line":90,"end_character":49},"in_reply_to":"5f7c97a3_16d9cc26","updated":"2018-07-31 15:23:16.000000000","message":"Done","commit_id":"9b2eeb3a952b2bc26c970c7b2a8c133627e7a9f2"},{"author":{"_account_id":23186,"name":"Felipe Monteiro","email":"felipe.carneiro.monteiro@gmail.com","username":"felipe.monteiro"},"change_message_id":"2a8853428cab17f24950b545084dd902fc2506d8","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"},{"line_number":94,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_56bd04b0","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":19},"updated":"2018-07-27 21:21:01.000000000","message":"Could just do raise","commit_id":"9b2eeb3a952b2bc26c970c7b2a8c133627e7a9f2"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"fc0a46f0c5fba7ab6d4cd4d61e1885ad6d9e7644","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"},{"line_number":94,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0f8094f5","line":91,"range":{"start_line":91,"start_character":12,"end_line":91,"end_character":19},"in_reply_to":"5f7c97a3_56bd04b0","updated":"2018-07-31 15:23:16.000000000","message":"Done","commit_id":"9b2eeb3a952b2bc26c970c7b2a8c133627e7a9f2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"53199fc346243c0377078febd07f0affde20a1b5","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"},{"line_number":94,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_6f4d7fc3","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":19},"updated":"2018-07-31 21:25:41.000000000","message":"Should just be \"raise\", not \"raise e\".\n\nCan probably just lump in with the GroupSnapshotNotFound handling.","commit_id":"cc19a7dc1a8e8b71b07c324f75689a2f4304ac07"},{"author":{"_account_id":17896,"name":"Rick Bartra","email":"rickbartra@microsoft.com","username":"rb560u"},"change_message_id":"000b112af8ac0fcab9a27ae8d1ee044433aeffba","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":89,"context_line":"            raise"},{"line_number":90,"context_line":"        except exception.PolicyNotAuthorized as e:"},{"line_number":91,"context_line":"            raise e"},{"line_number":92,"context_line":"        except Exception:"},{"line_number":93,"context_line":"            msg \u003d _(\"Error occurred when deleting group snapshot %s.\") % id"},{"line_number":94,"context_line":"            LOG.exception(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_2a29b581","line":91,"range":{"start_line":91,"start_character":17,"end_line":91,"end_character":19},"in_reply_to":"5f7c97a3_6f4d7fc3","updated":"2018-07-31 21:33:39.000000000","message":"Thanks for the review. Fixed in PS8","commit_id":"cc19a7dc1a8e8b71b07c324f75689a2f4304ac07"}]}
