)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c45665c38035045835a084e4507e822b3ae8dbb9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an LVM volume is extended, the iSCSI target must be updated so that"},{"line_number":10,"context_line":"the recent change is visible."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I185a90ffc4d50dd9f91381df07289476fa792043"},{"line_number":13,"context_line":"Closes-Bug: #1248415"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2BYGI%3D","line":11,"updated":"2013-11-26 18:43:09.000000000","message":"Commit message should note that this is only for tgtadm.  Other changes may be needed for ietadm/lioadm.  (Which don\u0027t have to happen in this patchset, but, good to be clear.)","commit_id":"cd300e4ede60c9c33ed6493a99c966b316ad717b"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"8e54a6ab29fa892cd1f24c5862247d3087f9a002","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jon Bernard \u003cjobernar@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-27 09:29:37 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LVM: update iscsi target on volume extend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an LVM volume is extended, the iSCSI target must be updated so that"},{"line_number":10,"context_line":"the recent change is visible."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BRX4%3D","line":7,"updated":"2013-11-28 03:24:24.000000000","message":"the title should reflect the fact that only \u0027tgtadm\u0027 is changed/fixed.","commit_id":"bb0480e7d798fa3c89abe34ec5b98cf18fb4c2d8"}],"cinder/brick/iscsi/iscsi.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"730197422b7521d9868a815fbe03b384e51cbe03","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def update_iscsi_target(self, name):"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        LOG.info(_(\u0027Updating iscsi target %s\u0027) % name)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        try:"},{"line_number":251,"context_line":"            (out, err) \u003d self._execute(\u0027tgt-admin\u0027, \u0027--update\u0027, name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BWeE%3D","line":248,"updated":"2013-11-27 02:19:12.000000000","message":"Should end this with a \u0027.\u0027 or change it to be:  (\u0027Updating iscsi target: %s\u0027)","commit_id":"016bb924c02624ecfb29d6a6059aca4921b1ce57"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"730197422b7521d9868a815fbe03b384e51cbe03","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                                       run_as_root\u003dTrue)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"            LOG.debug(\"StdOut from tgt-admin --update: %s\" % out)"},{"line_number":255,"context_line":"            LOG.debug(\"StdErr from tgt-admin --update: %s\" % err)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        except putils.ProcessExecutionError as e:"},{"line_number":258,"context_line":"            LOG.error(_(\"Failed to update iscsi target %(name)s: %(e)s\") %"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BWd0%3D","line":255,"updated":"2013-11-27 02:19:12.000000000","message":"Don\u0027t think we need the StdOut and StdErr output unless there is an error.  I would move this to the exception.","commit_id":"016bb924c02624ecfb29d6a6059aca4921b1ce57"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f58471798f5c117b40c22e80c033c73e83dddeac","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.tgtadm.update_iscsi_target(iscsi_name)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        # continue with the base class behaviour"},{"line_number":761,"context_line":"        return driver.ISCSIDriver.initialize_connection(self,"},{"line_number":762,"context_line":"                                                        volume,"},{"line_number":763,"context_line":"                                                        connector)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAT3%2F%2FuRA%3D","line":761,"updated":"2014-01-02 21:43:05.000000000","message":"I think it would be more appropriate to call super(driver.ISCSIDriver).initialize_connection() here?","commit_id":"a9267644ee09591e2d642d6c1204d94a9fdd8c82"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d5647639366e6399f60ee150580b6b9f3dcf75ea","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.tgtadm.update_iscsi_target(iscsi_name)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        # continue with the base class behaviour"},{"line_number":761,"context_line":"        return driver.ISCSIDriver.initialize_connection(self,"},{"line_number":762,"context_line":"                                                        volume,"},{"line_number":763,"context_line":"                                                        connector)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FQAo%3D","line":761,"in_reply_to":"AAAAT3%2F%2FuRA%3D","updated":"2014-01-15 21:55:14.000000000","message":"due to our model of dual inheritance here I don\u0027t think using super will work in this case.  IIRC this is the correct way given our design, but if I\u0027m wrong I\u0027m open to explanation on the alternative.","commit_id":"a9267644ee09591e2d642d6c1204d94a9fdd8c82"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5cf4935e10dedeaf28009b1fef9ad142b16911e9","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.tgtadm.update_iscsi_target(iscsi_name)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        # continue with the base class behaviour"},{"line_number":761,"context_line":"        return driver.ISCSIDriver.initialize_connection(self,"},{"line_number":762,"context_line":"                                                        volume,"},{"line_number":763,"context_line":"                                                        connector)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2FP3o%3D","line":761,"in_reply_to":"AAAAUH%2F%2FQAo%3D","updated":"2014-01-15 22:29:38.000000000","message":"This was basically my conclusion as well after looking into this further with Jon.","commit_id":"a9267644ee09591e2d642d6c1204d94a9fdd8c82"}],"cinder/volume/manager.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5d9602cebbdc11f37fbe5842b0489a1e05c1c9a9","unresolved":false,"context_lines":[{"line_number":875,"context_line":"            LOG.info(_(\"volume %s: extending\"), volume[\u0027id\u0027])"},{"line_number":876,"context_line":"            self.driver.extend_volume(volume, new_size)"},{"line_number":877,"context_line":"            LOG.info(_(\"volume %s: extended successfully\"), volume[\u0027id\u0027])"},{"line_number":878,"context_line":"            self.driver.update_export(context, volume)"},{"line_number":879,"context_line":"        except Exception:"},{"line_number":880,"context_line":"            LOG.exception(_(\"volume %s: Error trying to extend volume\"),"},{"line_number":881,"context_line":"                          volume_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BXwA%3D","line":878,"updated":"2013-11-26 19:52:56.000000000","message":"Should probably move this to before the LOG.info() above it?","commit_id":"cd300e4ede60c9c33ed6493a99c966b316ad717b"}]}