)]}'
{"cinder/backup/api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ed388e3816df42f81a6d08e372e09f9464f9736c","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":365,"context_line":"            src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            volume \u003d self.volume_api.create("},{"line_number":368,"context_line":"                context, size, name, description,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d710b7f7","line":365,"updated":"2018-08-02 19:38:17.000000000","message":"This now fails if a volume identified by volume_id doesn\u0027t exist.  (i.e. it was deleted and you are restoring from backup)","commit_id":"d13851d2b366302c6f875c683f0642f03b633455"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"5fe7caff643e094dac3cb86507f13072e7d85f86","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":365,"context_line":"            src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            volume \u003d self.volume_api.create("},{"line_number":368,"context_line":"                context, size, name, description,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_09404b32","line":365,"in_reply_to":"5f7c97a3_d710b7f7","updated":"2018-08-03 01:17:29.000000000","message":"ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)\njust do it!","commit_id":"d13851d2b366302c6f875c683f0642f03b633455"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5d6ddaa0cefa0084eeddbfb78df13c1034b46c2d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                     \"backup %(backup_id)s.\","},{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":365,"context_line":"            src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            volume \u003d self.volume_api.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_dbe4553f","line":364,"updated":"2018-08-17 08:19:01.000000000","message":"It won\u0027t work after data is purged","commit_id":"dcdddf5350bafbdafa6adc8c62ac7a7eef409268"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"da0d3ee023da44a718804d45f63f49f69b98569d","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                     \"backup %(backup_id)s.\","},{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":365,"context_line":"            src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            volume \u003d self.volume_api.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"bfdaf3ff_7a4be686","line":364,"in_reply_to":"3f79a3b5_5bdb654e","updated":"2019-01-11 06:24:34.000000000","message":"Done","commit_id":"dcdddf5350bafbdafa6adc8c62ac7a7eef409268"},{"author":{"_account_id":25837,"name":"yenai","email":"yenai_yewu@cmss.chinamobile.com","username":"yenai2008"},"change_message_id":"c3b977fb104ed67d2cc990c64258335463d1b292","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                     \"backup %(backup_id)s.\","},{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":365,"context_line":"            src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"            volume \u003d self.volume_api.create("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5bdb654e","line":364,"in_reply_to":"3f79a3b5_dbe4553f","updated":"2018-08-17 08:24:00.000000000","message":"This case is unconventional...","commit_id":"dcdddf5350bafbdafa6adc8c62ac7a7eef409268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5ce74eebeeb039366a997eff91b4fc162627b300","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                     {\u0027size\u0027: size, \u0027backup_id\u0027: backup_id})"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"            multiattach \u003d False"},{"line_number":365,"context_line":"            try:"},{"line_number":366,"context_line":"                ctxt \u003d context.elevated(read_deleted\u003d\u0027yes\u0027)"},{"line_number":367,"context_line":"                src_vol \u003d self.volume_api.get(ctxt, backup[\u0027volume_id\u0027])"},{"line_number":368,"context_line":"                multiattach \u003d src_vol[\u0027multiattach\u0027]"},{"line_number":369,"context_line":"            except exception.VolumeNotFound:"},{"line_number":370,"context_line":"                LOG.info(\"Get multiattach attr failed: the source \""},{"line_number":371,"context_line":"                         \"volume(%(vol_id)s) of backup(%(bak_id)s) is \""},{"line_number":372,"context_line":"                         \"not exist. The multiattach attr of restoring \""},{"line_number":373,"context_line":"                         \"volume will be set false.\","},{"line_number":374,"context_line":"                         {\u0027vol_id\u0027: backup[\u0027volume_id\u0027],"},{"line_number":375,"context_line":"                          \u0027bak_id\u0027: backup_id})"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"            volume \u003d self.volume_api.create("},{"line_number":378,"context_line":"                context, size, name, description,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_6d0492c7","line":375,"range":{"start_line":365,"start_character":12,"end_line":375,"end_character":47},"updated":"2019-01-11 07:00:43.000000000","message":"This doesn\u0027t seem the right way to approach the problem since it may fail if volume was deleted.\nThis should be handled while creating the backup.\nMaybe adding a new parameter in backup api.","commit_id":"1e95bf805e202754af68d3764b8233c6b9c67fe3"}]}