)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"97cd4c71d66b34bad217a74de6421df99f2243e3","unresolved":false,"context_lines":[{"line_number":1616,"context_line":"                    if option_per_gb in specs:"},{"line_number":1617,"context_line":"                        # NOTE(mnaser): Get the minimum allowed value, if any."},{"line_number":1618,"context_line":"                        minimum_value \u003d 0"},{"line_number":1619,"context_line":"                        if option_per_gb_min in specs:"},{"line_number":1620,"context_line":"                            minimum_value \u003d specs[option_per_gb_min]"},{"line_number":1621,"context_line":"                            specs.pop(option_per_gb_min)"},{"line_number":1622,"context_line":"                        value \u003d int(specs[option_per_gb]) * volume_size"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_db6b0b85","line":1619,"updated":"2018-08-02 14:49:53.000000000","message":"I think you could simplify all of this and just do:\n\nminimum_value \u003d specs.pop(options_per_gb_min, 0)\nspecs[option] \u003d max(minimum_value, value)","commit_id":"4f72ac5c67031f0da3ec7d9f9d6f47dc48786264"}]}