)]}'
{"cinder/tests/unit/volume/flows/test_create_volume_flow.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6ed9d009d033d4681ed1e1396d81d86f4a5d874d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"        self.assertTrue(result[\u0027volume_properties\u0027][\u0027bootable\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        volume_db \u003d {\u0027bootable\u0027: False}"},{"line_number":242,"context_line":"        volume_obj \u003d fake_volume.fake_volume_obj(self.ctxt, **volume_db)"},{"line_number":243,"context_line":"        volume_get_by_id.return_value \u003d volume_obj"},{"line_number":244,"context_line":"        volume_create.return_value \u003d {\u0027id\u0027: \u0027123456\u0027}"},{"line_number":245,"context_line":"        task \u003d create_volume.EntryCreateTask()"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        result \u003d task.execute(self.ctxt,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fde58908","line":244,"range":{"start_line":242,"start_character":8,"end_line":244,"end_character":53},"updated":"2018-08-03 07:40:24.000000000","message":"These variables are redundant, they can be removed i guess","commit_id":"7d6ad26c2fd4c01cf00953d3d84f06fd3ed15c35"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"13ac1ef5cf4dfdab116c2f7104f5e8284f94eb07","unresolved":false,"context_lines":[{"line_number":238,"context_line":"                              multiattach\u003dNone)"},{"line_number":239,"context_line":"        self.assertTrue(result[\u0027volume_properties\u0027][\u0027bootable\u0027])"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        volume_db \u003d {\u0027bootable\u0027: False}"},{"line_number":242,"context_line":"        volume_obj \u003d fake_volume.fake_volume_obj(self.ctxt, **volume_db)"},{"line_number":243,"context_line":"        volume_get_by_id.return_value \u003d volume_obj"},{"line_number":244,"context_line":"        task \u003d create_volume.EntryCreateTask()"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_5b3fe586","line":241,"updated":"2018-08-17 08:20:10.000000000","message":"IMO, it\u0027s better to have two separate test cases","commit_id":"8cb73b7a84a92e74cec4454194c280fd6e8f5f94"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e89adbc20d2544d02923794063a3f30b9ebce967","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                              name\u003d\u0027123\u0027,"},{"line_number":242,"context_line":"                              multiattach\u003dNone)"},{"line_number":243,"context_line":"        if bootable:"},{"line_number":244,"context_line":"            self.assertTrue(result[\u0027volume_properties\u0027][\u0027bootable\u0027])"},{"line_number":245,"context_line":"        else:"},{"line_number":246,"context_line":"            self.assertFalse(result[\u0027volume_properties\u0027][\u0027bootable\u0027])"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5fab83d4","line":244,"updated":"2018-08-27 14:05:13.000000000","message":"This should just use self.assertEqual instead of \"if bootable:\" with two different asserts.","commit_id":"24ae6b93b83b69794308f20d181c3c0ed0186b67"}]}