)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"657922f613774a25ca9ed78dd3b2407c9b81e878","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX Driver - Initiator retrieval short hostname fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission fixes a timeout issue with initiator retrieval, the fix"},{"line_number":10,"context_line":"uses targeted extraction instead of list matching to increase"},{"line_number":11,"context_line":"performance. Short hostname retrieval for hostnames with 16 or characters"},{"line_number":12,"context_line":"has been fixed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_cc6f6890","line":9,"updated":"2018-08-09 15:17:07.000000000","message":"Just confirming you want both fixes to be in this change set? Reading this summary is a bit confusing.","commit_id":"cb2d1e7dd1473e6e7aebd6d6c446161633fceffb"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"edb07941ee12dce0079f51ce2521fbfae37d5e05","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX Driver - Initiator retrieval short hostname fix"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This submission fixes a timeout issue with initiator retrieval, the fix"},{"line_number":10,"context_line":"uses targeted extraction instead of list matching to increase"},{"line_number":11,"context_line":"performance. Short hostname retrieval for hostnames with 16 or characters"},{"line_number":12,"context_line":"has been fixed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_c39cd2c1","line":9,"in_reply_to":"3f79a3b5_cc6f6890","updated":"2018-08-13 15:10:09.000000000","message":"Correct, both fixes in this change set","commit_id":"cb2d1e7dd1473e6e7aebd6d6c446161633fceffb"}],"cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4a9b9a859d7a04743a23edbede1f9cedaeb0c081","unresolved":false,"context_lines":[{"line_number":6789,"context_line":"                    self.driver.masking._find_initiator_group("},{"line_number":6790,"context_line":"                        self.data.array, [\u0027Error\u0027]))"},{"line_number":6791,"context_line":"                self.assertIsNone(found_init_group_nam)"},{"line_number":6792,"context_line":""},{"line_number":6793,"context_line":"    @mock.patch.object(masking.VMAXMasking,"},{"line_number":6794,"context_line":"                       \u0027_return_volume_to_fast_managed_group\u0027)"},{"line_number":6795,"context_line":"    @mock.patch.object(masking.VMAXMasking, \u0027_check_ig_rollback\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_73079e19","line":6792,"updated":"2018-08-15 13:26:16.000000000","message":"Please put test_create_masking_view back in.  Thanks","commit_id":"f9368bb18a5e37daa89f3104b67ebfae7544ba67"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"ec87373e18247deeff3dc4ba51ab74bb37db580d","unresolved":false,"context_lines":[{"line_number":6789,"context_line":"                    self.driver.masking._find_initiator_group("},{"line_number":6790,"context_line":"                        self.data.array, [\u0027Error\u0027]))"},{"line_number":6791,"context_line":"                self.assertIsNone(found_init_group_nam)"},{"line_number":6792,"context_line":""},{"line_number":6793,"context_line":"    @mock.patch.object(masking.VMAXMasking,"},{"line_number":6794,"context_line":"                       \u0027_return_volume_to_fast_managed_group\u0027)"},{"line_number":6795,"context_line":"    @mock.patch.object(masking.VMAXMasking, \u0027_check_ig_rollback\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_33d28629","line":6792,"in_reply_to":"3f79a3b5_73079e19","updated":"2018-08-15 13:41:12.000000000","message":"Will be fixed in the next patch, thanks!","commit_id":"f9368bb18a5e37daa89f3104b67ebfae7544ba67"}],"cinder/volume/drivers/dell_emc/vmax/fc.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"657922f613774a25ca9ed78dd3b2407c9b81e878","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.VERSION,"},{"line_number":118,"context_line":"            configuration\u003dself.configuration,"},{"line_number":119,"context_line":"            active_backend_id\u003dself.active_backend_id)"},{"line_number":120,"context_line":"        self.utils \u003d utils.VMAXUtils()"},{"line_number":121,"context_line":"        self.zonemanager_lookup_service \u003d fczm_utils.create_lookup_service()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ccf448d2","line":120,"updated":"2018-08-09 15:17:07.000000000","message":"I think that this class would reference self.common.utils and not construct its own utils object.","commit_id":"cb2d1e7dd1473e6e7aebd6d6c446161633fceffb"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"edb07941ee12dce0079f51ce2521fbfae37d5e05","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            self.VERSION,"},{"line_number":118,"context_line":"            configuration\u003dself.configuration,"},{"line_number":119,"context_line":"            active_backend_id\u003dself.active_backend_id)"},{"line_number":120,"context_line":"        self.utils \u003d utils.VMAXUtils()"},{"line_number":121,"context_line":"        self.zonemanager_lookup_service \u003d fczm_utils.create_lookup_service()"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def check_for_setup_error(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_43b0c243","line":120,"in_reply_to":"3f79a3b5_ccf448d2","updated":"2018-08-13 15:10:09.000000000","message":"Sure will change in the next patchset","commit_id":"cb2d1e7dd1473e6e7aebd6d6c446161633fceffb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"214225d2da62e31d99782d3d07dad4dad53214d4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"              - Fix for SSL verification/cert application (bug #1772924)"},{"line_number":99,"context_line":"              - Log VMAX metadata of a volume (bp vmax-metadata)"},{"line_number":100,"context_line":"              - Fix for get-pools command (bug #1784856)"},{"line_number":101,"context_line":"              - Fix for initiator retrieval and short hostname unmapping"},{"line_number":102,"context_line":"                (bugs #1783855 #1783867)"},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_3a9fb250","line":101,"updated":"2018-08-27 16:07:47.000000000","message":"Did you want to make this a 3.3.0 now since it missed Rocky?","commit_id":"86c63d5d3f016907270499ea08e707310883215c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"fd90c360a49b23a118eb627ee1f96f0a8821467b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"              - Fix for SSL verification/cert application (bug #1772924)"},{"line_number":99,"context_line":"              - Log VMAX metadata of a volume (bp vmax-metadata)"},{"line_number":100,"context_line":"              - Fix for get-pools command (bug #1784856)"},{"line_number":101,"context_line":"              - Fix for initiator retrieval and short hostname unmapping"},{"line_number":102,"context_line":"                (bugs #1783855 #1783867)"},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b4b98016","line":101,"in_reply_to":"3f79a3b5_3a9fb250","updated":"2018-08-28 13:31:30.000000000","message":"Hi Sean,\nYes, we will update the fc and iscsi files. Thanks","commit_id":"86c63d5d3f016907270499ea08e707310883215c"}],"cinder/volume/drivers/dell_emc/vmax/rest.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"657922f613774a25ca9ed78dd3b2407c9b81e878","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"            init_list \u003d []"},{"line_number":1340,"context_line":"        return init_list"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"    def get_in_use_initiator_list_from_array(self, array):"},{"line_number":1343,"context_line":"        \"\"\"Get the list of initiators which are in-use from the array."},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"        Gets the list of initiators from the array which are in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ccf52885","side":"PARENT","line":1342,"updated":"2018-08-09 15:17:07.000000000","message":"It may not be bad to keep this utility to get all the in-use initiators. Just not using it right now.","commit_id":"b2ceea84b883f48884007390df7258d1494ea7fd"},{"author":{"_account_id":23601,"name":"michael","display_name":"michael-mcaleer","email":"Michael.Mcaleer@dell.com","username":"michael-mcaleer"},"change_message_id":"edb07941ee12dce0079f51ce2521fbfae37d5e05","unresolved":false,"context_lines":[{"line_number":1339,"context_line":"            init_list \u003d []"},{"line_number":1340,"context_line":"        return init_list"},{"line_number":1341,"context_line":""},{"line_number":1342,"context_line":"    def get_in_use_initiator_list_from_array(self, array):"},{"line_number":1343,"context_line":"        \"\"\"Get the list of initiators which are in-use from the array."},{"line_number":1344,"context_line":""},{"line_number":1345,"context_line":"        Gets the list of initiators from the array which are in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c3d3725f","side":"PARENT","line":1342,"in_reply_to":"3f79a3b5_ccf52885","updated":"2018-08-13 15:10:09.000000000","message":"It is not in use anywhere else in the driver and is a potentially very expensive call. Initiator extraction should be retrieved more efficiently using initiator ID and not matching from a full list","commit_id":"b2ceea84b883f48884007390df7258d1494ea7fd"}]}