)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1ff2abb65bc3f127d80d76cb094e325faebce615","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp SolidFire: Fix NetApp SolidFire SSL option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option was added without a default value. It should default it"},{"line_number":10,"context_line":"to False in order to comply with the old behaviour."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic616bbcced22db6eb8c8946dec98aefd84b16c31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_84fdb66f","line":9,"updated":"2018-08-10 03:01:55.000000000","message":"This is incorrect:\n\nhttps://github.com/openstack/cinder/blob/adf262aef4ad5f441cd09c9bd8ec505450f1d25e/cinder/volume/driver.py#L211","commit_id":"ec8bfc601deef60034f96efce3b99a0f404adb67"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"e13f59396b599dc681b8dfa0d67895922cd3f88d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"NetApp SolidFire: Fix NetApp SolidFire SSL option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This option was added without a default value. It should default it"},{"line_number":10,"context_line":"to False in order to comply with the old behaviour."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic616bbcced22db6eb8c8946dec98aefd84b16c31"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_f3a78abc","line":9,"in_reply_to":"3f79a3b5_84fdb66f","updated":"2018-08-10 08:58:06.000000000","message":"Done","commit_id":"ec8bfc601deef60034f96efce3b99a0f404adb67"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1ff2abb65bc3f127d80d76cb094e325faebce615","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.default_cluster \u003d self._create_cluster_reference()"},{"line_number":256,"context_line":"        self.active_cluster \u003d self.default_cluster"},{"line_number":257,"context_line":"        self.verify_ssl \u003d self.configuration.safe_get("},{"line_number":258,"context_line":"            \u0027driver_ssl_cert_verify\u0027) or False"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # If we\u0027re failed over, we need to parse things out and set the active"},{"line_number":261,"context_line":"        # cluster appropriately"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e40caaa6","line":258,"updated":"2018-08-10 03:01:55.000000000","message":"This should not be necessary. The default value for this config is False:\n\nhttps://github.com/openstack/cinder/blob/adf262aef4ad5f441cd09c9bd8ec505450f1d25e/cinder/volume/driver.py#L211","commit_id":"ec8bfc601deef60034f96efce3b99a0f404adb67"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"e13f59396b599dc681b8dfa0d67895922cd3f88d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        self.default_cluster \u003d self._create_cluster_reference()"},{"line_number":256,"context_line":"        self.active_cluster \u003d self.default_cluster"},{"line_number":257,"context_line":"        self.verify_ssl \u003d self.configuration.safe_get("},{"line_number":258,"context_line":"            \u0027driver_ssl_cert_verify\u0027) or False"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        # If we\u0027re failed over, we need to parse things out and set the active"},{"line_number":261,"context_line":"        # cluster appropriately"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_f3954a34","line":258,"in_reply_to":"3f79a3b5_e40caaa6","updated":"2018-08-10 08:58:06.000000000","message":"You are right. Initially I tried to safe_get to solve the issue[1], but then I moved it to an early place in the initialization (which fixed the problem) and missed that in the patch.\n\n[1] http://logs.openstack.netapp.com/logs/86/590586/3/upstream-solidfire-check/cinder-solidfire-iSCSI/4bab015/logs/screen-c-vol.txt.gz#_Aug_10_05_16_08_392681","commit_id":"ec8bfc601deef60034f96efce3b99a0f404adb67"}]}