)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ef54e978eeb4678ec455a16e1b6b686f074d087f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"tranfers -\u003e transfers"},{"line_number":10,"context_line":"recurse -\u003e recursive"},{"line_number":11,"context_line":"satisified -\u003e satisfied"},{"line_number":12,"context_line":"sesssion -\u003e session"},{"line_number":13,"context_line":"explicity -\u003e explicitly"},{"line_number":14,"context_line":"parens -\u003e parents"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BIaU%3D","line":12,"updated":"2013-12-02 08:04:35.000000000","message":"I think you don\u0027t need to put these 3 here, just mention that there are other typos being fixed in Oslo is enough.","commit_id":"637201993431d2edcc93c9f0e2535211d175abe8"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"3cb1cbfc26636713879c87a01a9392a73016384a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"explicity -\u003e explicitly"},{"line_number":14,"context_line":"parens -\u003e parents"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The files of last three typos are Oslo managed modules files in Cinder. They will fix in another commit:https://review.openstack.org/#/c/59319/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6fc2be0414962f456a827d294e258637af665524"},{"line_number":19,"context_line":"Closes-Bug: #1255908"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BIVY%3D","line":16,"updated":"2013-12-02 08:42:16.000000000","message":"Also, since we\u0027re dealing with grammar:\n\"They are fixed in another commit: https://...\"","commit_id":"637201993431d2edcc93c9f0e2535211d175abe8"},{"author":{"_account_id":6604,"name":"zhangchao","email":"zhangchao010@huawei.com","username":"zhangchao010"},"change_message_id":"3af6df8f58cf7dfc18fda6d3c0d9f1e8da9482fe","unresolved":false,"context_lines":[{"line_number":13,"context_line":"explicity -\u003e explicitly"},{"line_number":14,"context_line":"parens -\u003e parents"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The files of last three typos are Oslo managed modules files in Cinder. They will fix in another commit:https://review.openstack.org/#/c/59319/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I6fc2be0414962f456a827d294e258637af665524"},{"line_number":19,"context_line":"Closes-Bug: #1255908"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2BIZA%3D","line":16,"updated":"2013-12-02 08:20:50.000000000","message":"Subsequent lines should be wrapped at 72 characters.\nPls see the link: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"637201993431d2edcc93c9f0e2535211d175abe8"}],"cinder/api/xmlutil.py":[{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"c303e6532427c223787ae971cdfab003ed584a17","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                    if child.tag in sib:"},{"line_number":615,"context_line":"                        nieces.append(sib[child.tag])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"                # Now we recursive for every data element"},{"line_number":618,"context_line":"                for elem, datum in elems:"},{"line_number":619,"context_line":"                    self._serialize(elem, datum, nieces)"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BM9Y%3D","line":617,"updated":"2013-11-29 08:40:18.000000000","message":"I feel \"recurse\" might not be an incorrect spelling. It might be equal with \"recursive\". I guess we need a verb here. Please wait for native speaker to input comments.","commit_id":"79bdb567a1a7e7dc58e39c628c83ffd83e000e23"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"a8c05249bcfebf7388c782c2b0f165a59b290e3a","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                    if child.tag in sib:"},{"line_number":615,"context_line":"                        nieces.append(sib[child.tag])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"                # Now we recursive for every data element"},{"line_number":618,"context_line":"                for elem, datum in elems:"},{"line_number":619,"context_line":"                    self._serialize(elem, datum, nieces)"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2BMXg%3D","line":617,"in_reply_to":"AAAATn%2F%2BM9Y%3D","updated":"2013-11-29 11:50:46.000000000","message":"Qin Zhao is correct, \u0027recursive\u0027 is certainly wrong here, recurse would be the verb, but I\u0027ve never heard it used. You could say:\n\"Now call this function recursively for each data element\"","commit_id":"79bdb567a1a7e7dc58e39c628c83ffd83e000e23"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ce92584e62d1619e362b7cb3520bdcb3feb32fe6","unresolved":false,"context_lines":[{"line_number":599,"context_line":"        # First step, render the element"},{"line_number":600,"context_line":"        elems \u003d siblings[0].render(parent, obj, siblings[1:], nsmap)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        # Now, call for all child elements recursive"},{"line_number":603,"context_line":"        seen \u003d set()"},{"line_number":604,"context_line":"        for idx, sibling in enumerate(siblings):"},{"line_number":605,"context_line":"            for child in sibling:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BIzI%3D","line":602,"updated":"2013-12-02 05:59:29.000000000","message":"should be: \u0027traverse all child elements\u0027, or \u0027go through all child elements\u0027","commit_id":"93a205845ff4d471cf3cf072348498aed3f42756"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ce92584e62d1619e362b7cb3520bdcb3feb32fe6","unresolved":false,"context_lines":[{"line_number":614,"context_line":"                    if child.tag in sib:"},{"line_number":615,"context_line":"                        nieces.append(sib[child.tag])"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"                # Now we call for every data element recursive"},{"line_number":618,"context_line":"                for elem, datum in elems:"},{"line_number":619,"context_line":"                    self._serialize(elem, datum, nieces)"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BIyk%3D","line":617,"updated":"2013-12-02 05:59:29.000000000","message":"should be \u0027call this function for all data elements recursively\u0027.","commit_id":"93a205845ff4d471cf3cf072348498aed3f42756"}],"cinder/openstack/common/db/sqlalchemy/models.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ce92584e62d1619e362b7cb3520bdcb3feb32fe6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        if not session:"},{"line_number":40,"context_line":"            session \u003d get_session()"},{"line_number":41,"context_line":"        # NOTE(boris-42): This part of code should be look like:"},{"line_number":42,"context_line":"        #                       session.add(self)"},{"line_number":43,"context_line":"        #                       session.flush()"},{"line_number":44,"context_line":"        #                 But there is a bug in sqlalchemy and eventlet that"},{"line_number":45,"context_line":"        #                 raises NoneType exception if there is no running"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BIzc%3D","line":42,"updated":"2013-12-02 05:59:29.000000000","message":"please leave it alone, and propose the fix in oslo.","commit_id":"93a205845ff4d471cf3cf072348498aed3f42756"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ce92584e62d1619e362b7cb3520bdcb3feb32fe6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        #                 raises NoneType exception if there is no running"},{"line_number":46,"context_line":"        #                 transaction and rollback is called. As long as"},{"line_number":47,"context_line":"        #                 sqlalchemy has this bug we have to create transaction"},{"line_number":48,"context_line":"        #                 explicitly."},{"line_number":49,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"            session.add(self)"},{"line_number":51,"context_line":"            session.flush()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BIzY%3D","line":48,"updated":"2013-12-02 05:59:29.000000000","message":"ditto","commit_id":"93a205845ff4d471cf3cf072348498aed3f42756"}],"cinder/openstack/common/periodic_task.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"ce92584e62d1619e362b7cb3520bdcb3feb32fe6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return f"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # NOTE(sirp): The `if` is necessary to allow the decorator to be used with"},{"line_number":87,"context_line":"    # and without parents."},{"line_number":88,"context_line":"    #"},{"line_number":89,"context_line":"    # In the \u0027with-parents\u0027 case (with kwargs present), this function needs to"},{"line_number":90,"context_line":"    # return a decorator function since the interpreter will invoke it like:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2BIzQ%3D","line":87,"updated":"2013-12-02 05:59:29.000000000","message":"same comment as model.py, \u0027cos this module is managed in Oslo.","commit_id":"93a205845ff4d471cf3cf072348498aed3f42756"}]}
