)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"dc06f0d7150e716aeac5d8af86c3e8ccbb2d6ab6","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                return True"},{"line_number":622,"context_line":"        return False"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @utils.retry(putils.ProcessExecutionError, retries\u003d1, backoff_rate\u003d2)"},{"line_number":625,"context_line":"    def deactivate_lv(self, name):"},{"line_number":626,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(name)"},{"line_number":627,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-a\u0027, \u0027n\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b510da4f","line":624,"range":{"start_line":624,"start_character":4,"end_line":624,"end_character":73},"updated":"2018-08-14 08:14:07.000000000","message":"ProcessExecutionError would be a little too broad? This command could fail due to different reasons.","commit_id":"69bb00c278d483e9e8d26e229d0fa06d672b154f"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"661d4317f5262dd9884f2435badfeaaf71cae967","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                return True"},{"line_number":622,"context_line":"        return False"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @utils.retry(putils.ProcessExecutionError, retries\u003d1, backoff_rate\u003d2)"},{"line_number":625,"context_line":"    def deactivate_lv(self, name):"},{"line_number":626,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(name)"},{"line_number":627,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-a\u0027, \u0027n\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_81448048","line":624,"range":{"start_line":624,"start_character":4,"end_line":624,"end_character":73},"in_reply_to":"3f79a3b5_b510da4f","updated":"2018-08-14 12:45:36.000000000","message":"We do want this to be broad I think. Although, looking through again I think we just want this to handle the case where the _wait_for_volume_deactivation fails, in which case we would only care about VolumeNotDeactivated exception.","commit_id":"69bb00c278d483e9e8d26e229d0fa06d672b154f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3ec40444814dd113a32abd7782737cdad1e02fa6","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                return True"},{"line_number":622,"context_line":"        return False"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @utils.retry(exception.VolumeNotDeactivated, retries\u003d1, backoff_rate\u003d2)"},{"line_number":625,"context_line":"    def deactivate_lv(self, name):"},{"line_number":626,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(name)"},{"line_number":627,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-a\u0027, \u0027n\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_f3cf4726","line":624,"updated":"2018-08-14 14:00:15.000000000","message":"If retries\u003d1, does backoff_rate actually have an effect?\n\nDon\u0027t you want \"interval\" instead?","commit_id":"ea6bdb664504a729a152f823d71d7114938db7f2"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"b761b389ff05468bfe59914b64cf4fc8b90ae986","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                return True"},{"line_number":622,"context_line":"        return False"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @utils.retry(exception.VolumeNotDeactivated, retries\u003d1, interval\u003d2)"},{"line_number":625,"context_line":"    def deactivate_lv(self, name):"},{"line_number":626,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(name)"},{"line_number":627,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-a\u0027, \u0027n\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_328cced5","line":624,"updated":"2018-08-14 22:22:29.000000000","message":"For my education does it re-try forever? Or does it give up after a given amount of time?","commit_id":"49f3c57d977e009f715ba21dc7175c931bbb3f70"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"68458cfd11d4470a907af82c1dc873e49520629a","unresolved":false,"context_lines":[{"line_number":621,"context_line":"                return True"},{"line_number":622,"context_line":"        return False"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    @utils.retry(exception.VolumeNotDeactivated, retries\u003d1, interval\u003d2)"},{"line_number":625,"context_line":"    def deactivate_lv(self, name):"},{"line_number":626,"context_line":"        lv_path \u003d self.vg_name + \u0027/\u0027 + self._mangle_lv_name(name)"},{"line_number":627,"context_line":"        cmd \u003d [\u0027lvchange\u0027, \u0027-a\u0027, \u0027n\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fe66eeee","line":624,"in_reply_to":"3f79a3b5_328cced5","updated":"2018-08-28 18:50:35.000000000","message":"It only retries once according to the retries\u003d1 param.","commit_id":"49f3c57d977e009f715ba21dc7175c931bbb3f70"}]}