)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/scaleio/mocks.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9f1361b5509b66f6e3d534c00d6f23c6d2920435","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def unmanage(self, volume):"},{"line_number":41,"context_line":"        pass"},{"line_number":42,"context_line":"    "},{"line_number":43,"context_line":"    def _is_volume_creation_safe(self, _pd, _sp):"},{"line_number":44,"context_line":"        return True"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_26c8fba3","line":42,"updated":"2018-08-15 20:47:59.000000000","message":"Bah, extra blank spaces.","commit_id":"edb7de0467def1f018a37549ac30cf38d170db55"}],"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2ae382b7bbcc2a6e528b8b6cb5f3faa982d7257a","unresolved":false,"context_lines":[{"line_number":507,"context_line":"           to existing data being read off of a newly created volume"},{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        # if we have been told to allow unsafe volumes"},{"line_number":510,"context_line":"        if self.configuration.sio_allow_non_padded_volumes or self.configuration.sio_allow_non_padded_thick_volumes:"},{"line_number":511,"context_line":"            return True"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_10b2e049","line":510,"updated":"2018-08-15 12:50:03.000000000","message":"Line too long. This will hit a pep8 error. Wrap the conditionals in () to span lines.","commit_id":"91af13a7b10be7a59da8113373e123fdd46b25f0"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"313cb7929488c2f00f68beaa3c447e080bcb6fca","unresolved":false,"context_lines":[{"line_number":507,"context_line":"           to existing data being read off of a newly created volume"},{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        # if we have been told to allow unsafe volumes"},{"line_number":510,"context_line":"        if (self.configuration.sio_allow_non_padded_volumes"},{"line_number":511,"context_line":"                or self.configuration.sio_allow_non_padded_thick_volumes):"},{"line_number":512,"context_line":"            return True"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            properties \u003d self._get_storage_pool_properties(protection_domain,"},{"line_number":515,"context_line":"                                                           storage_pool)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_2d253e09","line":512,"range":{"start_line":510,"start_character":0,"end_line":512,"end_character":23},"updated":"2018-08-15 18:39:20.000000000","message":"This results in creation being allowed if either option is set to true.  I don\u0027t know that this is really the right behavior given that this is a security bug.  I think it should be clear that it has been discovered that there is a security issue for both thick and thin volumes.  This will result in customers possibly having to add the config option but it also means they have been made aware there is an issue as happened when this change was added for thick volumes.","commit_id":"b9aef5c78fd4a50d6811a167bbfb631f97f09fce"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9f1361b5509b66f6e3d534c00d6f23c6d2920435","unresolved":false,"context_lines":[{"line_number":508,"context_line":"        \"\"\""},{"line_number":509,"context_line":"        # if we have been told to allow unsafe volumes"},{"line_number":510,"context_line":"        if (self.configuration.sio_allow_non_padded_volumes"},{"line_number":511,"context_line":"                or self.configuration.sio_allow_non_padded_thick_volumes):"},{"line_number":512,"context_line":"            return True"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            properties \u003d self._get_storage_pool_properties(protection_domain,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_86cd4fb8","line":511,"updated":"2018-08-15 20:47:59.000000000","message":"Thin provisioned volumes will now be blocked even if only sio_allow_non_padded_thick_volumes is set to true.\n\nPersonally, I\u0027m fine with that, but might want to consider that.","commit_id":"edb7de0467def1f018a37549ac30cf38d170db55"}]}