)]}'
{"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"75a773f36f8ab745a68aaa044e9e4ef5a44261c7","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":280,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":281,"context_line":"        return int(size * units.Gi / units.Ki)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _vol_size_to_cinder(self, size):"},{"line_number":284,"context_line":"        return int(size * units.Ki / units.Gi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_6092e64d","line":281,"range":{"start_line":281,"start_character":35,"end_line":281,"end_character":36},"updated":"2018-08-21 14:53:27.000000000","message":"Please just change this to // to use the pep238 floor division.","commit_id":"ab90c0df1c404cb7155bf326dfd26e24dd106e67"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"304b4d054f87d79b2ebc98b824908d226469c94b","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":280,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":281,"context_line":"        return int(size * units.Gi / units.Ki)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _vol_size_to_cinder(self, size):"},{"line_number":284,"context_line":"        return int(size * units.Ki / units.Gi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a34328af","line":281,"range":{"start_line":281,"start_character":35,"end_line":281,"end_character":36},"in_reply_to":"3f79a3b5_6092e64d","updated":"2018-08-21 15:28:31.000000000","message":"Hi Sean, i took the reference from other drivers,\nshould i address the same change in other drivers too?\nLike here : https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L381","commit_id":"ab90c0df1c404cb7155bf326dfd26e24dd106e67"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7d40ebe04ed44c74c5f1b53b4c50870f731bf3c9","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":280,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":281,"context_line":"        return int(size * units.Gi / units.Ki)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _vol_size_to_cinder(self, size):"},{"line_number":284,"context_line":"        return int(size * units.Ki / units.Gi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_633430fc","line":281,"range":{"start_line":281,"start_character":35,"end_line":281,"end_character":36},"in_reply_to":"3f79a3b5_8392acf5","updated":"2018-08-21 15:36:52.000000000","message":"Ok :)","commit_id":"ab90c0df1c404cb7155bf326dfd26e24dd106e67"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d29bb6b438038ac7338ab635dd0fa32c27571ede","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    # DRBDmanage works in kiB units; Cinder uses GiB."},{"line_number":280,"context_line":"    def _vol_size_to_dm(self, size):"},{"line_number":281,"context_line":"        return int(size * units.Gi / units.Ki)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _vol_size_to_cinder(self, size):"},{"line_number":284,"context_line":"        return int(size * units.Ki / units.Gi)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8392acf5","line":281,"range":{"start_line":281,"start_character":35,"end_line":281,"end_character":36},"in_reply_to":"3f79a3b5_a34328af","updated":"2018-08-21 15:32:21.000000000","message":"Thanks for looking for other cases. I think if the code is already using int() that is fine to leave. The important thing is to make sure that the behavior doesn\u0027t change between python 2 and 3. Ideally they would all just use // where needed, but no strong reason to update existing code that is safe.","commit_id":"ab90c0df1c404cb7155bf326dfd26e24dd106e67"}]}