)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"56ed583bfa5fe8b1f4c223b1bd04460acbfa85b9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"(cherry picked from commit 7feb62197d371ab7253dc86a34af6ff8b484b4df)"},{"line_number":27,"context_line":"(cherry picked from commit 949cc46e162e00092aa85a7be921649c8dbf2bf8)"},{"line_number":28,"context_line":"(cherry picked from commit 8d0dea694a366cb3797748d389ca76b7864af16f)"},{"line_number":29,"context_line":"(cherry picked from commit 13a6689ccb7751c9f9b5c37ce0a3f75eb7665a95)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_da1ea50c","line":29,"range":{"start_line":29,"start_character":27,"end_line":29,"end_character":45},"updated":"2018-08-28 14:12:45.000000000","message":"Still need to merge this into stable/rocky.","commit_id":"f0cef07bef5ea8ed29179ee3774df5f4a634ba86"}],"cinder/volume/drivers/dell_emc/scaleio/driver.py":[{"author":{"_account_id":13953,"name":"Elise Gafford","email":"egafford@redhat.com","username":"egafford"},"change_message_id":"bef6832b270b16c48e223c186ea5742b04559956","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        allowed \u003d self._is_volume_creation_safe(protection_domain_name,"},{"line_number":598,"context_line":"                                                storage_pool_name)"},{"line_number":599,"context_line":"        if not allowed:"},{"line_number":600,"context_line":"            # Do not allow thick volume creation on this backend."},{"line_number":601,"context_line":"            # Volumes may leak data between tenants."},{"line_number":602,"context_line":"            LOG.error(\"Volume creation rejected due to \""},{"line_number":603,"context_line":"                      \"zero padding being disabled for pool, %s:%s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_450c0aeb","line":600,"updated":"2018-08-27 22:26:52.000000000","message":"It is a very minor sorrow that this comment snuck through to this set of cherry picks, since the question of whether the volume is thin or thick does not have bearing on whether volume creation is allowed.\n\nIt\u0027s a decision for the team whether to leave the comment as-is (to preserve the integrity of the cherry picks) or to change it (to make it more accurate). Both are pretty sane.","commit_id":"f0cef07bef5ea8ed29179ee3774df5f4a634ba86"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9a9ba3954dc6fc9a00a3bcaa05420cd6ffa413e2","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        allowed \u003d self._is_volume_creation_safe(protection_domain_name,"},{"line_number":598,"context_line":"                                                storage_pool_name)"},{"line_number":599,"context_line":"        if not allowed:"},{"line_number":600,"context_line":"            # Do not allow thick volume creation on this backend."},{"line_number":601,"context_line":"            # Volumes may leak data between tenants."},{"line_number":602,"context_line":"            LOG.error(\"Volume creation rejected due to \""},{"line_number":603,"context_line":"                      \"zero padding being disabled for pool, %s:%s. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_772a0a7f","line":600,"in_reply_to":"3f79a3b5_450c0aeb","updated":"2018-08-28 13:40:26.000000000","message":"Good catch. I\u0027ve proposed https://review.openstack.org/597125 to master to clean up this and another reference to thick provisioning and will look at backporting that.","commit_id":"f0cef07bef5ea8ed29179ee3774df5f4a634ba86"}]}