)]}'
{"cinder/volume/drivers/fujitsu/eternus_dx_common.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e22a2dfba43e027833fbd4325aa02c2d5da0ba9","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"        return ret"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"    @lockutils.synchronized(\u0027ETERNUS-SMIS-exec\u0027, \u0027cinder-\u0027, True)"},{"line_number":1254,"context_line":"    @utils.retry(exception.VolumeBackendAPIException, interval\u003dRETRY_INTERVAL,"},{"line_number":1255,"context_line":"                 retries\u003dET_RETRIES)"},{"line_number":1256,"context_line":"    def _exec_eternus_service(self, classname, instanceNameList, **param_dict):"},{"line_number":1257,"context_line":"        \"\"\"Execute SMI-S Method.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4c51bc0d","line":1254,"range":{"start_line":1254,"start_character":63,"end_line":1254,"end_character":77},"updated":"2018-09-06 17:00:13.000000000","message":"These are the default values for the retry decorator. I think it would be better to just provide the exception to retry on and rely on the defaults for the rest.","commit_id":"3f9ac3e737a5cec3be1028c1d4ed086fff14bb34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef6064e809b4e1338c7624d2a4d44187b22f5ac7","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"        return ret"},{"line_number":1252,"context_line":""},{"line_number":1253,"context_line":"    @lockutils.synchronized(\u0027ETERNUS-SMIS-exec\u0027, \u0027cinder-\u0027, True)"},{"line_number":1254,"context_line":"    @utils.retry(exception.VolumeBackendAPIException, interval\u003dRETRY_INTERVAL,"},{"line_number":1255,"context_line":"                 retries\u003dET_RETRIES)"},{"line_number":1256,"context_line":"    def _exec_eternus_service(self, classname, instanceNameList, **param_dict):"},{"line_number":1257,"context_line":"        \"\"\"Execute SMI-S Method.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2757b903","line":1254,"range":{"start_line":1254,"start_character":63,"end_line":1254,"end_character":77},"in_reply_to":"3f79a3b5_4c51bc0d","updated":"2018-09-06 17:44:24.000000000","message":"Done","commit_id":"3f9ac3e737a5cec3be1028c1d4ed086fff14bb34"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e22a2dfba43e027833fbd4325aa02c2d5da0ba9","unresolved":false,"context_lines":[{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"        if rc \u003d\u003d DEVICE_IS_BUSY:"},{"line_number":1287,"context_line":"            msg \u003d _(\u0027Device is in Busy state\u0027)"},{"line_number":1288,"context_line":"            raise exception.CinderException(data\u003dmsg)"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"        errordesc \u003d RETCODE_dic.get(six.text_type(rc), UNDEF_MSG)"},{"line_number":1291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_cc3cecc0","line":1288,"range":{"start_line":1288,"start_character":28,"end_line":1288,"end_character":43},"updated":"2018-09-06 17:00:13.000000000","message":"Something better than CinderException should be used here. Probably VolumeBackendAPIException or VolumeDriverException.","commit_id":"3f9ac3e737a5cec3be1028c1d4ed086fff14bb34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef6064e809b4e1338c7624d2a4d44187b22f5ac7","unresolved":false,"context_lines":[{"line_number":1285,"context_line":""},{"line_number":1286,"context_line":"        if rc \u003d\u003d DEVICE_IS_BUSY:"},{"line_number":1287,"context_line":"            msg \u003d _(\u0027Device is in Busy state\u0027)"},{"line_number":1288,"context_line":"            raise exception.CinderException(data\u003dmsg)"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"        errordesc \u003d RETCODE_dic.get(six.text_type(rc), UNDEF_MSG)"},{"line_number":1291,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_e73c61c0","line":1288,"range":{"start_line":1288,"start_character":28,"end_line":1288,"end_character":43},"in_reply_to":"3f79a3b5_cc3cecc0","updated":"2018-09-06 17:44:24.000000000","message":"Done","commit_id":"3f9ac3e737a5cec3be1028c1d4ed086fff14bb34"}]}