)]}'
{"cinder/tests/unit/volume/drivers/solidfire/test_solidfire.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    def test_delete_group_snap_cg(self, group_cg_test):"},{"line_number":1824,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1825,"context_line":"        group_cg_test.return_value \u003d True"},{"line_number":1826,"context_line":"        cgsnapshot \u003d {\u0027id\u0027: \u0027acceptable_cgsnap_id\u0027}"},{"line_number":1827,"context_line":"        snapshots \u003d [{\u0027volume_id\u0027: \u0027one\u0027},"},{"line_number":1828,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_633f33b5","line":1828,"range":{"start_line":1826,"start_character":0,"end_line":1828,"end_character":42},"updated":"2018-09-03 17:16:45.000000000","message":"We shouldn\u0027t be using dictionaries, we should be using OVOs, and they should be using real UUIDs.\n\nIn this case I think you can even use mock.sentinel.cgsnaphot and mock.sentinel.snap1, etc","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1823,"context_line":"    def test_delete_group_snap_cg(self, group_cg_test):"},{"line_number":1824,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1825,"context_line":"        group_cg_test.return_value \u003d True"},{"line_number":1826,"context_line":"        cgsnapshot \u003d {\u0027id\u0027: \u0027acceptable_cgsnap_id\u0027}"},{"line_number":1827,"context_line":"        snapshots \u003d [{\u0027volume_id\u0027: \u0027one\u0027},"},{"line_number":1828,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_de77fc07","line":1828,"range":{"start_line":1826,"start_character":0,"end_line":1828,"end_character":42},"in_reply_to":"3f79a3b5_633f33b5","updated":"2018-09-04 11:51:04.000000000","message":"Done","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1832,"context_line":"            model_update \u003d sfv.delete_group_snapshot(self.ctxt,"},{"line_number":1833,"context_line":"                                                     cgsnapshot, snapshots)"},{"line_number":1834,"context_line":"            get.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_833a8fc1","line":1831,"range":{"start_line":1831,"start_character":51,"end_line":1831,"end_character":54},"updated":"2018-09-03 17:16:45.000000000","message":"why is it called get if it\u0027s a delete method call?","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1828,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1829,"context_line":""},{"line_number":1830,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1832,"context_line":"            model_update \u003d sfv.delete_group_snapshot(self.ctxt,"},{"line_number":1833,"context_line":"                                                     cgsnapshot, snapshots)"},{"line_number":1834,"context_line":"            get.assert_called_once()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_de605c38","line":1831,"range":{"start_line":1831,"start_character":51,"end_line":1831,"end_character":54},"in_reply_to":"3f79a3b5_833a8fc1","updated":"2018-09-04 11:51:04.000000000","message":"Because it was \u0027gotten\u0027 from the test above :D. Fixed.","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1832,"context_line":"            model_update \u003d sfv.delete_group_snapshot(self.ctxt,"},{"line_number":1833,"context_line":"                                                     cgsnapshot, snapshots)"},{"line_number":1834,"context_line":"            get.assert_called_once()"},{"line_number":1835,"context_line":"            self.assertEqual({}, model_update)"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    @mock.patch(\u0027cinder.volume.utils.is_group_a_cg_snapshot_type\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e374a39e","line":1834,"updated":"2018-09-03 17:16:45.000000000","message":"shouldn\u0027t we be checking the parameters we are passing?","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1831,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1832,"context_line":"            model_update \u003d sfv.delete_group_snapshot(self.ctxt,"},{"line_number":1833,"context_line":"                                                     cgsnapshot, snapshots)"},{"line_number":1834,"context_line":"            get.assert_called_once()"},{"line_number":1835,"context_line":"            self.assertEqual({}, model_update)"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    @mock.patch(\u0027cinder.volume.utils.is_group_a_cg_snapshot_type\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_eeb7a0d7","line":1834,"in_reply_to":"3f79a3b5_e374a39e","updated":"2018-09-04 11:51:04.000000000","message":"Done","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    def test_delete_group_snap(self, group_cg_test):"},{"line_number":1839,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1840,"context_line":"        group_cg_test.return_value \u003d False"},{"line_number":1841,"context_line":"        cgsnapshot \u003d {\u0027id\u0027: \u0027acceptable_cgsnap_id\u0027}"},{"line_number":1842,"context_line":"        snapshots \u003d [{\u0027volume_id\u0027: \u0027one\u0027},"},{"line_number":1843,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a36eabc6","line":1843,"range":{"start_line":1841,"start_character":0,"end_line":1843,"end_character":42},"updated":"2018-09-03 17:16:45.000000000","message":"Same as above","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1838,"context_line":"    def test_delete_group_snap(self, group_cg_test):"},{"line_number":1839,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1840,"context_line":"        group_cg_test.return_value \u003d False"},{"line_number":1841,"context_line":"        cgsnapshot \u003d {\u0027id\u0027: \u0027acceptable_cgsnap_id\u0027}"},{"line_number":1842,"context_line":"        snapshots \u003d [{\u0027volume_id\u0027: \u0027one\u0027},"},{"line_number":1843,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9e5ae480","line":1843,"range":{"start_line":1841,"start_character":0,"end_line":1843,"end_character":42},"in_reply_to":"3f79a3b5_a36eabc6","updated":"2018-09-04 11:51:04.000000000","message":"Done","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1847,"context_line":"            get.assert_not_called()"},{"line_number":1848,"context_line":"            self.assertRaises(NotImplementedError, sfv.delete_group_snapshot,"},{"line_number":1849,"context_line":"                              self.ctxt, cgsnapshot, snapshots)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c37167aa","line":1846,"range":{"start_line":1846,"start_character":51,"end_line":1846,"end_character":54},"updated":"2018-09-03 17:16:45.000000000","message":"same as above","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1843,"context_line":"                     {\u0027volume_id\u0027: \u0027two\u0027}]"},{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1847,"context_line":"            get.assert_not_called()"},{"line_number":1848,"context_line":"            self.assertRaises(NotImplementedError, sfv.delete_group_snapshot,"},{"line_number":1849,"context_line":"                              self.ctxt, cgsnapshot, snapshots)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_be5d607a","line":1846,"range":{"start_line":1846,"start_character":51,"end_line":1846,"end_character":54},"in_reply_to":"3f79a3b5_c37167aa","updated":"2018-09-04 11:51:04.000000000","message":"Done","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"45fce65ba0fe74e91d8d8c5e1d1abe17402ebe29","unresolved":false,"context_lines":[{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1847,"context_line":"            get.assert_not_called()"},{"line_number":1848,"context_line":"            self.assertRaises(NotImplementedError, sfv.delete_group_snapshot,"},{"line_number":1849,"context_line":"                              self.ctxt, cgsnapshot, snapshots)"},{"line_number":1850,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_636893b9","line":1847,"updated":"2018-09-03 17:16:45.000000000","message":"this needs to be called after we actually call the delete_group_snapshot method, otherwise it would always be true.","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"2e5f7c08e0d714bf8e2c998ed4b2e416a2807af0","unresolved":false,"context_lines":[{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1846,"context_line":"                               return_value\u003d{}) as get:"},{"line_number":1847,"context_line":"            get.assert_not_called()"},{"line_number":1848,"context_line":"            self.assertRaises(NotImplementedError, sfv.delete_group_snapshot,"},{"line_number":1849,"context_line":"                              self.ctxt, cgsnapshot, snapshots)"},{"line_number":1850,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5e544c54","line":1847,"in_reply_to":"3f79a3b5_636893b9","updated":"2018-09-04 11:51:04.000000000","message":"Done","commit_id":"9b7288b4e137a322e9ee84f949241ad764a0c1f0"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"836ce6bc2d2453177b4d41b21cdcf867bdef8327","unresolved":false,"context_lines":[{"line_number":1826,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1827,"context_line":"        group_cg_test.return_value \u003d True"},{"line_number":1828,"context_line":"        cgsnapshot \u003d fake_group_snapshot.fake_group_snapshot_obj("},{"line_number":1829,"context_line":"            mock.MagicMock())"},{"line_number":1830,"context_line":"        snapshots \u003d fake_snapshot.fake_snapshot_obj(mock.MagicMock())"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_e19491ea","line":1829,"updated":"2018-09-04 12:50:20.000000000","message":"nit: Use `self.ctxt` instead","commit_id":"29cf1e4fd93d151d8c91e0c258267768c743ee61"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"836ce6bc2d2453177b4d41b21cdcf867bdef8327","unresolved":false,"context_lines":[{"line_number":1827,"context_line":"        group_cg_test.return_value \u003d True"},{"line_number":1828,"context_line":"        cgsnapshot \u003d fake_group_snapshot.fake_group_snapshot_obj("},{"line_number":1829,"context_line":"            mock.MagicMock())"},{"line_number":1830,"context_line":"        snapshots \u003d fake_snapshot.fake_snapshot_obj(mock.MagicMock())"},{"line_number":1831,"context_line":""},{"line_number":1832,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1833,"context_line":"                               return_value\u003d{}) as _del_mock:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_019aed12","line":1830,"updated":"2018-09-04 12:50:20.000000000","message":"ditto","commit_id":"29cf1e4fd93d151d8c91e0c258267768c743ee61"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"836ce6bc2d2453177b4d41b21cdcf867bdef8327","unresolved":false,"context_lines":[{"line_number":1841,"context_line":"        sfv \u003d solidfire.SolidFireDriver(configuration\u003dself.configuration)"},{"line_number":1842,"context_line":"        group_cg_test.return_value \u003d False"},{"line_number":1843,"context_line":"        cgsnapshot \u003d fake_group_snapshot.fake_group_snapshot_obj("},{"line_number":1844,"context_line":"            mock.MagicMock())"},{"line_number":1845,"context_line":"        snapshots \u003d fake_snapshot.fake_snapshot_obj(mock.MagicMock())"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_a19a1910","line":1844,"updated":"2018-09-04 12:50:20.000000000","message":"ditto","commit_id":"29cf1e4fd93d151d8c91e0c258267768c743ee61"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"836ce6bc2d2453177b4d41b21cdcf867bdef8327","unresolved":false,"context_lines":[{"line_number":1842,"context_line":"        group_cg_test.return_value \u003d False"},{"line_number":1843,"context_line":"        cgsnapshot \u003d fake_group_snapshot.fake_group_snapshot_obj("},{"line_number":1844,"context_line":"            mock.MagicMock())"},{"line_number":1845,"context_line":"        snapshots \u003d fake_snapshot.fake_snapshot_obj(mock.MagicMock())"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"        with mock.patch.object(sfv, \u0027_delete_cgsnapshot\u0027,"},{"line_number":1848,"context_line":"                               return_value\u003d{}) as _del_mock:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_618881c5","line":1845,"updated":"2018-09-04 12:50:20.000000000","message":"ditto","commit_id":"29cf1e4fd93d151d8c91e0c258267768c743ee61"}]}