)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f1ae0f6a39c748e7b0f2bac8bd8b78da1bfb0729","unresolved":false,"context_lines":[{"line_number":21,"context_line":"or"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"extra_capabilities\u003d\u0027{\"service_level\"\u003d\"medium\"}\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I1ee9dcb22b3f097c3f3b2a70b0cb672930407cc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9ZS0%3D","line":24,"updated":"2013-12-11 23:10:11.000000000","message":"Need DocImpact tag please.","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0fea6c5470fb62c4bc0e48d34d82d295b67edf80","unresolved":false,"context_lines":[{"line_number":21,"context_line":"or"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"extra_capabilities\u003d\u0027{\"service_level\"\u003d\"medium\"}\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Change-Id: I1ee9dcb22b3f097c3f3b2a70b0cb672930407cc9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9VZ8%3D","line":24,"in_reply_to":"AAAATn%2F9ZS0%3D","updated":"2013-12-12 15:10:09.000000000","message":"Done","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"}],"cinder/manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f83e881a5ecd7a44762a048e46722ff195239679","unresolved":false,"context_lines":[{"line_number":70,"context_line":"capability_opts \u003d ["},{"line_number":71,"context_line":"    cfg.StrOpt(\u0027extra_capabilities\u0027,"},{"line_number":72,"context_line":"               default\u003d\u0027{}\u0027,"},{"line_number":73,"context_line":"               help\u003d\u0027User defined capabilities\u0027), ]"},{"line_number":74,"context_line":"CONF.register_opts(capability_opts)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F94cs%3D","line":73,"updated":"2013-12-04 22:20:32.000000000","message":"Would be good to given an example here like you do in the commit message.","commit_id":"702eff7172c14878463ea5c7f0370c5baebc265e"}],"cinder/tests/test_volume.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"bddf4b233d9ec567cec5d6443d58ce0257ea3d93","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                          volume[\u0027id\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_extra_capabilities(self):"},{"line_number":392,"context_line":"        \"\"\"Test valid extra_capabilities\"\"\""},{"line_number":393,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":394,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":395,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9i%2Bg%3D","line":392,"updated":"2013-12-10 11:35:08.000000000","message":"Period at end of docstring (not sure if a test should also comply with it)","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0fea6c5470fb62c4bc0e48d34d82d295b67edf80","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                          volume[\u0027id\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_extra_capabilities(self):"},{"line_number":392,"context_line":"        \"\"\"Test valid extra_capabilities\"\"\""},{"line_number":393,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":394,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":395,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9VZw%3D","line":392,"in_reply_to":"AAAATn%2F9b3M%3D","updated":"2013-12-12 15:10:09.000000000","message":"Done","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"53af9e5b7b9616f3d75e5d3f3d98a6cc96a9a542","unresolved":false,"context_lines":[{"line_number":389,"context_line":"                          volume[\u0027id\u0027])"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_extra_capabilities(self):"},{"line_number":392,"context_line":"        \"\"\"Test valid extra_capabilities\"\"\""},{"line_number":393,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":394,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":395,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9b3M%3D","line":392,"in_reply_to":"AAAATn%2F9i%2Bg%3D","updated":"2013-12-11 15:04:03.000000000","message":"Actually tests shouldn\u0027t have docstrings - they should have comments starting with #","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"bddf4b233d9ec567cec5d6443d58ce0257ea3d93","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.mox.UnsetStubs()"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_extra_capabilities_fail(self):"},{"line_number":406,"context_line":"        \"\"\"Test invalid extra_capabilities\"\"\""},{"line_number":407,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":408,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":409,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9i%2Bc%3D","line":406,"updated":"2013-12-10 11:35:08.000000000","message":"Period at end of docstring (not sure if a test should also comply with it)","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0fea6c5470fb62c4bc0e48d34d82d295b67edf80","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.mox.UnsetStubs()"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_extra_capabilities_fail(self):"},{"line_number":406,"context_line":"        \"\"\"Test invalid extra_capabilities\"\"\""},{"line_number":407,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":408,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":409,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9VZo%3D","line":406,"in_reply_to":"AAAATn%2F9b3I%3D","updated":"2013-12-12 15:10:09.000000000","message":"Done","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"53af9e5b7b9616f3d75e5d3f3d98a6cc96a9a542","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        self.mox.UnsetStubs()"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_extra_capabilities_fail(self):"},{"line_number":406,"context_line":"        \"\"\"Test invalid extra_capabilities\"\"\""},{"line_number":407,"context_line":"        self.mox.StubOutWithMock(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":408,"context_line":"        self.volume.driver.initialized \u003d True"},{"line_number":409,"context_line":"        self.mox.StubOutWithMock(json, \u0027loads\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9b3I%3D","line":406,"in_reply_to":"AAAATn%2F9i%2Bc%3D","updated":"2013-12-11 15:04:03.000000000","message":"Ditto","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"c3caa2d613ced858e37909141dc042e64674bc25","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            self.assertTrue(mock_loads.called)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def test_extra_capabilities_fail(self):"},{"line_number":415,"context_line":"        # Test invalid extra_capabilities."},{"line_number":416,"context_line":"        mock.patch.object(self.volume.driver.__class__, \u0027initialized\u0027)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        self.volume.driver.__class__.initialized \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F85UQ%3D","line":415,"updated":"2013-12-19 02:41:53.000000000","message":"for this test case, i see the need to verify no extra capabilities being passed to scheduler at all due to failure of json.loads().  for example, if extra_cap \u003d {\u0027key1\u0027: \u0027v1\u0027, \u0027key2\u0027: \u0027v2\u0027, \u0027key3\u0027: True}, the value for \u0027key3\u0027 would cause exception when deserialize, please do a check that \u0027key1\u0027, \u0027key2\u0027 is either not in self._stats or not being updated.","commit_id":"83971637e4a17cfcbb28d6d03bc2b115570e2467"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"ffdb627c5903c2e2248b6abd51a336517ec65dbf","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    def test_extra_capabilities(self):"},{"line_number":470,"context_line":"        # Test valid extra_capabilities."},{"line_number":471,"context_line":"        fake_capabilities \u003d {\u0027key1\u0027: 1, \u0027key2\u0027: 2}"},{"line_number":472,"context_line":"        patcher \u003d mock.patch.object(self.volume.driver.__class__,"},{"line_number":473,"context_line":"                                    \u0027initialized\u0027)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        patcher.start()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2Ft1g%3D","line":472,"updated":"2014-02-25 04:57:02.000000000","message":"In the unit tests, why create a patcher and start it, and stop it at the end?  Wouldn\u0027t using the mock decorator be cleaner?\n\n(Applies to all unit tests added here)","commit_id":"c47e5eab9f82fa8d03fd5797509cb0562b1f5554"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"6522de6f0d3d5e2b70a544ca172e1f36dfe17e1b","unresolved":false,"context_lines":[{"line_number":469,"context_line":"    def test_extra_capabilities(self):"},{"line_number":470,"context_line":"        # Test valid extra_capabilities."},{"line_number":471,"context_line":"        fake_capabilities \u003d {\u0027key1\u0027: 1, \u0027key2\u0027: 2}"},{"line_number":472,"context_line":"        patcher \u003d mock.patch.object(self.volume.driver.__class__,"},{"line_number":473,"context_line":"                                    \u0027initialized\u0027)"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        patcher.start()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2Frac%3D","line":472,"in_reply_to":"AAAAU3%2F%2Ft1g%3D","updated":"2014-02-25 10:05:54.000000000","message":"I agree that this looks awkward. The reason it\u0027s done that way is that the mock on driver._initialised was not being cleared when this test completed. So other unit tests were failing, that was the problem with test_migrate_driver_not_initialized at patch set 7. I\u0027m pretty sure I tried using the mock decorator before the patcher, but I\u0027ll investigate some more to see if there is a tidier way to do this.","commit_id":"c47e5eab9f82fa8d03fd5797509cb0562b1f5554"}],"cinder/volume/manager.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0974587c0ec24b380ff09b680a9bf86c56800438","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                    self.driver.configuration.extra_capabilities)"},{"line_number":837,"context_line":"            except Exception as ex:"},{"line_number":838,"context_line":"                LOG.warning(_(\"Failed to parse extra_capabilities: %s\"),"},{"line_number":839,"context_line":"                            CONF.extra_capabilities)"},{"line_number":840,"context_line":"                extra_capabilities \u003d {}"},{"line_number":841,"context_line":"            if extra_capabilities:"},{"line_number":842,"context_line":"                volume_stats.update(extra_capabilities)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9p%2B4%3D","line":839,"updated":"2013-12-09 08:07:33.000000000","message":"Should this be self.driver.configuratoin.extra_capabilities?","commit_id":"7679aa1974d4530bf8d4f539cd3ee77721cf4624"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"c9cbbac47b10db3cfe81f8cb48299579b311543e","unresolved":false,"context_lines":[{"line_number":836,"context_line":"                    self.driver.configuration.extra_capabilities)"},{"line_number":837,"context_line":"            except Exception as ex:"},{"line_number":838,"context_line":"                LOG.warning(_(\"Failed to parse extra_capabilities: %s\"),"},{"line_number":839,"context_line":"                            CONF.extra_capabilities)"},{"line_number":840,"context_line":"                extra_capabilities \u003d {}"},{"line_number":841,"context_line":"            if extra_capabilities:"},{"line_number":842,"context_line":"                volume_stats.update(extra_capabilities)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9pTg%3D","line":839,"in_reply_to":"AAAATn%2F9p%2B4%3D","updated":"2013-12-09 11:03:10.000000000","message":"oops! thank you, done","commit_id":"7679aa1974d4530bf8d4f539cd3ee77721cf4624"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"82beca04870203ca8ceb5175c22697c553957bd4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     \u0027volume service startup\u0027),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027extra_capabilities\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027{}\u0027,"},{"line_number":83,"context_line":"               help\u003d\u0027User defined capabilities\u0027),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2B9j4%3D","line":83,"updated":"2014-02-18 00:12:56.000000000","message":"Given that it appears that there is something that needs to be fixed yet given the Jenkins failure.  I think we should put a little more detail in this help.   I.E. help\u003d\u0027User defined capabilities in the form of key/value pairs.\u0027 or something similar.  I guess that users can then go to the documentation for more detail.","commit_id":"f6c6525572c01c1c26d3cf76e401dce012708107"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"516dd8992fb83ec099ceda167ce7d4c4cd67b5e6","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                     \u0027volume service startup\u0027),"},{"line_number":81,"context_line":"    cfg.StrOpt(\u0027extra_capabilities\u0027,"},{"line_number":82,"context_line":"               default\u003d\u0027{}\u0027,"},{"line_number":83,"context_line":"               help\u003d\u0027User defined capabilities\u0027),"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2BwwA%3D","line":83,"in_reply_to":"AAAAUX%2F%2B9j4%3D","updated":"2014-02-19 08:18:20.000000000","message":"I can\u0027t reproduce the jenkins falures, so I\u0027m making the change suggested here and I\u0027ll do some work on trying to reproduce the failures if they persist.","commit_id":"f6c6525572c01c1c26d3cf76e401dce012708107"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"ffdb627c5903c2e2248b6abd51a336517ec65dbf","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        else:"},{"line_number":1070,"context_line":"            volume_stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":1071,"context_line":"            try:"},{"line_number":1072,"context_line":"                extra_capabilities \u003d json.loads("},{"line_number":1073,"context_line":"                    self.driver.configuration.extra_capabilities)"},{"line_number":1074,"context_line":"            except Exception as ex:"},{"line_number":1075,"context_line":"                LOG.warning(_(\"Failed to parse extra_capabilities: %s\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2Ft04%3D","line":1072,"updated":"2014-02-25 04:57:02.000000000","message":"I suggest we move this code to __init__ and save the extra_capabilities as a variable (i.e., self.extra_capabilities).  This way, if we fail to parse we can fail to load the driver immediately and give the admin a chance to fix the string, and we also cache the results so that we don\u0027t need to parse the same string every minute.","commit_id":"c47e5eab9f82fa8d03fd5797509cb0562b1f5554"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"6522de6f0d3d5e2b70a544ca172e1f36dfe17e1b","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        else:"},{"line_number":1070,"context_line":"            volume_stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":1071,"context_line":"            try:"},{"line_number":1072,"context_line":"                extra_capabilities \u003d json.loads("},{"line_number":1073,"context_line":"                    self.driver.configuration.extra_capabilities)"},{"line_number":1074,"context_line":"            except Exception as ex:"},{"line_number":1075,"context_line":"                LOG.warning(_(\"Failed to parse extra_capabilities: %s\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2FrZY%3D","line":1072,"in_reply_to":"AAAAU3%2F%2Ft04%3D","updated":"2014-02-25 10:05:54.000000000","message":"Good idea, will do","commit_id":"c47e5eab9f82fa8d03fd5797509cb0562b1f5554"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"bddf4b233d9ec567cec5d6443d58ce0257ea3d93","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"#volume_service_inithost_offload\u003dfalse"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"# User defined capabilities (string value)"},{"line_number":1786,"context_line":"#extra_capabilities\u003d{}"},{"line_number":1787,"context_line":""},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F9i%2FI%3D","line":1786,"updated":"2013-12-10 11:35:08.000000000","message":"Would it be more informative to provide a dummy value here?","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"1500e228236d01258653b53063f42ac746d86524","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"#volume_service_inithost_offload\u003dfalse"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"# User defined capabilities (string value)"},{"line_number":1786,"context_line":"#extra_capabilities\u003d{}"},{"line_number":1787,"context_line":""},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F9i9o%3D","line":1786,"in_reply_to":"AAAATn%2F9i%2FI%3D","updated":"2013-12-10 11:37:47.000000000","message":"Can we do that without the dummy values ending up being the default values?","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0fea6c5470fb62c4bc0e48d34d82d295b67edf80","unresolved":false,"context_lines":[{"line_number":1783,"context_line":"#volume_service_inithost_offload\u003dfalse"},{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"# User defined capabilities (string value)"},{"line_number":1786,"context_line":"#extra_capabilities\u003d{}"},{"line_number":1787,"context_line":""},{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAATn%2F9VYY%3D","line":1786,"in_reply_to":"AAAATn%2F9i9o%3D","updated":"2013-12-12 15:10:09.000000000","message":"I haven\u0027t done this since the consensus seems to be against it","commit_id":"abc981d46fdb18793a59ba857aca5c20551048ec"}]}