)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ffe76ce7c51b73786d74bb7761b05169206cc130","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sam Morrison \u003csorrison@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-05 09:36:25 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Return the availability-zone of a pool in get-pools API request"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is useful when doing capacity reporting"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_11b9c977","line":7,"updated":"2018-09-04 23:38:24.000000000","message":"Nit: Commit messages should be within 52 characters long.","commit_id":"a2bc2d3ba2d4d59a05c55dffeb10dc752a403ee3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"a pool when using the get-pools API request."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is useful when doing capacity reporting"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I981b00a83a52aab37fef8986133ec1f29d5e5fbd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_89b3954d","line":13,"updated":"2019-03-22 15:09:02.000000000","message":"Add bp reference here","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"}],"api-ref/source/v3/os-vol-pool-v3.inc":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"06dc79c7e6e173a0745a4a6ed561982f32b65055","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - driver_version: driver_version"},{"line_number":52,"context_line":"   - reserved_percentage: reserved_percentage"},{"line_number":53,"context_line":"   - storage_protocol: storage_protocol"},{"line_number":54,"context_line":"   - availability_zone: availability_zone"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Response Example"},{"line_number":57,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"9fdfeff1_71cc548a","line":54,"updated":"2019-03-04 17:59:48.000000000","message":"Need to add a new entry in parameters.yaml that includes min_version: 3.60","commit_id":"3d4fae76f90e184ef967954bb23faf1e601bacf5"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"16a94f14950007aa3806f2ba7fcf52425e1caade","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - driver_version: driver_version"},{"line_number":52,"context_line":"   - reserved_percentage: reserved_percentage"},{"line_number":53,"context_line":"   - storage_protocol: storage_protocol"},{"line_number":54,"context_line":"   - availability_zone: availability_zone"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Response Example"},{"line_number":57,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"5fc1f717_91c4fc92","line":54,"in_reply_to":"9fdfeff1_71cc548a","updated":"2019-03-12 11:38:45.000000000","message":"What @sean was saying is something like [1]\n\nWe should add soemthing like:\n\navailability_zone_pool:\n  description: |\n    The name of the availability zone.\n  in: body\n  required: false\n  type: string\n  min_version: 3.60\n\nand if we do it, the api-ref will introduce this response with \"New in version 3.60\"\n\n[1] https://github.com/openstack/cinder/blob/77c6f10/api-ref/source/v3/parameters.yaml#L568-L574","commit_id":"3d4fae76f90e184ef967954bb23faf1e601bacf5"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc0f3a246dbfcd34646c94d028ba0d9a9dc44c8d","unresolved":false,"context_lines":[{"line_number":572,"context_line":"  required: false"},{"line_number":573,"context_line":"  type: string"},{"line_number":574,"context_line":"  min_version: 3.51"},{"line_number":575,"context_line":"availability_zone_pool:"},{"line_number":576,"context_line":"  description: |"},{"line_number":577,"context_line":"    The name of the availability zone."},{"line_number":578,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"dfbec78f_8250620c","line":575,"updated":"2019-05-08 09:57:21.000000000","message":"nit: Maybe add that the default is None","commit_id":"6681a7d2e5fc100e69ba035b07ac6124e77da62a"}],"api-ref/source/v3/samples/pools-list-detailed-response.json":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc0f3a246dbfcd34646c94d028ba0d9a9dc44c8d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        {"},{"line_number":18,"context_line":"            \"name\": \"pool2\","},{"line_number":19,"context_line":"            \"availability_zone\": \"nova\","},{"line_number":20,"context_line":"            \"capabilities\": {"},{"line_number":21,"context_line":"                \"updated\": \"2014-10-28T00:00:00-00:00\","},{"line_number":22,"context_line":"                \"total_capacity_gb\": 512,"}],"source_content_type":"application/json","patch_set":10,"id":"dfbec78f_e2c59e8f","line":19,"updated":"2019-05-08 09:57:21.000000000","message":"nit: Maybe it would be good to have an example showing it could be null","commit_id":"6681a7d2e5fc100e69ba035b07ac6124e77da62a"}],"api-ref/source/v3/samples/versions/versions-response.json":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"version\": \"3.60\""},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":"    ]"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"5fc1f717_898cf57f","line":52,"range":{"start_line":52,"start_character":1,"end_line":52,"end_character":1},"updated":"2019-03-22 15:09:02.000000000","message":"unrelated change?","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc0f3a246dbfcd34646c94d028ba0d9a9dc44c8d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \"version\": \"3.60\""},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":"    ]"},{"line_number":52,"context_line":"}"}],"source_content_type":"application/json","patch_set":10,"id":"dfbec78f_9f075d1d","line":52,"updated":"2019-05-08 09:57:21.000000000","message":"What\u0027s the change here?","commit_id":"6681a7d2e5fc100e69ba035b07ac6124e77da62a"}],"cinder/api/views/scheduler_stats.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1a259e7bfe7c2888c11cd61a65db3221c9160244","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"        req_version \u003d request.api_version_request"},{"line_number":47,"context_line":"        if req_version.matches(mv.AVAILABILITY_ZONE_IN_POOL):"},{"line_number":48,"context_line":"            pool_dict[\u0027pool\u0027][\u0027availability_zone\u0027] \u003d \\"},{"line_number":49,"context_line":"                pool.get(\u0027availability_zone\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        return pool_dict"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_4e37edfe","line":48,"range":{"start_line":48,"start_character":53,"end_line":48,"end_character":54},"updated":"2018-11-02 15:00:01.000000000","message":"If you need to do another update, please don\u0027t use \\ to span multiple lines. We have made an effort (outside of unit test code at least) to avoid it.","commit_id":"b95ba3a49c75a94a29c4ab815aa8f9deff6c81b9"}],"cinder/scheduler/host_manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                                  volume_type,"},{"line_number":751,"context_line":"                                                  all_pools))"},{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # encapsulate pools in format:{name: XXX, capabilities: XXX}"},{"line_number":754,"context_line":"        return [dict(name\u003dkey, capabilities\u003dvalue.capabilities,"},{"line_number":755,"context_line":"                     availability_zone\u003dvalue.service[\u0027availability_zone\u0027])"},{"line_number":756,"context_line":"                for key, value in all_pools.items()]"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_69bf49fb","line":753,"range":{"start_line":753,"start_character":38,"end_line":753,"end_character":68},"updated":"2019-03-22 15:09:02.000000000","message":"this needs to be modified","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # encapsulate pools in format:{name: XXX, capabilities: XXX}"},{"line_number":754,"context_line":"        return [dict(name\u003dkey, capabilities\u003dvalue.capabilities,"},{"line_number":755,"context_line":"                     availability_zone\u003dvalue.service[\u0027availability_zone\u0027])"},{"line_number":756,"context_line":"                for key, value in all_pools.items()]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def get_usage_and_notify(self, capa_new, updated_pools, host, timestamp):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_695429cb","line":755,"range":{"start_line":755,"start_character":21,"end_line":755,"end_character":73},"updated":"2019-03-22 15:09:02.000000000","message":"how will this behave when the MV is less than expected for availability-zone (\u003c3.60)","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"c106f42b63fad0b001e860f5c1715a6a172efbe3","unresolved":false,"context_lines":[{"line_number":752,"context_line":""},{"line_number":753,"context_line":"        # encapsulate pools in format:{name: XXX, capabilities: XXX}"},{"line_number":754,"context_line":"        return [dict(name\u003dkey, capabilities\u003dvalue.capabilities,"},{"line_number":755,"context_line":"                     availability_zone\u003dvalue.service[\u0027availability_zone\u0027])"},{"line_number":756,"context_line":"                for key, value in all_pools.items()]"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"    def get_usage_and_notify(self, capa_new, updated_pools, host, timestamp):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_394ad8ab","line":755,"range":{"start_line":755,"start_character":21,"end_line":755,"end_character":73},"in_reply_to":"5fc1f717_695429cb","updated":"2019-03-24 22:04:56.000000000","message":"That is handled at the API level","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"}],"cinder/tests/unit/api/test_versions.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"16a94f14950007aa3806f2ba7fcf52425e1caade","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        self.assertEqual(api_version_request._MIN_API_VERSION,"},{"line_number":378,"context_line":"                         version_list[0].get(\u0027min_version\u0027))"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    @ddt.data([\u00273.5\u0027, http_client.OK], [\u00273.56\u0027, http_client.NOT_FOUND])"},{"line_number":381,"context_line":"    @ddt.unpack"},{"line_number":382,"context_line":"    def test_req_version_matches(self, version, HTTP_ret):"},{"line_number":383,"context_line":"        version_request \u003d api_version_request.APIVersionRequest(version)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5fc1f717_d12a842a","line":380,"updated":"2019-03-12 11:38:45.000000000","message":"why change this to 3.56?","commit_id":"3d4fae76f90e184ef967954bb23faf1e601bacf5"}],"cinder/tests/unit/scheduler/test_host_manager.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    @mock.patch(\u0027cinder.db.service_get_all\u0027)"},{"line_number":849,"context_line":"    @mock.patch(\u0027cinder.objects.service.Service.is_up\u0027,"},{"line_number":850,"context_line":"                new_callable\u003dmock.PropertyMock)"},{"line_number":851,"context_line":"    def test_get_pools(self, _mock_service_is_up,"},{"line_number":852,"context_line":"                       _mock_service_get_all):"},{"line_number":853,"context_line":"        context \u003d \u0027fake_context\u0027"},{"line_number":854,"context_line":"        timestamp \u003d datetime.utcnow()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_49a4cdb9","line":851,"updated":"2019-03-22 15:09:02.000000000","message":"Not sure but don\u0027t we require MV check here? or do these tests need modification anyway?","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"c106f42b63fad0b001e860f5c1715a6a172efbe3","unresolved":false,"context_lines":[{"line_number":848,"context_line":"    @mock.patch(\u0027cinder.db.service_get_all\u0027)"},{"line_number":849,"context_line":"    @mock.patch(\u0027cinder.objects.service.Service.is_up\u0027,"},{"line_number":850,"context_line":"                new_callable\u003dmock.PropertyMock)"},{"line_number":851,"context_line":"    def test_get_pools(self, _mock_service_is_up,"},{"line_number":852,"context_line":"                       _mock_service_get_all):"},{"line_number":853,"context_line":"        context \u003d \u0027fake_context\u0027"},{"line_number":854,"context_line":"        timestamp \u003d datetime.utcnow()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc1f717_3971780d","line":851,"in_reply_to":"5fc1f717_49a4cdb9","updated":"2019-03-24 22:04:56.000000000","message":"We test the MV in the other tests, not sure it\u0027s required here too?","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"}],"releasenotes/notes/add-availability-zone-to-get-pools-b9369420171963f3.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"1a259e7bfe7c2888c11cd61a65db3221c9160244","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The get-pools method now also returns the availability-zone of the pool."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_912444b3","line":4,"range":{"start_line":4,"start_character":75,"end_line":4,"end_character":76},"updated":"2018-11-02 15:00:01.000000000","message":"Need to specify which starting microversion this is available.","commit_id":"b95ba3a49c75a94a29c4ab815aa8f9deff6c81b9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e617df596f56cfc1d48ba253a7a60f56057fb87b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The get-pools method now also returns the availability-zone of the pool."},{"line_number":5,"context_line":"    This is available from API version 3.60."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5fc1f717_699e6964","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":24},"updated":"2019-03-22 15:09:02.000000000","message":"API","commit_id":"00bc598cd0489c3af327eec8c3fcb3e229a1da5a"}]}