)]}'
{"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":25531,"name":"Lei Lei","email":"leilei4@lenovo.com","username":"leilei"},"change_message_id":"157acbd3b2b19d716881f15ed1a65e792c7b4da1","unresolved":false,"context_lines":[{"line_number":2796,"context_line":""},{"line_number":2797,"context_line":"    def tests_backup_get_all_by_filter_metadata(self):"},{"line_number":2798,"context_line":"        backups \u003d self._get_values()"},{"line_number":2799,"context_line":"        for i in range(0, 3):"},{"line_number":2800,"context_line":"            backup \u003d backups[i]"},{"line_number":2801,"context_line":"            backup[\u0027metadata\u0027] \u003d {\u0027fake_key\u0027: \u0027fake\u0027 + str(i)}"},{"line_number":2802,"context_line":"        created \u003d [db.backup_create(self.ctxt, values)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3c69bc25","line":2799,"range":{"start_line":2799,"start_character":17,"end_line":2799,"end_character":28},"updated":"2018-09-11 12:48:23.000000000","message":"range(3) should be simpler than range(0, 3). Suggest change it.","commit_id":"7f84f575c34fcf50ac99653533525711a269f787"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"663398bf53ddcdc853faca13e0921d240c20c464","unresolved":false,"context_lines":[{"line_number":2796,"context_line":""},{"line_number":2797,"context_line":"    def tests_backup_get_all_by_filter_metadata(self):"},{"line_number":2798,"context_line":"        backups \u003d self._get_values()"},{"line_number":2799,"context_line":"        for i in range(0, 3):"},{"line_number":2800,"context_line":"            backup \u003d backups[i]"},{"line_number":2801,"context_line":"            backup[\u0027metadata\u0027] \u003d {\u0027fake_key\u0027: \u0027fake\u0027 + str(i)}"},{"line_number":2802,"context_line":"        created \u003d [db.backup_create(self.ctxt, values)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_5721f1fb","line":2799,"range":{"start_line":2799,"start_character":17,"end_line":2799,"end_character":28},"in_reply_to":"3f79a3b5_3c69bc25","updated":"2018-09-11 14:08:48.000000000","message":"Done","commit_id":"7f84f575c34fcf50ac99653533525711a269f787"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"af71a784487ae99d97939bab5a3298b398c146a2","unresolved":false,"context_lines":[{"line_number":2794,"context_line":"        filtered_backups \u003d db.backup_get_all(self.ctxt, filters\u003dfilters)"},{"line_number":2795,"context_line":"        self._assertEqualListsOfObjects([], filtered_backups)"},{"line_number":2796,"context_line":""},{"line_number":2797,"context_line":"    def tests_backup_get_all_by_filter_metadata(self):"},{"line_number":2798,"context_line":"        backups \u003d self._get_values()"},{"line_number":2799,"context_line":"        for i in range(3):"},{"line_number":2800,"context_line":"            backup \u003d backups[i]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_1548192c","line":2797,"updated":"2018-09-13 17:16:49.000000000","message":"This test passes even without the patch applied. Please, add a test which will prove that fix is working","commit_id":"18570a716c3701f8d5d13dd7ea5d297cc57a9ec5"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"31d038c1b64b8e2eeb9a19c07fac8400b758aabc","unresolved":false,"context_lines":[{"line_number":2794,"context_line":"        filtered_backups \u003d db.backup_get_all(self.ctxt, filters\u003dfilters)"},{"line_number":2795,"context_line":"        self._assertEqualListsOfObjects([], filtered_backups)"},{"line_number":2796,"context_line":""},{"line_number":2797,"context_line":"    def tests_backup_get_all_by_filter_metadata(self):"},{"line_number":2798,"context_line":"        backups \u003d self._get_values()"},{"line_number":2799,"context_line":"        for i in range(3):"},{"line_number":2800,"context_line":"            backup \u003d backups[i]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_8005c216","line":2797,"in_reply_to":"3f79a3b5_1548192c","updated":"2018-09-14 01:28:46.000000000","message":"Really? But when I run the unit test case without the patch of db api fix. It fails. Can you try to run it again? Thanks for your reviewing!","commit_id":"18570a716c3701f8d5d13dd7ea5d297cc57a9ec5"}]}