)]}'
{"cinder/volume/drivers/vmware/fcd.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"82527dfc917e82869f27fc38a87896383da29450","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            fcd_snap_loc \u003d self.volumeops.create_fcd_snapshot("},{"line_number":281,"context_line":"                fcd_loc, description\u003ddescription)"},{"line_number":282,"context_line":"            return {\u0027provider_location\u0027: fcd_snap_loc.provider_location()}"},{"line_number":283,"context_line":"        else:"},{"line_number":284,"context_line":"            ds_ref \u003d self._select_ds_fcd(snapshot.volume)"},{"line_number":285,"context_line":"            cloned_fcd_loc \u003d self._clone_fcd("},{"line_number":286,"context_line":"                snapshot.volume.provider_location, snapshot.name, ds_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f0ef197d","line":283,"updated":"2018-11-10 19:03:53.000000000","message":"Coding preference, but you could get rid of the else block and just have the rest run if the initial if case is false since that block has a return.","commit_id":"812f23cadf806e7b38eca516239f45a267df8c88"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e533dca35bc5229b28d671d7a36633a340ad9a52","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            fcd_snap_loc \u003d self.volumeops.create_fcd_snapshot("},{"line_number":281,"context_line":"                fcd_loc, description\u003ddescription)"},{"line_number":282,"context_line":"            return {\u0027provider_location\u0027: fcd_snap_loc.provider_location()}"},{"line_number":283,"context_line":"        else:"},{"line_number":284,"context_line":"            ds_ref \u003d self._select_ds_fcd(snapshot.volume)"},{"line_number":285,"context_line":"            cloned_fcd_loc \u003d self._clone_fcd("},{"line_number":286,"context_line":"                snapshot.volume.provider_location, snapshot.name, ds_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f00b99c4","line":283,"in_reply_to":"3f79a3b5_f0ef197d","updated":"2018-12-11 01:53:24.000000000","message":"Done","commit_id":"812f23cadf806e7b38eca516239f45a267df8c88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d7b34750fd6452dbe42ed50dee78818ef6be8122","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            snapshot.provider_location)"},{"line_number":326,"context_line":"        if fcd_snap_loc:"},{"line_number":327,"context_line":"            fcd_loc \u003d self.volumeops.create_fcd_from_snapshot("},{"line_number":328,"context_line":"                fcd_snap_loc, volume.name)"},{"line_number":329,"context_line":"            self._extend_if_needed(fcd_loc, snapshot.volume_size, volume.size)"},{"line_number":330,"context_line":"            return {\u0027provider_location\u0027: fcd_loc.provider_location()}"},{"line_number":331,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_23fde26d","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":41},"updated":"2018-09-13 16:53:26.000000000","message":"not sure but is it a good practice to use the name param for vol creation since it is an optional parameter in cinder.","commit_id":"812f23cadf806e7b38eca516239f45a267df8c88"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"47a951f6d011b5549d3c16d85757ea6289b5f19d","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            snapshot.provider_location)"},{"line_number":326,"context_line":"        if fcd_snap_loc:"},{"line_number":327,"context_line":"            fcd_loc \u003d self.volumeops.create_fcd_from_snapshot("},{"line_number":328,"context_line":"                fcd_snap_loc, volume.name)"},{"line_number":329,"context_line":"            self._extend_if_needed(fcd_loc, snapshot.volume_size, volume.size)"},{"line_number":330,"context_line":"            return {\u0027provider_location\u0027: fcd_loc.provider_location()}"},{"line_number":331,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_2b8db834","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":41},"in_reply_to":"3f79a3b5_23fde26d","updated":"2018-09-13 18:58:28.000000000","message":"Are you talking about display name? volume.name is different and it is not None.\n\nSee https://github.com/openstack/cinder/blob/b8167a5c3e5952cc52ff8844804b7a5ab36459c8/cinder/objects/volume.py#L156\n\nAlso, we cannot change it now because we should be consistent with volumes created with older version of this driver. See create_volume() in this file.","commit_id":"812f23cadf806e7b38eca516239f45a267df8c88"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8ee34731e8ef8016cbf2fcff7b1459661da708b9","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            snapshot.provider_location)"},{"line_number":326,"context_line":"        if fcd_snap_loc:"},{"line_number":327,"context_line":"            fcd_loc \u003d self.volumeops.create_fcd_from_snapshot("},{"line_number":328,"context_line":"                fcd_snap_loc, volume.name)"},{"line_number":329,"context_line":"            self._extend_if_needed(fcd_loc, snapshot.volume_size, volume.size)"},{"line_number":330,"context_line":"            return {\u0027provider_location\u0027: fcd_loc.provider_location()}"},{"line_number":331,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c9476c4c","line":328,"range":{"start_line":328,"start_character":30,"end_line":328,"end_character":41},"in_reply_to":"3f79a3b5_2b8db834","updated":"2018-09-13 20:47:36.000000000","message":"ok, i checked other func as well. sounds reasonable","commit_id":"812f23cadf806e7b38eca516239f45a267df8c88"}]}