)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"b0e71a304bd085355788d42c0a9fa088db8c7e64","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix bug of retyping volume for rbd driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If the volume is already in the pool, renaming causes exception."},{"line_number":10,"context_line":"The Scene is that the same pool is seti into two backends with"},{"line_number":11,"context_line":"different volume_backend_name. Then create two volume types with"},{"line_number":12,"context_line":"different volume_backend_name which was defined in cinder.conf."},{"line_number":13,"context_line":"Create a volume by one volume type, then try to retype it to another"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_fd53b76a","line":10,"range":{"start_line":10,"start_character":39,"end_line":10,"end_character":40},"updated":"2018-09-18 12:58:45.000000000","message":"typo","commit_id":"8e5d275c881c4f48d2ff8c9bb78830ec12b8e990"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"5fc9ea5cf52460678c5137f1ac491951b17f6225","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"                self.RBDProxy().rename(client.ioctx,"},{"line_number":1624,"context_line":"                                       utils.convert_str(existing_name),"},{"line_number":1625,"context_line":"                                       utils.convert_str(wanted_name))"},{"line_number":1626,"context_line":"            except (self.rbd.ImageNotFound, self.rbd.ImageExists):"},{"line_number":1627,"context_line":"                LOG.error(\u0027Unable to rename the logical volume \u0027"},{"line_number":1628,"context_line":"                          \u0027for volume %s.\u0027, volume.id)"},{"line_number":1629,"context_line":"                # If the rename fails, _name_id should be set to the new"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ba63f0b0","line":1626,"updated":"2018-09-19 07:25:52.000000000","message":"In your case, it seems existing_name is same as wanted_name. Right?\nAnd I agree that ImageExists can be added here to avoid any name confliction. But this is not limited to your scenario.","commit_id":"9179279272a7d8f1a5ac706f35904c4e19bf0beb"},{"author":{"_account_id":28706,"name":"Boxiang Zhu","email":"bxzhu_5355@163.com","username":"ZhuBoxiang"},"change_message_id":"13fab3eb15e99c41327e0530148647e17754b7b5","unresolved":false,"context_lines":[{"line_number":1623,"context_line":"                self.RBDProxy().rename(client.ioctx,"},{"line_number":1624,"context_line":"                                       utils.convert_str(existing_name),"},{"line_number":1625,"context_line":"                                       utils.convert_str(wanted_name))"},{"line_number":1626,"context_line":"            except (self.rbd.ImageNotFound, self.rbd.ImageExists):"},{"line_number":1627,"context_line":"                LOG.error(\u0027Unable to rename the logical volume \u0027"},{"line_number":1628,"context_line":"                          \u0027for volume %s.\u0027, volume.id)"},{"line_number":1629,"context_line":"                # If the rename fails, _name_id should be set to the new"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_3050315e","line":1626,"in_reply_to":"3f79a3b5_ba63f0b0","updated":"2018-09-21 03:00:20.000000000","message":"Done","commit_id":"9179279272a7d8f1a5ac706f35904c4e19bf0beb"}]}
