)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c50afaf6763cd444c45a84a93bf884faad692b70","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liang Fang \u003cliang.a.fang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-14 16:27:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix uploading cinder volumes to images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When uploading a volume to glance as an image, the glance server don\u0027t"},{"line_number":10,"context_line":"know the image size, so the backend storage server(such as ceph) need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_7b75ac31","line":7,"updated":"2018-09-14 16:41:06.000000000","message":"This should state what is actually being done.","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"5224de75a3d48f6b31d3d5a81b13ebef6eaf3e09","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liang Fang \u003cliang.a.fang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-14 16:27:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix uploading cinder volumes to images"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When uploading a volume to glance as an image, the glance server don\u0027t"},{"line_number":10,"context_line":"know the image size, so the backend storage server(such as ceph) need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_0ab3ef4f","line":7,"in_reply_to":"3f79a3b5_7b75ac31","updated":"2018-09-16 16:03:34.000000000","message":"Done","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c50afaf6763cd444c45a84a93bf884faad692b70","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ceph can allocate an image with exact size, and don\u0027t need to resize the"},{"line_number":16,"context_line":"image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2003774"},{"line_number":19,"context_line":"Task: 26466"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ifd461c058fbd34934c407a1fc39403bd205b8009"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_fb81bcfc","line":18,"updated":"2018-09-14 16:41:06.000000000","message":"Cinder does not use storyboard.","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"775132e6cb48bd5dd65f244ab03873dcaa2fadb4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liang Fang \u003cliang.a.fang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-17 14:29:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Specify image size to avoid glance backend resize when uploading volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When uploading a volume to glance as an image, the glance server don\u0027t"},{"line_number":10,"context_line":"know the image size, so the backend storage server(such as ceph) need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_702365bf","line":7,"updated":"2018-09-17 14:36:25.000000000","message":"nit: Commit message should be reformatted to conform to guidelines.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"68f7b4444166cae7acc3a371b48a2b677380eb4f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Liang Fang \u003cliang.a.fang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-09-17 14:29:11 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Specify image size to avoid glance backend resize when uploading volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When uploading a volume to glance as an image, the glance server don\u0027t"},{"line_number":10,"context_line":"know the image size, so the backend storage server(such as ceph) need to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_e21c7d67","line":7,"in_reply_to":"3f79a3b5_702365bf","updated":"2018-09-18 05:31:03.000000000","message":"shortened the title","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"775132e6cb48bd5dd65f244ab03873dcaa2fadb4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ceph can allocate an image with exact size, and don\u0027t need to resize the"},{"line_number":16,"context_line":"image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1792710"},{"line_number":19,"context_line":"Story: 2003774"},{"line_number":20,"context_line":"Task: 26466"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_103551f7","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"updated":"2018-09-17 14:36:25.000000000","message":"Why is this only partial?","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"68f7b4444166cae7acc3a371b48a2b677380eb4f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ceph can allocate an image with exact size, and don\u0027t need to resize the"},{"line_number":16,"context_line":"image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1792710"},{"line_number":19,"context_line":"Story: 2003774"},{"line_number":20,"context_line":"Task: 26466"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_0222d9a3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":7},"in_reply_to":"3f79a3b5_103551f7","updated":"2018-09-18 05:31:03.000000000","message":"Changed to closes","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"775132e6cb48bd5dd65f244ab03873dcaa2fadb4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1792710"},{"line_number":19,"context_line":"Story: 2003774"},{"line_number":20,"context_line":"Task: 26466"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ifd461c058fbd34934c407a1fc39403bd205b8009"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_5051892f","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":11},"updated":"2018-09-17 14:36:25.000000000","message":"These are not applicable to this patch.","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"68f7b4444166cae7acc3a371b48a2b677380eb4f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1792710"},{"line_number":19,"context_line":"Story: 2003774"},{"line_number":20,"context_line":"Task: 26466"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ifd461c058fbd34934c407a1fc39403bd205b8009"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_c23ce1c0","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":11},"in_reply_to":"3f79a3b5_5051892f","updated":"2018-09-18 05:31:03.000000000","message":"Removed","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a4382febb83d70f1a334b03c41764e274308bc8a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"terribly impact the performance. The patch aims to tell the image size"},{"line_number":14,"context_line":"to glance server at the initial phase of uploading, so that glance"},{"line_number":15,"context_line":"backend such as ceph can allocate an image with exact size, and don\u0027t"},{"line_number":16,"context_line":"need to resize the image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1792710"},{"line_number":19,"context_line":"Change-Id: Ifd461c058fbd34934c407a1fc39403bd205b8009"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_e21cdac3","line":16,"updated":"2018-10-08 18:29:39.000000000","message":"AFAICT, the ceph glance driver uses an 8MB chunk size by default and a minimum of 1MB, so is this really an issue for Ceph?\n\nThe filesystem driver uses 64KB chunks.","commit_id":"4212e1e989768013a88abcc4909cc68afcb5ddb9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8a0309d0569222c240a9213f090259e3a99be780","unresolved":false,"context_lines":[{"line_number":14,"context_line":"to glance server at the initial phase of uploading, so that glance"},{"line_number":15,"context_line":"backend such as ceph can allocate an image with exact size, and don\u0027t"},{"line_number":16,"context_line":"need to resize the image again and again"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1792710"},{"line_number":19,"context_line":"Change-Id: Ifd461c058fbd34934c407a1fc39403bd205b8009"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_c579ddc6","line":17,"updated":"2018-10-17 15:46:44.000000000","message":"Please add Depends-On: for the change id of the Glance patch.  And please differentiate between the details about Ceph vs 64KB chunks in the commit message, so it\u0027s clear what information applies where.","commit_id":"4212e1e989768013a88abcc4909cc68afcb5ddb9"}],"cinder/image/glance.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"636970927975e9617a9bfca01614f82aff888613","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import sys"},{"line_number":27,"context_line":"import textwrap"},{"line_number":28,"context_line":"import time"},{"line_number":29,"context_line":"import io"},{"line_number":30,"context_line":"import os"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import glanceclient.exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_878ab161","line":29,"updated":"2018-09-14 13:18:55.000000000","message":"imports should be in alphabetical order","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"5224de75a3d48f6b31d3d5a81b13ebef6eaf3e09","unresolved":false,"context_lines":[{"line_number":26,"context_line":"import sys"},{"line_number":27,"context_line":"import textwrap"},{"line_number":28,"context_line":"import time"},{"line_number":29,"context_line":"import io"},{"line_number":30,"context_line":"import os"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"import glanceclient.exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_071212b5","line":29,"in_reply_to":"3f79a3b5_878ab161","updated":"2018-09-16 16:03:34.000000000","message":"Done","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"636970927975e9617a9bfca01614f82aff888613","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                else:"},{"line_number":409,"context_line":"                    size \u003d len(data)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"                self._client.call(context, \u0027upload\u0027, image_id, data, size)"},{"line_number":412,"context_line":"            if image_meta:"},{"line_number":413,"context_line":"                if purge_props:"},{"line_number":414,"context_line":"                    # Properties to remove are those not specified in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c7d50949","line":411,"updated":"2018-09-14 13:18:55.000000000","message":"the func definition for upload must be modified to accept an extra parameter","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"5224de75a3d48f6b31d3d5a81b13ebef6eaf3e09","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                else:"},{"line_number":409,"context_line":"                    size \u003d len(data)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"                self._client.call(context, \u0027upload\u0027, image_id, data, size)"},{"line_number":412,"context_line":"            if image_meta:"},{"line_number":413,"context_line":"                if purge_props:"},{"line_number":414,"context_line":"                    # Properties to remove are those not specified in"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c74ad081","line":411,"in_reply_to":"3f79a3b5_c7d50949","updated":"2018-09-16 16:03:34.000000000","message":"Done","commit_id":"5e9098d96be340ad9ac651f66b3b7617c673f58a"}],"cinder/tests/unit/image/test_glance.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"775132e6cb48bd5dd65f244ab03873dcaa2fadb4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cinder import service_auth"},{"line_number":21,"context_line":"from cinder import test"},{"line_number":22,"context_line":"from cinder.tests.unit.glance import stubs as glance_stubs"},{"line_number":23,"context_line":"import datetime"},{"line_number":24,"context_line":"import ddt"},{"line_number":25,"context_line":"import glanceclient.exc"},{"line_number":26,"context_line":"import itertools"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b0401d61","line":23,"updated":"2018-09-17 14:36:25.000000000","message":"Why were these moved? Imports should be grouped by standard lib, third party lib, then local imports.","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"},{"author":{"_account_id":28948,"name":"Liang Fang","email":"liang.a.fang@intel.com","username":"liang"},"change_message_id":"68f7b4444166cae7acc3a371b48a2b677380eb4f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from cinder import service_auth"},{"line_number":21,"context_line":"from cinder import test"},{"line_number":22,"context_line":"from cinder.tests.unit.glance import stubs as glance_stubs"},{"line_number":23,"context_line":"import datetime"},{"line_number":24,"context_line":"import ddt"},{"line_number":25,"context_line":"import glanceclient.exc"},{"line_number":26,"context_line":"import itertools"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e26a3db3","line":23,"in_reply_to":"3f79a3b5_b0401d61","updated":"2018-09-18 05:31:03.000000000","message":"thanks for this catch, I misunderstanded the pep8 scan result, now recovered to 3 groups and my import added to the first group.","commit_id":"1cb1413274fc479c25afd00e4fc9fc85bfc043d8"}]}