)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SF ensure the correct volume is deleted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Author: Jay Rubenstein jay.rubenstein@netapp.com"},{"line_number":10,"context_line":"Date: 2018-07-18 11:42 -0600"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When two management systems are available openstack/cinder and"},{"line_number":13,"context_line":"SolidFire-API/GUI  a volume can be deleted though either interface. Thus"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_55a41ba3","line":10,"range":{"start_line":9,"start_character":1,"end_line":10,"end_character":5},"updated":"2018-09-17 13:59:51.000000000","message":"Remove this.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"if a volume is deleted through the SolidFire-interface and then again"},{"line_number":15,"context_line":"through the openstack/cinder interface it was possible to delete another"},{"line_number":16,"context_line":"volume."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The original code made an incorrect assumption on all the possible values returned"},{"line_number":19,"context_line":"from a query to find the target volume. This could lead to deleting a"},{"line_number":20,"context_line":"volume that was not the target of the original delete command from openstack/cinder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_75ca774f","line":17,"updated":"2018-09-17 13:59:51.000000000","message":"Shorten lines. Read through https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure for proper commit message guidelines.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"returned object/volumes-id matchs the requested volume-id with a"},{"line_number":24,"context_line":"comparison of svol[\u0027volumeID\u0027] to int(sf_vid)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"pep8 tabs to space changes"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1782373"},{"line_number":29,"context_line":"Change-Id: I92a8e76c64c4e23dd185875e009132938ace5091"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_15e1c3d0","line":26,"updated":"2018-09-17 13:59:51.000000000","message":"There aren\u0027t any tabs in the current code in master.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"pep8 tabs to space changes"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Closes-Bug: #1782373"},{"line_number":29,"context_line":"Change-Id: I92a8e76c64c4e23dd185875e009132938ace5091"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SF ensure volumes uuids match when volume found without a provider id"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_55d2dbfe","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":10},"updated":"2018-09-17 13:59:51.000000000","message":"Multiple change id and closes-bug lines. Get rid of all of those except the final ones at the end.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"Closes-Bug: #1782373"},{"line_number":29,"context_line":"Change-Id: I92a8e76c64c4e23dd185875e009132938ace5091"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SF ensure volumes uuids match when volume found without a provider id"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I19fd84e651a4c03376542b0d863f9f499fd01120"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b5fa4f74","line":31,"updated":"2018-09-17 13:59:51.000000000","message":"This sounds like a different patch and should be separate.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Closes-Bug: #1782373"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"SF add 4 unit tests for bug 1782373"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"here are also 4 new unit test:"},{"line_number":44,"context_line":"_get_sfvol_by_cinder_vref"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b52faff3","line":41,"updated":"2018-09-17 13:59:51.000000000","message":"Don\u0027t need to call out unit tests separately.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"Closes-bug: #1782373"},{"line_number":50,"context_line":"Change-Id: Ib4904ffa411657573fa117fe4589e23a107385dd"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"SF clean spaces and over 80 character lines for newly added tests"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Change-Id: Ic70c035252f140f086d501285568fdae2a3a9598"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_55409ba2","line":52,"updated":"2018-09-17 13:59:51.000000000","message":"Master does not have these. As you say, they are newly added tests.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"Change-Id: Ic70c035252f140f086d501285568fdae2a3a9598"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"SF bug 1782373 implement reviewers suggestion to use get on array line 598"},{"line_number":57,"context_line":"598             if sfv[\u0027attributes\u0027].get(\u0027uuid\u0027,None) \u003d\u003d vref.id:"},{"line_number":58,"context_line":"Change-Id: I5dac23b55bdd480a5c80a54358edf5ad5d8acacf"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_55197bce","line":56,"updated":"2018-09-17 13:59:51.000000000","message":"Remove all this.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"598             if sfv[\u0027attributes\u0027].get(\u0027uuid\u0027,None) \u003d\u003d vref.id:"},{"line_number":58,"context_line":"Change-Id: I5dac23b55bdd480a5c80a54358edf5ad5d8acacf"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"SF bug/1792373  correct all the exta indentations entered in fix"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Change-Id: I0d2052c89280d91492d32f0985c166cd0387d104"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d5826bc7","line":60,"updated":"2018-09-17 13:59:51.000000000","message":"Remove all this.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"}],"cinder/tests/unit/volume/drivers/solidfire/test_solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":585,"context_line":"            self.mock_vref[\u0027provider_id\u0027] \u003d None"},{"line_number":586,"context_line":"            sfvol \u003d sfv._get_sfvol_by_cinder_vref(self.mock_vref)"},{"line_number":587,"context_line":"            self.assertIsNotNone(sfvol)"},{"line_number":588,"context_line":"            self.assertEqual(sfvol[\u0027attributes\u0027][\u0027uuid\u0027],"},{"line_number":589,"context_line":"                             vol_result[\u0027attributes\u0027][\u0027uuid\u0027])"},{"line_number":590,"context_line":"            self.assertEqual(sfvol[\u0027volumeID\u0027], vol_result[\u0027volumeID\u0027])"},{"line_number":591,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_95515365","line":588,"range":{"start_line":588,"start_character":18,"end_line":588,"end_character":28},"updated":"2018-09-17 13:59:51.000000000","message":"Order of all assertEqual checks should be (EXPECTED, ACTUAL)","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"204e2748687282380549b785534a8a0a7e28eef5","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                        {\u0027startVolumeID\u0027: sf_vid,"},{"line_number":580,"context_line":"                         \u0027limit\u0027: 1},"},{"line_number":581,"context_line":"                        version\u003d\u00278.0\u0027)[\u0027result\u0027][\u0027volumes\u0027][0]"},{"line_number":582,"context_line":"                    # Bug 1782373 validate list returned what we asked for it"},{"line_number":583,"context_line":"                    # there was no match"},{"line_number":584,"context_line":"                    if sfvol[\u0027volumeID\u0027] !\u003d int(sf_vid):"},{"line_number":585,"context_line":"                        sfvol \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_75027740","line":582,"updated":"2018-09-17 13:59:51.000000000","message":"I don\u0027t see a need to reference a bug in a code comment for basic validation.","commit_id":"495b0b1c27040a6f5365c9f888d54c5bbb1bbd5a"}]}