)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ce913d9f555cd7e34d228d3a825f3959af6176d2","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"            self.rest.rename_volume("},{"line_number":2135,"context_line":"                extra_specs[utils.ARRAY], device_id, volume_id)"},{"line_number":2136,"context_line":"            # First check/create the unmanaged sg"},{"line_number":2137,"context_line":"            # Don\u0027t fail if we fail to create the SG"},{"line_number":2138,"context_line":"            try:"},{"line_number":2139,"context_line":"                self.provision.create_storage_group("},{"line_number":2140,"context_line":"                    extra_specs[utils.ARRAY], utils.UNMANAGED_SG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_50849fb2","line":2137,"updated":"2018-09-24 15:05:13.000000000","message":"Can you add a unit test for this scenario","commit_id":"9f5b8e50cff6c5add3d33974df69d38e3e2b4305"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"6e58dbd80ace2b9e0ebbe23a687589833ddedc7b","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"            self.rest.rename_volume("},{"line_number":2135,"context_line":"                extra_specs[utils.ARRAY], device_id, volume_id)"},{"line_number":2136,"context_line":"            # First check/create the unmanaged sg"},{"line_number":2137,"context_line":"            # Don\u0027t fail if we fail to create the SG"},{"line_number":2138,"context_line":"            try:"},{"line_number":2139,"context_line":"                self.provision.create_storage_group("},{"line_number":2140,"context_line":"                    extra_specs[utils.ARRAY], utils.UNMANAGED_SG,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a357ef01","line":2137,"in_reply_to":"3f79a3b5_50849fb2","updated":"2018-09-24 15:14:36.000000000","message":"Will add the test case","commit_id":"9f5b8e50cff6c5add3d33974df69d38e3e2b4305"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ce913d9f555cd7e34d228d3a825f3959af6176d2","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"            # First check/create the unmanaged sg"},{"line_number":2137,"context_line":"            # Don\u0027t fail if we fail to create the SG"},{"line_number":2138,"context_line":"            try:"},{"line_number":2139,"context_line":"                self.provision.create_storage_group("},{"line_number":2140,"context_line":"                    extra_specs[utils.ARRAY], utils.UNMANAGED_SG,"},{"line_number":2141,"context_line":"                    extra_specs[utils.SRP], None,"},{"line_number":2142,"context_line":"                    None, extra_specs\u003dextra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_70d3dbd4","line":2139,"range":{"start_line":2139,"start_character":31,"end_line":2139,"end_character":51},"updated":"2018-09-24 15:05:13.000000000","message":"Should we be using get_or_create_group here instead?  Can we assume the failure is because it already exists?","commit_id":"9f5b8e50cff6c5add3d33974df69d38e3e2b4305"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"6e58dbd80ace2b9e0ebbe23a687589833ddedc7b","unresolved":false,"context_lines":[{"line_number":2136,"context_line":"            # First check/create the unmanaged sg"},{"line_number":2137,"context_line":"            # Don\u0027t fail if we fail to create the SG"},{"line_number":2138,"context_line":"            try:"},{"line_number":2139,"context_line":"                self.provision.create_storage_group("},{"line_number":2140,"context_line":"                    extra_specs[utils.ARRAY], utils.UNMANAGED_SG,"},{"line_number":2141,"context_line":"                    extra_specs[utils.SRP], None,"},{"line_number":2142,"context_line":"                    None, extra_specs\u003dextra_specs)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_836bd3b7","line":2139,"range":{"start_line":2139,"start_character":31,"end_line":2139,"end_character":51},"in_reply_to":"3f79a3b5_70d3dbd4","updated":"2018-09-24 15:14:36.000000000","message":"the create_storage_group is VMAXProvision already does this check and will not throw an error if the SG already exists.","commit_id":"9f5b8e50cff6c5add3d33974df69d38e3e2b4305"}],"releasenotes/notes/orphaned_unmanaged_volume-db63ec0509b70b8f.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"52897686618ab30b8994dd8e9a0d8ef954590b01","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fix puts the unmanaged \"orphan\" volume in a storage group called"},{"line_number":5,"context_line":"    OS-Unmanaged."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_50960df0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":12},"updated":"2018-11-10 19:09:31.000000000","message":"\"This fix\" doesn\u0027t make any sense when reading through the release notes unless you link to what fix you are referring to. And is this a \"fix\" that folks were running into that we need to make sure they are aware of when reading about upgrade changes?\n\nThis either needs to be updated to state that the driver and what changed, or just remove it. My preference would be just to remove it unless this was a very common \"failure\" that VMAX users were hitting, but I don\u0027t believe that to be the case.","commit_id":"ab70653149f51ce913ee3c94966a1bfc9c546620"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"4aaef78ee30962ee12f6d93ba08bea0fc27600c8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fix puts the unmanaged \"orphan\" volume in a storage group called"},{"line_number":5,"context_line":"    OS-Unmanaged."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_45945198","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":12},"in_reply_to":"3f79a3b5_1b6cb8cd","updated":"2018-11-23 15:31:49.000000000","message":"Or of course, we can remove it.  See the other consequence of having an unmanaged in an \u0027orphan\u0027 state that Michael has highlighted.","commit_id":"ab70653149f51ce913ee3c94966a1bfc9c546620"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d7ee9dd397b18c0208dd2ed87e0d15d509f0b616","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This fix puts the unmanaged \"orphan\" volume in a storage group called"},{"line_number":5,"context_line":"    OS-Unmanaged."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_1b6cb8cd","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":12},"in_reply_to":"3f79a3b5_50960df0","updated":"2018-11-20 11:40:15.000000000","message":"Hi Sean,\nThis is not so much a fix as an improvement.  We are unmanaging the volume out of OpenStack and putting it in an storage group so it is easier to find through symcli or Unisphere for PowerMax.  Perhaps instead of putting it under \u0027fixes:\u0027 section it should be under \u0027other:\u0027 section.  What do you think?\nThank you,\nHelen","commit_id":"ab70653149f51ce913ee3c94966a1bfc9c546620"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"304ed7fbf764eb17cb32b1005d4f6053f85fa989","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This PowerMax driver patch puts the unmanaged \"orphan\" volume in a storage"},{"line_number":5,"context_line":"    group called OS-Unmanaged. It is not obvious that an unmanaged volume has"},{"line_number":6,"context_line":"    any snapshots until it is placed into a storage group."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_0f82c451","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":30},"updated":"2018-11-27 16:36:23.000000000","message":"This still doesn\u0027t make sense in the context of the generated release notes.\n\nMaybe something like \"The PowerMax driver now...\"","commit_id":"ad8a56e023c8865e78177941affc976cb7f5938f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a07f1c65784e91af15b9f2f646a25c320a8722bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This PowerMax driver patch puts the unmanaged \"orphan\" volume in a storage"},{"line_number":5,"context_line":"    group called OS-Unmanaged. It is not obvious that an unmanaged volume has"},{"line_number":6,"context_line":"    any snapshots until it is placed into a storage group."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_caafda99","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":30},"in_reply_to":"3f79a3b5_0f82c451","updated":"2018-11-27 17:28:22.000000000","message":"Sure","commit_id":"ad8a56e023c8865e78177941affc976cb7f5938f"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6d15dd6c217bf865db6d14bfde9392092fe7c2d5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This PowerMax driver patch puts the unmanaged \"orphan\" volume in a storage"},{"line_number":5,"context_line":"    group called OS-Unmanaged. It is not obvious that an unmanaged volume has"},{"line_number":6,"context_line":"    any snapshots until it is placed into a storage group."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_4a274ab0","line":6,"range":{"start_line":5,"start_character":31,"end_line":6,"end_character":58},"updated":"2018-11-27 17:14:33.000000000","message":"It is not clear what this means.","commit_id":"ad8a56e023c8865e78177941affc976cb7f5938f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a07f1c65784e91af15b9f2f646a25c320a8722bb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"other:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This PowerMax driver patch puts the unmanaged \"orphan\" volume in a storage"},{"line_number":5,"context_line":"    group called OS-Unmanaged. It is not obvious that an unmanaged volume has"},{"line_number":6,"context_line":"    any snapshots until it is placed into a storage group."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_aaacdea7","line":6,"range":{"start_line":5,"start_character":31,"end_line":6,"end_character":58},"in_reply_to":"3f79a3b5_4a274ab0","updated":"2018-11-27 17:28:22.000000000","message":"Perhaps it is best I remove this line.  We cannot query its associated snapvx snapshots(if it has any) using the symcli, unisphere REST or Unisphere management software unless it is in a storage group.  \nWill I clarify or remove?","commit_id":"ad8a56e023c8865e78177941affc976cb7f5938f"}]}