)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a4d7082dce54a7e59c641b5283c73f382445dc6c","unresolved":false,"context_lines":[{"line_number":2800,"context_line":"                    _retype_error(context, volume, old_reservations,"},{"line_number":2801,"context_line":"                                  new_reservations, status_update)"},{"line_number":2802,"context_line":"        else:"},{"line_number":2803,"context_line":"            volume_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2804,"context_line":"                                                       new_type_id)"},{"line_number":2805,"context_line":"            extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"},{"line_number":2806,"context_line":"            multiattach \u003d (extra_specs.get(\u0027multiattach\u0027, \u0027False\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6b6b17ef","line":2803,"range":{"start_line":2803,"start_character":12,"end_line":2803,"end_character":24},"updated":"2018-09-21 11:55:02.000000000","message":"How do you know that the backends volume is being retyped within the same backend? If you are in different backends the new type might not support multiattach.","commit_id":"5b9e6a75c534cfdffafb1b81abff136da1a0e0e2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8f1a71e390ce0b9b07a86f0db229a6130210b2f5","unresolved":false,"context_lines":[{"line_number":2800,"context_line":"                    _retype_error(context, volume, old_reservations,"},{"line_number":2801,"context_line":"                                  new_reservations, status_update)"},{"line_number":2802,"context_line":"        else:"},{"line_number":2803,"context_line":"            volume_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2804,"context_line":"                                                       new_type_id)"},{"line_number":2805,"context_line":"            extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"},{"line_number":2806,"context_line":"            multiattach \u003d (extra_specs.get(\u0027multiattach\u0027, \u0027False\u0027) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_a51aa179","line":2803,"range":{"start_line":2803,"start_character":12,"end_line":2803,"end_character":24},"in_reply_to":"3f79a3b5_6b6b17ef","updated":"2018-09-24 05:12:14.000000000","message":"Ok, so i mistook extra_specs as the only parameter to determine the multiattach support. I think the new code will serve the functionality.","commit_id":"5b9e6a75c534cfdffafb1b81abff136da1a0e0e2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7cb67b3ade820930d61b8d3a7b9e902a6ba2f700","unresolved":false,"context_lines":[{"line_number":2801,"context_line":"                                  new_reservations, status_update)"},{"line_number":2802,"context_line":"        else:"},{"line_number":2803,"context_line":"            capabilities \u003d self.get_capabilities(context,"},{"line_number":2804,"context_line":"                                                 True)"},{"line_number":2805,"context_line":"            if capabilities[\u0027pools\u0027][0].get(\u0027multiattach\u0027):"},{"line_number":2806,"context_line":"                volume_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2807,"context_line":"                                                           new_type_id)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_319bf017","line":2804,"updated":"2018-09-26 17:14:47.000000000","message":"This is not a good idea, this will result in a call to `get_volume_stats` with `refresh\u003dTrue`, which is not good, as it is an expensive operation on some backends.","commit_id":"b9dc2c1325024edcdd8b7d1ea7f460f16853b848"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7cb67b3ade820930d61b8d3a7b9e902a6ba2f700","unresolved":false,"context_lines":[{"line_number":2802,"context_line":"        else:"},{"line_number":2803,"context_line":"            capabilities \u003d self.get_capabilities(context,"},{"line_number":2804,"context_line":"                                                 True)"},{"line_number":2805,"context_line":"            if capabilities[\u0027pools\u0027][0].get(\u0027multiattach\u0027):"},{"line_number":2806,"context_line":"                volume_type \u003d volume_types.get_volume_type(context.elevated(),"},{"line_number":2807,"context_line":"                                                           new_type_id)"},{"line_number":2808,"context_line":"                extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_d1f4fc57","line":2805,"updated":"2018-09-26 17:14:47.000000000","message":"Some backends don\u0027t report a `pools` key, so we\u0027ll break with those here.","commit_id":"b9dc2c1325024edcdd8b7d1ea7f460f16853b848"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7cb67b3ade820930d61b8d3a7b9e902a6ba2f700","unresolved":false,"context_lines":[{"line_number":2807,"context_line":"                                                           new_type_id)"},{"line_number":2808,"context_line":"                extra_specs \u003d volume_type.get(\u0027extra_specs\u0027, {})"},{"line_number":2809,"context_line":"                multiattach \u003d (extra_specs.get(\u0027multiattach\u0027, \u0027False\u0027) \u003d\u003d"},{"line_number":2810,"context_line":"                               \u0027\u003cis\u003e True\u0027)"},{"line_number":2811,"context_line":"            else:"},{"line_number":2812,"context_line":"                multiattach \u003d False"},{"line_number":2813,"context_line":"            model_update \u003d {\u0027volume_type_id\u0027: new_type_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f43c86c1","line":2810,"updated":"2018-09-26 17:14:47.000000000","message":"This is wrong, as should be case insensitive and The scheduler considers true any of these: t true on y yes 1","commit_id":"b9dc2c1325024edcdd8b7d1ea7f460f16853b848"}]}