)]}'
{"cinder/volume/drivers/hgst.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1057580bf116e78a8bc7e80f15c6def4694e0745","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                    \"verify that the cluster is running and \""},{"line_number":214,"context_line":"                    \"connected.\") % {\u0027space\u0027: space_name}"},{"line_number":215,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":216,"context_line":"        ret \u003d json.loads(out)"},{"line_number":217,"context_line":"        retval \u003d {}"},{"line_number":218,"context_line":"        retval[\u0027redundancy\u0027] \u003d int(ret[\u0027resources\u0027][0][\u0027redundancy\u0027])"},{"line_number":219,"context_line":"        retval[\u0027sizeBytes\u0027] \u003d int(ret[\u0027resources\u0027][0][\u0027sizeBytes\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c6c90725","line":216,"updated":"2018-09-21 06:47:31.000000000","message":"here","commit_id":"542e8720bb9028fa4c95d63e9ead5f560a680837"},{"author":{"_account_id":25553,"name":"Akhil jain","email":"akhiljain32@gmail.com","username":"akhil"},"change_message_id":"7ee39c4cef229eaca910c24c004446f0c577f826","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def create_volume_from_snapshot(self, volume, snapshot):"},{"line_number":547,"context_line":"        \"\"\"Create volume from a snapshot, but snaps still full volumes.\"\"\""},{"line_number":548,"context_line":"        ret \u003d self.create_cloned_volume(volume, snapshot)"},{"line_number":549,"context_line":"        if volume.get(\u0027size\u0027) \u003e snapshot.get(\u0027size\u0027):"},{"line_number":550,"context_line":"            self.extend_volume(ret, volume.get(\u0027size\u0027))"},{"line_number":551,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_66091382","line":548,"range":{"start_line":548,"start_character":8,"end_line":548,"end_character":11},"updated":"2018-09-21 06:36:55.000000000","message":"Relevant variable name would be better for understanding like cloned_vol","commit_id":"542e8720bb9028fa4c95d63e9ead5f560a680837"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6183ba31c6c0238fcc1d5ceaf5642d495aa27f08","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def create_volume_from_snapshot(self, volume, snapshot):"},{"line_number":547,"context_line":"        \"\"\"Create volume from a snapshot, but snaps still full volumes.\"\"\""},{"line_number":548,"context_line":"        ret \u003d self.create_cloned_volume(volume, snapshot)"},{"line_number":549,"context_line":"        if volume.get(\u0027size\u0027) \u003e snapshot.get(\u0027size\u0027):"},{"line_number":550,"context_line":"            self.extend_volume(ret, volume.get(\u0027size\u0027))"},{"line_number":551,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_058852c3","line":548,"range":{"start_line":548,"start_character":8,"end_line":548,"end_character":11},"in_reply_to":"3f79a3b5_26da3be8","updated":"2018-09-21 10:13:02.000000000","message":"ret is a common and simple variable name to use for a case like this. That is fine.","commit_id":"542e8720bb9028fa4c95d63e9ead5f560a680837"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1057580bf116e78a8bc7e80f15c6def4694e0745","unresolved":false,"context_lines":[{"line_number":545,"context_line":""},{"line_number":546,"context_line":"    def create_volume_from_snapshot(self, volume, snapshot):"},{"line_number":547,"context_line":"        \"\"\"Create volume from a snapshot, but snaps still full volumes.\"\"\""},{"line_number":548,"context_line":"        ret \u003d self.create_cloned_volume(volume, snapshot)"},{"line_number":549,"context_line":"        if volume.get(\u0027size\u0027) \u003e snapshot.get(\u0027size\u0027):"},{"line_number":550,"context_line":"            self.extend_volume(ret, volume.get(\u0027size\u0027))"},{"line_number":551,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_26da3be8","line":548,"range":{"start_line":548,"start_character":8,"end_line":548,"end_character":11},"in_reply_to":"3f79a3b5_66091382","updated":"2018-09-21 06:47:31.000000000","message":"variable names aren\u0027t a concern when the goal is to ultimately return the value, check line #256.","commit_id":"542e8720bb9028fa4c95d63e9ead5f560a680837"}]}