)]}'
{"cinder/volume/drivers/dell_emc/vmax/common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c17642bc962fa3185708085b56aa269244bf5eb9","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"            array, device_id)"},{"line_number":2071,"context_line":"        if storagegrouplist and len(storagegrouplist) \u003e 1:"},{"line_number":2072,"context_line":"            msg \u003d (_(\"Unable to import volume %(device_id)s to cinder. \""},{"line_number":2073,"context_line":"                     \"Volume is in multiple SGs\")"},{"line_number":2074,"context_line":"                   % {\u0027device_id\u0027: device_id})"},{"line_number":2075,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":2076,"context_line":"                existing_ref\u003dexternal_ref, reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b084130d","line":2073,"updated":"2018-09-24 14:55:57.000000000","message":"nit: full stop","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"954009f9350ce39938dffc174186f78f48592d22","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"            array, device_id)"},{"line_number":2071,"context_line":"        if storagegrouplist and len(storagegrouplist) \u003e 1:"},{"line_number":2072,"context_line":"            msg \u003d (_(\"Unable to import volume %(device_id)s to cinder. \""},{"line_number":2073,"context_line":"                     \"Volume is in multiple SGs\")"},{"line_number":2074,"context_line":"                   % {\u0027device_id\u0027: device_id})"},{"line_number":2075,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":2076,"context_line":"                existing_ref\u003dexternal_ref, reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_81366b02","line":2073,"in_reply_to":"3f79a3b5_b084130d","updated":"2018-09-24 18:30:39.000000000","message":"Done","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"06296f7155895626b38ffb5fcdbd4ac91c65b56d","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"        # check if the volume is attached by checking if in any masking view."},{"line_number":2069,"context_line":"        storagegrouplist \u003d self.rest.get_storage_groups_from_volume("},{"line_number":2070,"context_line":"            array, device_id)"},{"line_number":2071,"context_line":"        if storagegrouplist and len(storagegrouplist) \u003e 1:"},{"line_number":2072,"context_line":"            msg \u003d (_(\"Unable to import volume %(device_id)s to cinder. \""},{"line_number":2073,"context_line":"                     \"Volume is in multiple SGs\")"},{"line_number":2074,"context_line":"                   % {\u0027device_id\u0027: device_id})"},{"line_number":2075,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":2076,"context_line":"                existing_ref\u003dexternal_ref, reason\u003dmsg)"},{"line_number":2077,"context_line":"        sg \u003d None"},{"line_number":2078,"context_line":"        if storagegrouplist:"},{"line_number":2079,"context_line":"            sg \u003d storagegrouplist[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d09c2f72","line":2076,"range":{"start_line":2071,"start_character":8,"end_line":2076,"end_character":54},"updated":"2018-09-24 14:52:51.000000000","message":"Please include unit test for this scenario","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"954009f9350ce39938dffc174186f78f48592d22","unresolved":false,"context_lines":[{"line_number":2068,"context_line":"        # check if the volume is attached by checking if in any masking view."},{"line_number":2069,"context_line":"        storagegrouplist \u003d self.rest.get_storage_groups_from_volume("},{"line_number":2070,"context_line":"            array, device_id)"},{"line_number":2071,"context_line":"        if storagegrouplist and len(storagegrouplist) \u003e 1:"},{"line_number":2072,"context_line":"            msg \u003d (_(\"Unable to import volume %(device_id)s to cinder. \""},{"line_number":2073,"context_line":"                     \"Volume is in multiple SGs\")"},{"line_number":2074,"context_line":"                   % {\u0027device_id\u0027: device_id})"},{"line_number":2075,"context_line":"            raise exception.ManageExistingInvalidReference("},{"line_number":2076,"context_line":"                existing_ref\u003dexternal_ref, reason\u003dmsg)"},{"line_number":2077,"context_line":"        sg \u003d None"},{"line_number":2078,"context_line":"        if storagegrouplist:"},{"line_number":2079,"context_line":"            sg \u003d storagegrouplist[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_dcd2085c","line":2076,"range":{"start_line":2071,"start_character":8,"end_line":2076,"end_character":54},"in_reply_to":"3f79a3b5_d09c2f72","updated":"2018-09-24 18:30:39.000000000","message":"Done","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"}],"cinder/volume/drivers/dell_emc/vmax/utils.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c17642bc962fa3185708085b56aa269244bf5eb9","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            exception_message \u003d (_(\"Source volume device ID is required.\"))"},{"line_number":347,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":348,"context_line":"                message\u003dexception_message)"},{"line_number":349,"context_line":"        return array, device_id.upper()"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @staticmethod"},{"line_number":352,"context_line":"    def is_compression_disabled(extra_specs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b0e733e4","line":349,"updated":"2018-09-24 14:55:57.000000000","message":"Can you write a unit test for this also","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"},{"author":{"_account_id":26402,"name":"Kumar Prashant","email":"kumar.prashant@dell.com","username":"prashk"},"change_message_id":"954009f9350ce39938dffc174186f78f48592d22","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            exception_message \u003d (_(\"Source volume device ID is required.\"))"},{"line_number":347,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":348,"context_line":"                message\u003dexception_message)"},{"line_number":349,"context_line":"        return array, device_id.upper()"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    @staticmethod"},{"line_number":352,"context_line":"    def is_compression_disabled(extra_specs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d73741af","line":349,"in_reply_to":"3f79a3b5_b0e733e4","updated":"2018-09-24 18:30:39.000000000","message":"Done","commit_id":"b0240413c7762d9803b77c894c5af1353c3e4bb7"}]}
