)]}'
{"cinder/tests/unit/volume/drivers/vmware/test_fcd.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"0fb5014e60600ecc39733e458fd13a78ecae3145","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                    vops.update_fcd_policy.assert_called_once_with("},{"line_number":681,"context_line":"                        fcd_loc, new_profile_id.uniqueId)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_retype(self):"},{"line_number":684,"context_line":"        self._test_retype()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def test_retype_vc65(self):"},{"line_number":687,"context_line":"        self._test_retype(storage_policy_enabled\u003dFalse)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_retype_same_profile(self):"},{"line_number":690,"context_line":"        self._test_retype(same_profile\u003dTrue)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def test_retype_in_use_volume(self):"},{"line_number":693,"context_line":"        self._test_retype(vol_in_use\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_80879e5b","line":693,"range":{"start_line":683,"start_character":4,"end_line":693,"end_character":42},"updated":"2018-10-02 12:54:08.000000000","message":"Why not to use ddt library here?","commit_id":"b3ee664e2535d9f68d382d5fed8e92e92d85eef5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"480988d529054bd7bd97d791c8616d429fabdcd1","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                    vops.update_fcd_policy.assert_called_once_with("},{"line_number":681,"context_line":"                        fcd_loc, new_profile_id.uniqueId)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_retype(self):"},{"line_number":684,"context_line":"        self._test_retype()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def test_retype_vc65(self):"},{"line_number":687,"context_line":"        self._test_retype(storage_policy_enabled\u003dFalse)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_retype_same_profile(self):"},{"line_number":690,"context_line":"        self._test_retype(same_profile\u003dTrue)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def test_retype_in_use_volume(self):"},{"line_number":693,"context_line":"        self._test_retype(vol_in_use\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfdaf3ff_4ab85e29","line":693,"range":{"start_line":683,"start_character":4,"end_line":693,"end_character":42},"in_reply_to":"3f79a3b5_80879e5b","updated":"2019-01-14 20:45:22.000000000","message":"Done","commit_id":"b3ee664e2535d9f68d382d5fed8e92e92d85eef5"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"459971bca10ff28f19e258b9c8e9db67bde24d90","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                    vops.update_fcd_policy.assert_called_once_with("},{"line_number":681,"context_line":"                        fcd_loc, new_profile_id.uniqueId)"},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    def test_retype(self):"},{"line_number":684,"context_line":"        self._test_retype()"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def test_retype_vc65(self):"},{"line_number":687,"context_line":"        self._test_retype(storage_policy_enabled\u003dFalse)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"    def test_retype_same_profile(self):"},{"line_number":690,"context_line":"        self._test_retype(same_profile\u003dTrue)"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"    def test_retype_in_use_volume(self):"},{"line_number":693,"context_line":"        self._test_retype(vol_in_use\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_301fdc71","line":693,"range":{"start_line":683,"start_character":4,"end_line":693,"end_character":42},"in_reply_to":"3f79a3b5_80879e5b","updated":"2018-11-27 21:01:35.000000000","message":"The convention used in this module is to use ddt for passing different values for properties used in the method to be tested; for e.g., adapter type or vmdk type. We use different test methods to execute different code paths. If you are ok with this, I prefer not to change.","commit_id":"b3ee664e2535d9f68d382d5fed8e92e92d85eef5"}]}