)]}'
{"cinder/objects/volume_type.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"87be2fbba11b3270351af83c96ef38ecc4d001a0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return utils.is_replicated_spec(self.extra_specs)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def is_multiattach(self):"},{"line_number":169,"context_line":"        return self.extra_specs.get(\u0027multiattach\u0027, \u0027False\u0027) \u003d\u003d \u0027\u003cis\u003e True\u0027"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"@base.CinderObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0c8c792c","line":169,"updated":"2018-09-28 01:37:54.000000000","message":"There are 2 small advice:\n1. we need process None extra_specs in here, so, it\u0027s better to check extra_spec is not None [1], right?\n2. it seems we need process  something like \u0027\u003cis\u003e  True\u0027 (more than one space), you can see [2] as a ref\n\n[1] https://review.openstack.org/#/c/605854/1/cinder/objects/volume_type.py@L45\n[2] https://github.com/openstack/cinder/blob/master/cinder/volume/utils.py#L958-L966","commit_id":"e748af2a6c7a5eb3873355a49da23a1f70778235"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71ec8e39afc2b23ebd15ca4d47b20ebb3b34bea0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return utils.is_replicated_spec(self.extra_specs)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def is_multiattach(self):"},{"line_number":169,"context_line":"        return self.extra_specs.get(\u0027multiattach\u0027, \u0027False\u0027) \u003d\u003d \u0027\u003cis\u003e True\u0027"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"@base.CinderObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0bb67fdd","line":169,"in_reply_to":"3f79a3b5_0c8c792c","updated":"2018-09-29 13:59:49.000000000","message":"Done","commit_id":"e748af2a6c7a5eb3873355a49da23a1f70778235"}],"cinder/volume/utils.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4528e164662a737c0c1cd052c3aa3e93896c34b9","unresolved":false,"context_lines":[{"line_number":955,"context_line":"    return clone_key_id"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"def is_replicated_str(str):"},{"line_number":959,"context_line":"    spec \u003d (str or \u0027\u0027).split()"},{"line_number":960,"context_line":"    return (len(spec) \u003d\u003d 2 and"},{"line_number":961,"context_line":"            spec[0] \u003d\u003d \u0027\u003cis\u003e\u0027 and strutils.bool_from_string(spec[1]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_675ddf14","line":958,"range":{"start_line":958,"start_character":4,"end_line":958,"end_character":21},"updated":"2018-09-30 01:25:04.000000000","message":"emm, it would be good if this method can be rename to a common name to show the real intent of it, and add some doc on it, maybe something like: ``is_true_str``, ``is_true_suffix``? (or something which is better)","commit_id":"b735c44c24b691dfaae35cafc429433458e56759"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3810bbcc1d25836cabda787e129e14947be6d701","unresolved":false,"context_lines":[{"line_number":955,"context_line":"    return clone_key_id"},{"line_number":956,"context_line":""},{"line_number":957,"context_line":""},{"line_number":958,"context_line":"def is_replicated_str(str):"},{"line_number":959,"context_line":"    spec \u003d (str or \u0027\u0027).split()"},{"line_number":960,"context_line":"    return (len(spec) \u003d\u003d 2 and"},{"line_number":961,"context_line":"            spec[0] \u003d\u003d \u0027\u003cis\u003e\u0027 and strutils.bool_from_string(spec[1]))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_22b6f5dd","line":958,"range":{"start_line":958,"start_character":4,"end_line":958,"end_character":21},"in_reply_to":"3f79a3b5_675ddf14","updated":"2018-09-30 06:21:40.000000000","message":"So initially i had the same thoughts while reusing the code to make the method more generic.\nBut this has been called from multiple locations like cinder.volume.manager ...\nThis would require a lot of rework in files that are beyond the scope of this patch.\nMaybe i could add a followup patch to make these changes but that doesn\u0027t seem valid for the purpose of this patch.","commit_id":"b735c44c24b691dfaae35cafc429433458e56759"}]}