)]}'
{"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"ab54dd31701c3e88457be36b9bb04e3268e62046","unresolved":false,"context_lines":[{"line_number":641,"context_line":"            return None, False"},{"line_number":642,"context_line":""},{"line_number":643,"context_line":"        try:"},{"line_number":644,"context_line":"            ret \u003d self.driver.create_cloned_volume(volume, image_volume)"},{"line_number":645,"context_line":"            self._cleanup_cg_in_volume(volume)"},{"line_number":646,"context_line":"            return ret, True"},{"line_number":647,"context_line":"        except (NotImplementedError, exception.CinderException):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fc9d0f09","side":"PARENT","line":644,"range":{"start_line":644,"start_character":59,"end_line":644,"end_character":71},"updated":"2018-09-29 06:40:14.000000000","message":"Note for other reviewers: \n\nThis image_volume is internal var of the for-loop.\n\nSomething like:\n\n\t\u003e\u003e\u003e x\u003d1 # outside x\n\t\u003e\u003e\u003e for x in [2,3,4]:\n\t...     if x\u003d\u003d2: # inside x\n\t...         break\n\t...\n\t\u003e\u003e\u003e print(x)  # inside x\n\t2\n\nYes, depends on a wired inside-access, the original code is passed magically. :(\n\nSo, This patch want to make it readable without any functional change.","commit_id":"7f27679466730f9699616ea3ceacb27da422e397"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"220c7b783ee721bdea39a18355b3f6d555e3ff49","unresolved":false,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"            LOG.info(\"Will clone a volume from the image volume \""},{"line_number":636,"context_line":"                     \"%(id)s.\", {\u0027id\u0027: img_vol.id})"},{"line_number":637,"context_line":"            # Record the first hit image volume"},{"line_number":638,"context_line":"            image_volume \u003d img_vol"},{"line_number":639,"context_line":"            break"},{"line_number":640,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_00dc9cdf","line":637,"range":{"start_line":637,"start_character":12,"end_line":637,"end_character":47},"updated":"2018-10-05 12:38:54.000000000","message":"This comment does not really add much.","commit_id":"4e8cdc0be25600dbd2465037d1d12a109b2f4d51"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4edf16b6d13b7bc916cd725ed3b26d7b7d5b170f","unresolved":false,"context_lines":[{"line_number":634,"context_line":""},{"line_number":635,"context_line":"            LOG.info(\"Will clone a volume from the image volume \""},{"line_number":636,"context_line":"                     \"%(id)s.\", {\u0027id\u0027: img_vol.id})"},{"line_number":637,"context_line":"            # Record the first hit image volume"},{"line_number":638,"context_line":"            image_volume \u003d img_vol"},{"line_number":639,"context_line":"            break"},{"line_number":640,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4a0059b2","line":637,"range":{"start_line":637,"start_character":12,"end_line":637,"end_character":47},"in_reply_to":"3f79a3b5_00dc9cdf","updated":"2018-10-08 02:24:16.000000000","message":"Done","commit_id":"4e8cdc0be25600dbd2465037d1d12a109b2f4d51"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c009df966a71e510c2223e2b0bad696e8c7df7b0","unresolved":false,"context_lines":[{"line_number":638,"context_line":"            image_volume \u003d img_vol"},{"line_number":639,"context_line":"            break"},{"line_number":640,"context_line":""},{"line_number":641,"context_line":"        if image_volume is None:"},{"line_number":642,"context_line":"            LOG.debug(\"No accessible image volume for image %(id)s found.\","},{"line_number":643,"context_line":"                      {\u0027id\u0027: image_meta[\u0027id\u0027]})"},{"line_number":644,"context_line":"            return None, False"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_45091827","line":641,"updated":"2018-10-08 18:45:00.000000000","message":"for/else was a nicer pattern than adding an \"if\" here.  :/","commit_id":"c449dd204a8fe10b06a20c2c6dc6268597ebdfea"}]}