)]}'
{"cinder/db/sqlalchemy/migrate_repo/versions/022_add_reason_column_to_service.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a49dd589a9c1a03ca949c7ced66a46250a9f510b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9p5o%3D","line":26,"updated":"2013-12-09 08:37:22.000000000","message":"should this column be nullable by default?","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"361d1498e5377681886943c45fc2712fdf18ba8f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9lLs%3D","line":26,"in_reply_to":"AAAATn%2F9lb4%3D","updated":"2013-12-10 00:42:31.000000000","message":"Thanks Jay and Victor.\n\nAfter a second thought, I think that it is better remove this line in my patch and I will upload another to clean all related code later.\n\nHope it is OK.","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"82be4b02405410db5acf5612f9275a8e4fedf93b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9lb4%3D","line":26,"in_reply_to":"AAAATn%2F9oik%3D","updated":"2013-12-09 23:11:41.000000000","message":"I think this is fine.  Setting it to None is not consistent with what I have seen in other migrate scripts.","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"d7c82a47174c415a6a21080a7c5a88ac74ef4b2c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9pxY%3D","line":26,"in_reply_to":"AAAATn%2F9p1I%3D","updated":"2013-12-09 09:18:50.000000000","message":"It was set as nullable\u003dTrue, when you create this column. So it\u0027s already have NULL values in database. See  http://docs.sqlalchemy.org/en/rel_0_8/core/metadata.html#sqlalchemy.schema.Column","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"674f6b3708daccdb066b62e02e84305741431188","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9p1I%3D","line":26,"in_reply_to":"AAAATn%2F9p5o%3D","updated":"2013-12-09 08:49:09.000000000","message":"Yes, so is it OK to set it as None by default?","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"dd7ad0d501384b9041fd4b9c420dfd056da99282","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9oik%3D","line":26,"in_reply_to":"AAAATn%2F9pns%3D","updated":"2013-12-09 14:07:31.000000000","message":"I think that this line can be safely removed, but it\u0027s also ok for me. Lets wait for another reviewers.","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"6e692c14b1f0fa0af45500686ce6bc6cdad41238","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    services \u003d Table(\u0027services\u0027, meta, autoload\u003dTrue)"},{"line_number":24,"context_line":"    reason \u003d Column(\u0027disabled_reason\u0027, String(255))"},{"line_number":25,"context_line":"    services.create_column(reason)"},{"line_number":26,"context_line":"    services.update().values(disabled_reason\u003dNone).execute()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def downgrade(migrate_engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9pns%3D","line":26,"in_reply_to":"AAAATn%2F9pxY%3D","updated":"2013-12-09 09:44:11.000000000","message":"Thanks Victor, so you mean that we can remove this line?\n\nWhat about keep this for now, as I noticed that most code are using similar logic.\n\nPlease refer to https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/migrate_repo/versions/014_add_name_id.py#L27","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"}],"cinder/tests/test_migrations.py":[{"author":{"_account_id":7491,"name":"Viktor Serhieiev","email":"viktor.sergeyev@gmail.com","username":"vsergeyev"},"change_message_id":"a49dd589a9c1a03ca949c7ced66a46250a9f510b","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            migration_api.version_control(engine,"},{"line_number":1045,"context_line":"                                          TestMigrations.REPOSITORY,"},{"line_number":1046,"context_line":"                                          migration.db_initial_version())"},{"line_number":1047,"context_line":"            migration_api.upgrade(engine, TestMigrations.REPOSITORY, 21)"},{"line_number":1048,"context_line":"            metadata \u003d sqlalchemy.schema.MetaData()"},{"line_number":1049,"context_line":"            metadata.bind \u003d engine"},{"line_number":1050,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9p4w%3D","line":1047,"updated":"2013-12-09 08:37:22.000000000","message":"why do you need this line?","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"674f6b3708daccdb066b62e02e84305741431188","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"            migration_api.version_control(engine,"},{"line_number":1045,"context_line":"                                          TestMigrations.REPOSITORY,"},{"line_number":1046,"context_line":"                                          migration.db_initial_version())"},{"line_number":1047,"context_line":"            migration_api.upgrade(engine, TestMigrations.REPOSITORY, 21)"},{"line_number":1048,"context_line":"            metadata \u003d sqlalchemy.schema.MetaData()"},{"line_number":1049,"context_line":"            metadata.bind \u003d engine"},{"line_number":1050,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9p0w%3D","line":1047,"in_reply_to":"AAAATn%2F9p4w%3D","updated":"2013-12-09 08:49:09.000000000","message":"Just want to make sure that this test case can be start from 21.\n\nYou can refer to test_migration_019, test_migration_020, they are all using similar way for test.","commit_id":"40d5d850e5a72d61cd25136c3e9ecaae4c2cb915"}]}