)]}'
{"cinder/tests/scheduler/fakes.py":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"15fa3485f3d2133fcbbfc9825e8f9aca05bca2ab","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            setattr(self, key, val)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def mock_host_manager_db_calls(mock):"},{"line_number":65,"context_line":"    services \u003d ["},{"line_number":66,"context_line":"        dict(id\u003d1, host\u003d\u0027host1\u0027, topic\u003d\u0027volume\u0027, disabled\u003dFalse,"},{"line_number":67,"context_line":"             availability_zone\u003d\u0027zone1\u0027, updated_at\u003dtimeutils.utcnow()),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9aS0%3D","line":64,"updated":"2013-12-11 20:14:38.000000000","message":"The mock arg here should be renamed to avoid overriding the module name.","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"0605fb72a88627affc3daed5b223669bc8b0db99","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            setattr(self, key, val)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"def mock_host_manager_db_calls(mock):"},{"line_number":65,"context_line":"    services \u003d ["},{"line_number":66,"context_line":"        dict(id\u003d1, host\u003d\u0027host1\u0027, topic\u003d\u0027volume\u0027, disabled\u003dFalse,"},{"line_number":67,"context_line":"             availability_zone\u003d\u0027zone1\u0027, updated_at\u003dtimeutils.utcnow()),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Xg8%3D","line":64,"in_reply_to":"AAAATn%2F9aS0%3D","updated":"2013-12-12 07:31:15.000000000","message":"Done","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"}],"cinder/tests/scheduler/test_filter_scheduler.py":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"15fa3485f3d2133fcbbfc9825e8f9aca05bca2ab","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    driver_cls \u003d filter_scheduler.FilterScheduler"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_volume_no_hosts(self):"},{"line_number":35,"context_line":"        # Ensure empty hosts/child_zones result in NoValidHosts exception"},{"line_number":36,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        fake_context \u003d context.RequestContext(\u0027user\u0027, \u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9aRs%3D","line":35,"updated":"2013-12-11 20:14:38.000000000","message":"nit: I think we normally enforce full stops.","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"0605fb72a88627affc3daed5b223669bc8b0db99","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    driver_cls \u003d filter_scheduler.FilterScheduler"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_volume_no_hosts(self):"},{"line_number":35,"context_line":"        # Ensure empty hosts/child_zones result in NoValidHosts exception"},{"line_number":36,"context_line":"        sched \u003d fakes.FakeFilterScheduler()"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        fake_context \u003d context.RequestContext(\u0027user\u0027, \u0027project\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Xg0%3D","line":35,"in_reply_to":"AAAATn%2F9aRs%3D","updated":"2013-12-12 07:31:15.000000000","message":"Done","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"}],"cinder/tests/scheduler/test_host_manager.py":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"15fa3485f3d2133fcbbfc9825e8f9aca05bca2ab","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @mock.patch(\u0027cinder.scheduler.host_manager.HostManager.\u0027"},{"line_number":70,"context_line":"                \u0027_choose_host_filters\u0027)"},{"line_number":71,"context_line":"    def test_get_filtered_hosts(self, _mock_choose_host_filters):"},{"line_number":72,"context_line":"        filter_class \u003d FakeFilterClass1"},{"line_number":73,"context_line":"        mock_func \u003d mock.Mock()"},{"line_number":74,"context_line":"        mock_func.return_value \u003d True"},{"line_number":75,"context_line":"        filter_class._filter_one \u003d mock_func"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9aP0%3D","line":72,"updated":"2013-12-11 20:14:38.000000000","message":"could probably replace FakeFilterClass1 with a MagicMock since it does\u0027nt do anything?","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"0605fb72a88627affc3daed5b223669bc8b0db99","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @mock.patch(\u0027cinder.scheduler.host_manager.HostManager.\u0027"},{"line_number":70,"context_line":"                \u0027_choose_host_filters\u0027)"},{"line_number":71,"context_line":"    def test_get_filtered_hosts(self, _mock_choose_host_filters):"},{"line_number":72,"context_line":"        filter_class \u003d FakeFilterClass1"},{"line_number":73,"context_line":"        mock_func \u003d mock.Mock()"},{"line_number":74,"context_line":"        mock_func.return_value \u003d True"},{"line_number":75,"context_line":"        filter_class._filter_one \u003d mock_func"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Xgs%3D","line":72,"in_reply_to":"AAAATn%2F9aP0%3D","updated":"2013-12-12 07:31:15.000000000","message":"I tried this initially, but FakeFilterClass1 inherits from BaseHostFilter, which inherits from BaseFilter, which contains the filter_all() function that is needed here.","commit_id":"89703a5496f4b8914cccdf80d1e5ac8fa270402e"}]}
