)]}'
{"cinder/volume/drivers/nimble.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1b10c6381e9c244f4dbddb2cb1ee9eacd60e6d8e","unresolved":false,"context_lines":[{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"    def get_volume_acl_records(self, volume_id):"},{"line_number":1527,"context_line":"        api \u003d \"volumes/\" + six.text_type(volume_id)"},{"line_number":1528,"context_line":"        r \u003d self.get(api)"},{"line_number":1529,"context_line":"        if not r.json()[\u0027data\u0027]:"},{"line_number":1530,"context_line":"            raise NimbleAPIException(_(\"Unable to retrieve information for \""},{"line_number":1531,"context_line":"                                       \"volume: %s\") % volume_id)"},{"line_number":1532,"context_line":"        return r.json()[\u0027data\u0027][\u0027access_control_records\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f32c1802","line":1529,"range":{"start_line":1528,"start_character":8,"end_line":1529,"end_character":32},"updated":"2018-10-03 05:59:31.000000000","message":"can you explain the handling of this get request?\nIMO there should be a r.status_code check or\nr.json().get(\u0027data\u0027) so as to avoid KeyError?","commit_id":"b2d0ac0c2e121ac0107603090974082f29f849c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2373c520fdd0a4e9e0eeb93949085c0c4c81cddd","unresolved":false,"context_lines":[{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"    def get_volume_acl_records(self, volume_id):"},{"line_number":1527,"context_line":"        api \u003d \"volumes/\" + six.text_type(volume_id)"},{"line_number":1528,"context_line":"        r \u003d self.get(api)"},{"line_number":1529,"context_line":"        if not r.json()[\u0027data\u0027]:"},{"line_number":1530,"context_line":"            raise NimbleAPIException(_(\"Unable to retrieve information for \""},{"line_number":1531,"context_line":"                                       \"volume: %s\") % volume_id)"},{"line_number":1532,"context_line":"        return r.json()[\u0027data\u0027][\u0027access_control_records\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_05ba9c09","line":1529,"range":{"start_line":1528,"start_character":8,"end_line":1529,"end_character":32},"in_reply_to":"3f79a3b5_1f12eb55","updated":"2018-10-03 17:43:18.000000000","message":"This seems to explain my query. Thanks.","commit_id":"b2d0ac0c2e121ac0107603090974082f29f849c5"},{"author":{"_account_id":16668,"name":"Raunak Kumar","email":"rkumar@nimblestorage.com","username":"rkumar"},"change_message_id":"b8a7eabca1e673ea95ba4eb4e81aa1e5c4adb2ea","unresolved":false,"context_lines":[{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":"    def get_volume_acl_records(self, volume_id):"},{"line_number":1527,"context_line":"        api \u003d \"volumes/\" + six.text_type(volume_id)"},{"line_number":1528,"context_line":"        r \u003d self.get(api)"},{"line_number":1529,"context_line":"        if not r.json()[\u0027data\u0027]:"},{"line_number":1530,"context_line":"            raise NimbleAPIException(_(\"Unable to retrieve information for \""},{"line_number":1531,"context_line":"                                       \"volume: %s\") % volume_id)"},{"line_number":1532,"context_line":"        return r.json()[\u0027data\u0027][\u0027access_control_records\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1f12eb55","line":1529,"range":{"start_line":1528,"start_character":8,"end_line":1529,"end_character":32},"in_reply_to":"3f79a3b5_f32c1802","updated":"2018-10-03 16:03:01.000000000","message":"This is the generic get we use for all our REST API\u0027s unless there is an exception from requests.get(). All our API\u0027s return with data key so it is just an additional check. \nAs far as key error is concerned all our /volumes get API return the access_control_records, it could be just that it could be empty which is why the check for None","commit_id":"b2d0ac0c2e121ac0107603090974082f29f849c5"}]}