)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sivaramakrishna Garimella \u003csivaramakrishna.garimella@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-09 13:03:42 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug #1258033 - Add additional metadata as key-value pairs in 3PAR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Track status of openstack volumes on 3PAR through"},{"line_number":10,"context_line":"additional metadata added as key-value pairs. During volume attach"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9nlw%3D","line":7,"updated":"2013-12-09 16:09:57.000000000","message":"Don\u0027t normally include the bug in the first line.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sivaramakrishna Garimella \u003csivaramakrishna.garimella@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-09 13:03:42 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Bug #1258033 - Add additional metadata as key-value pairs in 3PAR"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Track status of openstack volumes on 3PAR through"},{"line_number":10,"context_line":"additional metadata added as key-value pairs. During volume attach"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F9mDk%3D","line":7,"in_reply_to":"AAAATn%2F9nlw%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"}],"cinder/tests/test_hp3par.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"643fe8f79f8e60f3b09e81f6ac145f16404888f6","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        src_vref \u003d {}"},{"line_number":575,"context_line":"        model_update \u003d self.driver.create_cloned_volume(volume, src_vref)"},{"line_number":576,"context_line":"        self.assertIsNotNone(model_update)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def test_attach_volume(self):"},{"line_number":579,"context_line":"        _run_ssh \u003d self.mox.CreateMock(hpdriver.hpcommon.HP3PARCommon._run_ssh)"},{"line_number":580,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"_run_ssh\", _run_ssh)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9gRQ%3D","line":577,"updated":"2013-12-10 21:01:48.000000000","message":"For these new tests you should be using mock instead of mox... one of the cinder core members note this on another review of ours. You can see the review and how mock is being used here: https://review.openstack.org/#/c/60637/4/cinder/tests/test_hp3par.py\n\nOther than this, the review looks fine to me.","commit_id":"34cbca127209f09625ff6154c0f1b6d19714a452"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"03147c545603979ea74919f3fe016dec4b17023d","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        src_vref \u003d {}"},{"line_number":575,"context_line":"        model_update \u003d self.driver.create_cloned_volume(volume, src_vref)"},{"line_number":576,"context_line":"        self.assertIsNotNone(model_update)"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def test_attach_volume(self):"},{"line_number":579,"context_line":"        _run_ssh \u003d self.mox.CreateMock(hpdriver.hpcommon.HP3PARCommon._run_ssh)"},{"line_number":580,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"_run_ssh\", _run_ssh)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9M1M%3D","line":577,"in_reply_to":"AAAATn%2F9gRQ%3D","updated":"2013-12-14 10:49:46.000000000","message":"Done","commit_id":"34cbca127209f09625ff6154c0f1b6d19714a452"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"bfc603a2fb76480be101b3b2c53aa092dca94cbe","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":26,"context_line":"from mock import Mock"},{"line_number":27,"context_line":"from mock import patch"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from cinder import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9NkE%3D","line":27,"updated":"2013-12-14 00:01:10.000000000","message":"Third party libraries should be in the first import block (right above \u0027import mox\u0027).","commit_id":"95b73dc209e2f8f289b64c269ed4e1c22a81d051"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"874c31d4bf35305fb93a080796f1915d09ab7fa9","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":26,"context_line":"from mock import Mock"},{"line_number":27,"context_line":"from mock import patch"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from cinder import context"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9M50%3D","line":27,"in_reply_to":"AAAATn%2F9NkE%3D","updated":"2013-12-14 08:43:53.000000000","message":"Done","commit_id":"95b73dc209e2f8f289b64c269ed4e1c22a81d051"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"a808bdae091aeed13c041cdbea077374f3bcc104","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                  \u0027abcdef\u0027,"},{"line_number":590,"context_line":"                                  \u0027newhost\u0027,"},{"line_number":591,"context_line":"                                  \u0027/dev/vdb\u0027)"},{"line_number":592,"context_line":"        mock_run_ssh.assert_called_once_with(update_cmd, False)"},{"line_number":593,"context_line":"        self.assertRaises(exception.CinderException,"},{"line_number":594,"context_line":"                          self.driver.attach_volume,"},{"line_number":595,"context_line":"                          context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8nyY%3D","line":592,"updated":"2013-12-24 07:28:17.000000000","message":"These commands should\u0027ve still been in with the _run_ssh call, even if things were set to fail. Regardless, we should still be asserting _run_ssh *was* called.","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"3a66b84a2085b5f947d3982b3c63bd80398d727a","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                  \u0027abcdef\u0027,"},{"line_number":590,"context_line":"                                  \u0027newhost\u0027,"},{"line_number":591,"context_line":"                                  \u0027/dev/vdb\u0027)"},{"line_number":592,"context_line":"        mock_run_ssh.assert_called_once_with(update_cmd, False)"},{"line_number":593,"context_line":"        self.assertRaises(exception.CinderException,"},{"line_number":594,"context_line":"                          self.driver.attach_volume,"},{"line_number":595,"context_line":"                          context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8log%3D","line":592,"in_reply_to":"AAAATn%2F8nyY%3D","updated":"2013-12-24 21:59:48.000000000","message":"Done..updated in further patches.","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"bad4b76d5d842b884c4d76ba6064586a29009042","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                                  \u0027abcdef\u0027,"},{"line_number":590,"context_line":"                                  \u0027newhost\u0027,"},{"line_number":591,"context_line":"                                  \u0027/dev/vdb\u0027)"},{"line_number":592,"context_line":"        mock_run_ssh.assert_called_once_with(update_cmd, False)"},{"line_number":593,"context_line":"        self.assertRaises(exception.CinderException,"},{"line_number":594,"context_line":"                          self.driver.attach_volume,"},{"line_number":595,"context_line":"                          context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8ltg%3D","line":592,"in_reply_to":"AAAATn%2F8nyY%3D","updated":"2013-12-24 21:01:19.000000000","message":"I guess that\u0027s what is being done here..","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"a808bdae091aeed13c041cdbea077374f3bcc104","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            self.VOLUME_3PAR_NAME,"},{"line_number":609,"context_line":"        ]"},{"line_number":610,"context_line":"        self.driver.detach_volume(context.get_admin_context(), self.volume)"},{"line_number":611,"context_line":"        mock_run_ssh.assert_called_once_with(cmd, False)"},{"line_number":612,"context_line":"        self.assertRaises(exception.CinderException,"},{"line_number":613,"context_line":"                          self.driver.detach_volume,"},{"line_number":614,"context_line":"                          context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8nyU%3D","line":611,"updated":"2013-12-24 07:28:17.000000000","message":"same","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"3a66b84a2085b5f947d3982b3c63bd80398d727a","unresolved":false,"context_lines":[{"line_number":608,"context_line":"            self.VOLUME_3PAR_NAME,"},{"line_number":609,"context_line":"        ]"},{"line_number":610,"context_line":"        self.driver.detach_volume(context.get_admin_context(), self.volume)"},{"line_number":611,"context_line":"        mock_run_ssh.assert_called_once_with(cmd, False)"},{"line_number":612,"context_line":"        self.assertRaises(exception.CinderException,"},{"line_number":613,"context_line":"                          self.driver.detach_volume,"},{"line_number":614,"context_line":"                          context.get_admin_context(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8loc%3D","line":611,"in_reply_to":"AAAATn%2F8nyU%3D","updated":"2013-12-24 21:59:48.000000000","message":"Done..updated in further patches.","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"3c5dedee1e5dc73f2bbca59a9b1e1ba74e257c54","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION \u003d \"1.2.2\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    stats \u003d {}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nOQ%3D","line":126,"updated":"2013-12-09 17:03:41.000000000","message":"Forgot to bump the actual version.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    \"\"\""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION \u003d \"1.2.2\""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    stats \u003d {}"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9m%2BI%3D","line":126,"in_reply_to":"AAAATn%2F9nOQ%3D","updated":"2013-12-09 21:14:17.000000000","message":"Updated in next patch.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":993,"context_line":"            cmd \u003d [\u0027setvv\u0027, \u0027-setkv\u0027, key + \u0027\u003d\u0027 + value, volume_name]"},{"line_number":994,"context_line":"            self._cli_run(cmd)"},{"line_number":995,"context_line":"        except Exception as ex:"},{"line_number":996,"context_line":"            LOG.error(str(ex), exc_info\u003dTrue)"},{"line_number":997,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"    def clear_volume_key_value_pair(self, volume, key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nmo%3D","line":996,"updated":"2013-12-09 16:09:57.000000000","message":"It seems to me that this exception would be more useful if you indicated what was being attempted when the exception was encountered.  I.E. \u0027Failure in update_volume_key_value_pair: str(ex)\u0027","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":993,"context_line":"            cmd \u003d [\u0027setvv\u0027, \u0027-setkv\u0027, key + \u0027\u003d\u0027 + value, volume_name]"},{"line_number":994,"context_line":"            self._cli_run(cmd)"},{"line_number":995,"context_line":"        except Exception as ex:"},{"line_number":996,"context_line":"            LOG.error(str(ex), exc_info\u003dTrue)"},{"line_number":997,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"    def clear_volume_key_value_pair(self, volume, key):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mDU%3D","line":996,"in_reply_to":"AAAATn%2F9nmo%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"            cmd \u003d [\u0027setvv\u0027, \u0027-clrkey\u0027, key, volume_name]"},{"line_number":1008,"context_line":"            self._cli_run(cmd)"},{"line_number":1009,"context_line":"        except Exception as ex:"},{"line_number":1010,"context_line":"            LOG.error(str(ex), exc_info\u003dTrue)"},{"line_number":1011,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def delete_snapshot(self, snapshot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nmk%3D","line":1010,"updated":"2013-12-09 16:09:57.000000000","message":"Same comment as above.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":1007,"context_line":"            cmd \u003d [\u0027setvv\u0027, \u0027-clrkey\u0027, key, volume_name]"},{"line_number":1008,"context_line":"            self._cli_run(cmd)"},{"line_number":1009,"context_line":"        except Exception as ex:"},{"line_number":1010,"context_line":"            LOG.error(str(ex), exc_info\u003dTrue)"},{"line_number":1011,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":1012,"context_line":""},{"line_number":1013,"context_line":"    def delete_snapshot(self, snapshot):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mDM%3D","line":1010,"in_reply_to":"AAAATn%2F9nmk%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9d1a575ac1b2e434ee023e908296f1de84981d4f","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        except Exception as ex:"},{"line_number":996,"context_line":"            LOG.error(\u0027Failure in update_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":997,"context_line":"                      exc_info\u003dTrue)"},{"line_number":998,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":999,"context_line":""},{"line_number":1000,"context_line":"    def clear_volume_key_value_pair(self, volume, key):"},{"line_number":1001,"context_line":"        \"\"\"Clears key,value pairs metadata from virtual volume.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9ljI%3D","line":998,"updated":"2013-12-09 22:42:42.000000000","message":"We should use the same message in the exception as the log entry.","commit_id":"8d4c99d55b6447ffca8b1ed389bf0a467d1286c0"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"9d1a575ac1b2e434ee023e908296f1de84981d4f","unresolved":false,"context_lines":[{"line_number":1010,"context_line":"        except Exception as ex:"},{"line_number":1011,"context_line":"            LOG.error(\u0027Failure in clear_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":1012,"context_line":"                      exc_info\u003dTrue)"},{"line_number":1013,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":1016,"context_line":"                      mountpoint):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9li8%3D","line":1013,"updated":"2013-12-09 22:42:42.000000000","message":"same as above","commit_id":"8d4c99d55b6447ffca8b1ed389bf0a467d1286c0"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"e7d3437f94fd8d962c74c60d874325234ccf1b53","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"            raise exception.CinderException(str(ex))"},{"line_number":1014,"context_line":""},{"line_number":1015,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":1016,"context_line":"                      mountpoint):"},{"line_number":1017,"context_line":"        LOG.debug(\"Attach Volume\\n%s\" % pprint.pformat(volume))"},{"line_number":1018,"context_line":"        try:"},{"line_number":1019,"context_line":"            self.update_volume_key_value_pair(volume,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9lnQ%3D","line":1016,"updated":"2013-12-09 22:34:47.000000000","message":"The mountpoint variable is not being used, it probably should not be passed to common code.","commit_id":"8d4c99d55b6447ffca8b1ed389bf0a467d1286c0"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"33b335b5aae83ddacac412ce23eddabf8d65c67c","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        except Exception as ex:"},{"line_number":996,"context_line":"            LOG.error(\u0027Failure in update_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":997,"context_line":"                      exc_info\u003dTrue)"},{"line_number":998,"context_line":"            raise exception.CinderException("},{"line_number":999,"context_line":"                \u0027Failure in update_volume_key_value_pair:%s\u0027 % str(ex))"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def clear_volume_key_value_pair(self, volume, key):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8psA%3D","line":998,"updated":"2013-12-23 17:35:17.000000000","message":"I think this would be a good candidate for the \"VolumeBackendAPIException\" usage.","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"9d63a03e0266a38baa2d0852e6d23be91803cc7c","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        except Exception as ex:"},{"line_number":996,"context_line":"            LOG.error(\u0027Failure in update_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":997,"context_line":"                      exc_info\u003dTrue)"},{"line_number":998,"context_line":"            raise exception.CinderException("},{"line_number":999,"context_line":"                \u0027Failure in update_volume_key_value_pair:%s\u0027 % str(ex))"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def clear_volume_key_value_pair(self, volume, key):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8pKo%3D","line":998,"in_reply_to":"AAAATn%2F8psA%3D","updated":"2013-12-23 20:10:10.000000000","message":"Done","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"33b335b5aae83ddacac412ce23eddabf8d65c67c","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        except Exception as ex:"},{"line_number":1012,"context_line":"            LOG.error(\u0027Failure in clear_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":1013,"context_line":"                      exc_info\u003dTrue)"},{"line_number":1014,"context_line":"            raise exception.CinderException("},{"line_number":1015,"context_line":"                \u0027Failure in clear_volume_key_value_pair:%s\u0027 % str(ex))"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    def attach_volume(self, volume, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8pr8%3D","line":1014,"updated":"2013-12-23 17:35:17.000000000","message":"Same as above","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"9d63a03e0266a38baa2d0852e6d23be91803cc7c","unresolved":false,"context_lines":[{"line_number":1011,"context_line":"        except Exception as ex:"},{"line_number":1012,"context_line":"            LOG.error(\u0027Failure in clear_volume_key_value_pair:%s\u0027 % str(ex),"},{"line_number":1013,"context_line":"                      exc_info\u003dTrue)"},{"line_number":1014,"context_line":"            raise exception.CinderException("},{"line_number":1015,"context_line":"                \u0027Failure in clear_volume_key_value_pair:%s\u0027 % str(ex))"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"    def attach_volume(self, volume, instance_uuid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8pKw%3D","line":1014,"in_reply_to":"AAAATn%2F8pr8%3D","updated":"2013-12-23 20:10:10.000000000","message":"Done","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"33b335b5aae83ddacac412ce23eddabf8d65c67c","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1022,"context_line":"                                              instance_uuid)"},{"line_number":1023,"context_line":"        except Exception as ex:"},{"line_number":1024,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1025,"context_line":"                LOG.error(_(\"Error attaching volume %s\") % volume)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"    def detach_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8pro%3D","line":1024,"updated":"2013-12-23 17:35:17.000000000","message":"This is fine I think, but you\u0027re relying on the caller of your driver to handle the exception regardless, so I\u0027m not sure it\u0027s even necessary to do the except and reraise rather than just letting it just go up to the next level on its own.  I don\u0027t have an issue with doing this, just an observation.  Totally up to you on how you want to do this, and maybe I\u0027m missing something.  Just seems the code would be cleaner without this try/except and reraise, and that it might not be necessary.","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"9d63a03e0266a38baa2d0852e6d23be91803cc7c","unresolved":false,"context_lines":[{"line_number":1021,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1022,"context_line":"                                              instance_uuid)"},{"line_number":1023,"context_line":"        except Exception as ex:"},{"line_number":1024,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1025,"context_line":"                LOG.error(_(\"Error attaching volume %s\") % volume)"},{"line_number":1026,"context_line":""},{"line_number":1027,"context_line":"    def detach_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F8pK4%3D","line":1024,"in_reply_to":"AAAATn%2F8pro%3D","updated":"2013-12-23 20:10:10.000000000","message":"Retaiting this for consistency purposes","commit_id":"8cfec8e0f9a7debafbdb11d03babc2641acf7e3d"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"a808bdae091aeed13c041cdbea077374f3bcc104","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"            self.update_volume_key_value_pair(volume,"},{"line_number":1015,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1016,"context_line":"                                              instance_uuid)"},{"line_number":1017,"context_line":"        except Exception as ex:"},{"line_number":1018,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1019,"context_line":"                LOG.error(_(\"Error attaching volume %s\") % volume)"},{"line_number":1020,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8nyI%3D","line":1017,"updated":"2013-12-24 07:28:17.000000000","message":"ex is never used.","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"bad4b76d5d842b884c4d76ba6064586a29009042","unresolved":false,"context_lines":[{"line_number":1014,"context_line":"            self.update_volume_key_value_pair(volume,"},{"line_number":1015,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1016,"context_line":"                                              instance_uuid)"},{"line_number":1017,"context_line":"        except Exception as ex:"},{"line_number":1018,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1019,"context_line":"                LOG.error(_(\"Error attaching volume %s\") % volume)"},{"line_number":1020,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8ltY%3D","line":1017,"in_reply_to":"AAAATn%2F8nyI%3D","updated":"2013-12-24 21:01:19.000000000","message":"Done","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"a808bdae091aeed13c041cdbea077374f3bcc104","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        LOG.debug(\"Detach Volume\\n%s\" % pprint.pformat(volume))"},{"line_number":1023,"context_line":"        try:"},{"line_number":1024,"context_line":"            self.clear_volume_key_value_pair(volume, \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":1025,"context_line":"        except Exception as ex:"},{"line_number":1026,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1027,"context_line":"                LOG.error(_(\"Error detaching volume %s\") % volume)"},{"line_number":1028,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8nyE%3D","line":1025,"updated":"2013-12-24 07:28:17.000000000","message":"ex is never used.","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"bad4b76d5d842b884c4d76ba6064586a29009042","unresolved":false,"context_lines":[{"line_number":1022,"context_line":"        LOG.debug(\"Detach Volume\\n%s\" % pprint.pformat(volume))"},{"line_number":1023,"context_line":"        try:"},{"line_number":1024,"context_line":"            self.clear_volume_key_value_pair(volume, \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":1025,"context_line":"        except Exception as ex:"},{"line_number":1026,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1027,"context_line":"                LOG.error(_(\"Error detaching volume %s\") % volume)"},{"line_number":1028,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F8ltU%3D","line":1025,"in_reply_to":"AAAATn%2F8nyE%3D","updated":"2013-12-24 21:01:19.000000000","message":"Done","commit_id":"d21aacb6e4ce8d59696130c5151a76cacd951e07"}],"cinder/volume/drivers/san/hp/hp_3par_fc.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                the drivers to use the new APIs."},{"line_number":57,"context_line":"        1.2.1 - Synchronized extend_volume method."},{"line_number":58,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":59,"context_line":"        1.2.3 - Additional metadata during attach/detach bug #1258033"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nk8%3D","line":59,"updated":"2013-12-09 16:13:52.000000000","message":"remove after moved to hp_3par_common","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                the drivers to use the new APIs."},{"line_number":57,"context_line":"        1.2.1 - Synchronized extend_volume method."},{"line_number":58,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":59,"context_line":"        1.2.3 - Additional metadata during attach/detach bug #1258033"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mDA%3D","line":59,"in_reply_to":"AAAATn%2F9nk8%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlU%3D","line":299,"updated":"2013-12-09 16:13:52.000000000","message":"This should be moved into hp_3par_common as it the same code as the iSCSI version.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mC8%3D","line":299,"in_reply_to":"AAAATn%2F9nLI%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"01feaa51a86d6397808aca22c8d74fc50412eda8","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nLI%3D","line":299,"in_reply_to":"AAAATn%2F9nlU%3D","updated":"2013-12-09 17:09:35.000000000","message":"Agreed, move the duplicate driver code into common.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"},{"line_number":303,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":304,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9njE%3D","line":301,"updated":"2013-12-09 16:13:52.000000000","message":"this should not be an info message, as it will fill the logs files","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"},{"line_number":303,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":304,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mC4%3D","line":301,"in_reply_to":"AAAATn%2F9nLE%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"01feaa51a86d6397808aca22c8d74fc50412eda8","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":299,"context_line":"                      mountpoint):"},{"line_number":300,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":301,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par FC driver\u0027)"},{"line_number":302,"context_line":"        try:"},{"line_number":303,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":304,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nLE%3D","line":301,"in_reply_to":"AAAATn%2F9njE%3D","updated":"2013-12-09 17:09:35.000000000","message":"Even better, remove this log all together.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":304,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":305,"context_line":"                                                     instance_uuid)"},{"line_number":306,"context_line":"        except Exception as ex:"},{"line_number":307,"context_line":"            LOG.error(str(ex))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlo%3D","line":306,"updated":"2013-12-09 16:09:57.000000000","message":"Here again, I think the exception is more useful with information about where it is coming from.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            LOG.error(str(ex))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":310,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":311,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":312,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par FC driver\u0027)"},{"line_number":313,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlQ%3D","line":310,"updated":"2013-12-09 16:13:52.000000000","message":"This should be moved into hp_3par_common as it the same code as the iSCSI version.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            LOG.error(str(ex))"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":310,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":311,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":312,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par FC driver\u0027)"},{"line_number":313,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mC0%3D","line":310,"in_reply_to":"AAAATn%2F9nlQ%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":310,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":311,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":312,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par FC driver\u0027)"},{"line_number":313,"context_line":"        try:"},{"line_number":314,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":315,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9ni0%3D","line":312,"updated":"2013-12-09 16:13:52.000000000","message":"this should not be an info message, as it will fill the logs files","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":310,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":311,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":312,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par FC driver\u0027)"},{"line_number":313,"context_line":"        try:"},{"line_number":314,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":315,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mCI%3D","line":312,"in_reply_to":"AAAATn%2F9ni0%3D","updated":"2013-12-09 21:14:17.000000000","message":"removed as per walter\u0027s comment.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":315,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":316,"context_line":"        except Exception as ex:"},{"line_number":317,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlk%3D","line":317,"updated":"2013-12-09 16:09:57.000000000","message":"Same here.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":314,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":315,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":316,"context_line":"        except Exception as ex:"},{"line_number":317,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mCY%3D","line":317,"in_reply_to":"AAAATn%2F9nlk%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"e7d3437f94fd8d962c74c60d874325234ccf1b53","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                  volume,"},{"line_number":302,"context_line":"                                  instance_uuid,"},{"line_number":303,"context_line":"                                  host_name,"},{"line_number":304,"context_line":"                                  mountpoint)"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":307,"context_line":"    def detach_volume(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9ll8%3D","line":304,"updated":"2013-12-09 22:34:47.000000000","message":"The mountpoint variable is not used in the common.attach_volume code so it probably should not be sent in the first place.","commit_id":"8d4c99d55b6447ffca8b1ed389bf0a467d1286c0"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"b24106006440e2f99d87409d5e45b5da05384cbb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        1.2.1 - Synchronized extend_volume method."},{"line_number":58,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":59,"context_line":"        1.2.3 - Additional metadata during attach/detach bug #1258033"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    VERSION \u003d \"1.2.3\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9Fy8%3D","line":60,"updated":"2013-12-16 21:39:56.000000000","message":"Sorry, my path took version 1.2.3, please change to 1.2.4.","commit_id":"5b08b8ac53c4f81ecfe6763cfa0154a94fc4c1ef"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"f305d46d3cae6c77223a97f8f1538b5baae65455","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        1.2.1 - Synchronized extend_volume method."},{"line_number":58,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":59,"context_line":"        1.2.3 - Additional metadata during attach/detach bug #1258033"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    VERSION \u003d \"1.2.3\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9D%2Bk%3D","line":60,"in_reply_to":"AAAATn%2F9Fy8%3D","updated":"2013-12-17 06:32:45.000000000","message":"Done","commit_id":"5b08b8ac53c4f81ecfe6763cfa0154a94fc4c1ef"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"1eebc517a5511896181e9b14bd6791e39186c9b4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        1.2.1 - Synchronized extend_volume method."},{"line_number":58,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":59,"context_line":"        1.2.3 - Additional metadata during attach/detach bug #1258033"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    \"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    VERSION \u003d \"1.2.3\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F9Ecc%3D","line":60,"in_reply_to":"AAAATn%2F9Fy8%3D","updated":"2013-12-17 04:07:51.000000000","message":"Hi Jim,\n\nI don\u0027t see your commit merged.. Can you verify?","commit_id":"5b08b8ac53c4f81ecfe6763cfa0154a94fc4c1ef"}],"cinder/volume/drivers/san/hp/hp_3par_iscsi.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":60,"context_line":"        1.2.3 - log exceptions before raising"},{"line_number":61,"context_line":"        1.2.4 - Fixed iSCSI active path bug #1224594"},{"line_number":62,"context_line":"        1.2.5 - Additional metadata during attach/detach bug #1258033"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nkY%3D","line":62,"updated":"2013-12-09 16:13:52.000000000","message":"remove once moved to hp_3par_common","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        1.2.2 - Added try/finally around client login/logout."},{"line_number":60,"context_line":"        1.2.3 - log exceptions before raising"},{"line_number":61,"context_line":"        1.2.4 - Fixed iSCSI active path bug #1224594"},{"line_number":62,"context_line":"        1.2.5 - Additional metadata during attach/detach bug #1258033"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mB4%3D","line":62,"in_reply_to":"AAAATn%2F9nkY%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":430,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":431,"context_line":"                      mountpoint):"},{"line_number":432,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":433,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par iSCSI driver\u0027)"},{"line_number":434,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nk0%3D","line":431,"updated":"2013-12-09 16:13:52.000000000","message":"This should be moved into hp_3par_common as it the same code as the FC version.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":430,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":431,"context_line":"                      mountpoint):"},{"line_number":432,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":433,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par iSCSI driver\u0027)"},{"line_number":434,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mBw%3D","line":431,"in_reply_to":"AAAATn%2F9nk0%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":431,"context_line":"                      mountpoint):"},{"line_number":432,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":433,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par iSCSI driver\u0027)"},{"line_number":434,"context_line":"        try:"},{"line_number":435,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":436,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9niY%3D","line":433,"updated":"2013-12-09 16:13:52.000000000","message":"this should not be an info message, as it will fill the logs files","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    def attach_volume(self, context, volume, instance_uuid, host_name,"},{"line_number":431,"context_line":"                      mountpoint):"},{"line_number":432,"context_line":"        \"\"\"Callback for volume attached to instance or host.\"\"\""},{"line_number":433,"context_line":"        LOG.info(\u0027Cinder attach volume - 3par iSCSI driver\u0027)"},{"line_number":434,"context_line":"        try:"},{"line_number":435,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":436,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mBs%3D","line":433,"in_reply_to":"AAAATn%2F9niY%3D","updated":"2013-12-09 21:14:17.000000000","message":"removed as per walter\u0027s comment","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":436,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":437,"context_line":"                                                     instance_uuid)"},{"line_number":438,"context_line":"        except Exception as ex:"},{"line_number":439,"context_line":"            LOG.error(str(ex))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlc%3D","line":438,"updated":"2013-12-09 16:09:57.000000000","message":"Same comment as other places.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":435,"context_line":"            self.common.update_volume_key_value_pair(volume,"},{"line_number":436,"context_line":"                                                     \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":437,"context_line":"                                                     instance_uuid)"},{"line_number":438,"context_line":"        except Exception as ex:"},{"line_number":439,"context_line":"            LOG.error(str(ex))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mBc%3D","line":438,"in_reply_to":"AAAATn%2F9nlc%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            LOG.error(str(ex))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":442,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":443,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":444,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par iSCSI driver\u0027)"},{"line_number":445,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nkw%3D","line":442,"updated":"2013-12-09 16:13:52.000000000","message":"This should be moved into hp_3par_common as it the same code as the FC version.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            LOG.error(str(ex))"},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":442,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":443,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":444,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par iSCSI driver\u0027)"},{"line_number":445,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mBk%3D","line":442,"in_reply_to":"AAAATn%2F9nkw%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"3a8b68219ee61c032dd328dddf2e180560dddc14","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":442,"context_line":"    def detach_volume(self, context, volume):"},{"line_number":443,"context_line":"        \"\"\"Callback for volume detached from instance or host.\"\"\""},{"line_number":444,"context_line":"        LOG.info(\u0027Cinder detach volume - 3par iSCSI driver\u0027)"},{"line_number":445,"context_line":"        try:"},{"line_number":446,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":447,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9niU%3D","line":444,"updated":"2013-12-09 16:13:52.000000000","message":"this should not be an info message, as it will fill the logs files","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a37fd3648a6542af5724bfe43fc2d0ff1880127c","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        try:"},{"line_number":446,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":447,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":448,"context_line":"        except Exception as ex:"},{"line_number":449,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9nlY%3D","line":448,"updated":"2013-12-09 16:09:57.000000000","message":"Here as well.","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":9628,"name":"Sivaramakrishna Garimella","email":"sivaramakrishna_g@yahoo.in","username":"sivaramakrishna-g"},"change_message_id":"8e7bc286ad685f35be088900b24460c45c556079","unresolved":false,"context_lines":[{"line_number":445,"context_line":"        try:"},{"line_number":446,"context_line":"            self.common.clear_volume_key_value_pair(volume,"},{"line_number":447,"context_line":"                                                    \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":448,"context_line":"        except Exception as ex:"},{"line_number":449,"context_line":"            LOG.error(str(ex))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F9mBg%3D","line":448,"in_reply_to":"AAAATn%2F9nlY%3D","updated":"2013-12-09 21:14:17.000000000","message":"Done","commit_id":"10a7c238f50afc526579512d9e569b13fdd89cd4"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"e7d3437f94fd8d962c74c60d874325234ccf1b53","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                                  volume,"},{"line_number":434,"context_line":"                                  instance_uuid,"},{"line_number":435,"context_line":"                                  host_name,"},{"line_number":436,"context_line":"                                  mountpoint)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @utils.synchronized(\u00273par\u0027, external\u003dTrue)"},{"line_number":439,"context_line":"    def detach_volume(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9llw%3D","line":436,"updated":"2013-12-09 22:34:47.000000000","message":"The mountpoint variable is not used in the common.attach_volume code so it probably should not be sent in the first place.","commit_id":"8d4c99d55b6447ffca8b1ed389bf0a467d1286c0"}]}