)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"568a0efe39de2ef69f80789c693802c17ac19a00","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liyingjun \u003cliyingjun1988@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-11-24 12:05:47 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make sure report interval is less than service down time"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If service_down_time is less than report_interval, services will"},{"line_number":10,"context_line":"routinely be considered down, because they report in too rarely."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAATn%2F9d%2FU%3D","line":7,"updated":"2013-12-11 07:23:13.000000000","message":"It\u0027d best we consistently use the actual config option name in the commit message: \u0027report_interval\u0027, \u0027service_down_time\u0027.","commit_id":"a0b351a071f6670279b2b3cac4779399b76a1b0c"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0891038cff1df12a44c74b770e5b10d4260cb87c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If service_down_time is less than report_interval, services will"},{"line_number":10,"context_line":"routinely be considered down, because they report in too rarely."},{"line_number":11,"context_line":"Add check for service_down_time vs report_interval, if report"},{"line_number":12,"context_line":"interval is larger than service down time, automatically change"},{"line_number":13,"context_line":"service_down_time to be report_interval * 2.5"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAATn%2F9daQ%3D","line":12,"updated":"2013-12-11 09:54:49.000000000","message":"these two should be changed to coresponding config options as well.","commit_id":"bb0a8b21e1b0a004d8e53db75affd7bff3f20eaf"}],"cinder/service.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a94237799753236c681239758f3c9cdff069b3fc","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        report_interval \u003d self.report_interval"},{"line_number":530,"context_line":"        if report_interval is None:"},{"line_number":531,"context_line":"            report_interval \u003d CONF.report_interval"},{"line_number":532,"context_line":"        if CONF.service_down_time \u003c report_interval:"},{"line_number":533,"context_line":"            LOG.error(_(\"Report interval must be less than service down \""},{"line_number":534,"context_line":"                        \"time. Current config: \u003cservice_down_time: \""},{"line_number":535,"context_line":"                        \"%(service_down_time)s, report_interval: \""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ngM%3D","line":532,"updated":"2013-12-09 16:17:54.000000000","message":"Shouldn\u0027t this be \u003c\u003d ?  Otherwise you can have report_interval \u003d\u003d to service_down_time which I do not thing we want to allow.","commit_id":"e58b99fc21a0562279469cee9ccb9b1dee4bdc30"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"139cf5de718d968d7ed9775e47428c20fa2e8d69","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        # Make sure report interval is less than service down time"},{"line_number":529,"context_line":"        report_interval \u003d self.report_interval or CONF.report_interval"},{"line_number":530,"context_line":"        if CONF.service_down_time \u003c\u003d report_interval:"},{"line_number":531,"context_line":"            new_report_interval \u003d CONF.service_down_time / 2"},{"line_number":532,"context_line":"            LOG.warn(_(\"Report interval must be less than service down \""},{"line_number":533,"context_line":"                       \"time. Current config: \u003cservice_down_time: \""},{"line_number":534,"context_line":"                       \"%(service_down_time)s, report_interval: \""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9h34%3D","line":531,"updated":"2013-12-10 15:10:43.000000000","message":"I might even do something like int(CONF.service_down_time / 2.5)","commit_id":"14b78f9e7ba8e9a7b76967072c86efb2fbb25c65"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"aeba49e05bba050e8cc9e9bd334b9ed0bc6cbc67","unresolved":false,"context_lines":[{"line_number":555,"context_line":"            LOG.warn(_(\"Report interval must be less than service down \""},{"line_number":556,"context_line":"                       \"time. Current config: \u003cservice_down_time: \""},{"line_number":557,"context_line":"                       \"%(service_down_time)s, report_interval: \""},{"line_number":558,"context_line":"                       \"%(report_interval)s\u003e. Set service_down_time to: \""},{"line_number":559,"context_line":"                       \"%(new_service_down_time)s\") %"},{"line_number":560,"context_line":"                     {\u0027service_down_time\u0027: CONF.service_down_time,"},{"line_number":561,"context_line":"                      \u0027report_interval\u0027: report_interval,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F9ZHc%3D","line":558,"updated":"2013-12-11 23:40:24.000000000","message":"Shouldn\u0027t this say \"Setting service_down_time to: \"","commit_id":"9d8d40c8dc2febe5f470d13e4acca3bceb267558"}],"cinder/tests/test_service.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"0891038cff1df12a44c74b770e5b10d4260cb87c","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        test_service.stop()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_service_with_min_down_time(self):"},{"line_number":214,"context_line":"        CONF.set_override(\u0027service_down_time\u0027, 5)"},{"line_number":215,"context_line":"        service.WSGIService(\"test_service\")"},{"line_number":216,"context_line":"        self.assertEqual(CONF.service_down_time, 25)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAATn%2F9dZg%3D","line":214,"updated":"2013-12-11 09:54:49.000000000","message":"better override report_interval to \u002710\u0027 as well in case the default value is changed, and that will also make this case easier to understand.","commit_id":"bb0a8b21e1b0a004d8e53db75affd7bff3f20eaf"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"3ffb5689680770171a4b94f779df5613c696a7cf","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        test_service.stop()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_service_with_min_down_time(self):"},{"line_number":214,"context_line":"        CONF.set_override(\u0027service_down_time\u0027, 10)"},{"line_number":215,"context_line":"        service.WSGIService(\"test_service\")"},{"line_number":216,"context_line":"        self.assertEqual(CONF.service_down_time, 25)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Xkw%3D","line":214,"updated":"2013-12-12 06:50:32.000000000","message":"Could you set \u0027report_internal\u0027 to 10 explicitly here to avoid breakage when the default value has been changed?","commit_id":"f71f80591af468bf6ef60f8a9f3d70978ed9a7b2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a52f18b345ccc1ac0854265a710eda28c2246bcb","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        test_service.stop()"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def test_service_with_min_down_time(self):"},{"line_number":214,"context_line":"        CONF.set_override(\u0027service_down_time\u0027, 10)"},{"line_number":215,"context_line":"        service.WSGIService(\"test_service\")"},{"line_number":216,"context_line":"        self.assertEqual(CONF.service_down_time, 25)"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F9Xj4%3D","line":214,"in_reply_to":"AAAATn%2F9Xkw%3D","updated":"2013-12-12 06:57:03.000000000","message":"Done","commit_id":"f71f80591af468bf6ef60f8a9f3d70978ed9a7b2"}]}