)]}'
{"cinder/backup/chunkeddriver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"14e080ea477e0e830698ae58ce914cd00372034b","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                      \u0027object_prefix\u0027: object_prefix,"},{"line_number":343,"context_line":"                      \u0027availability_zone\u0027: availability_zone,"},{"line_number":344,"context_line":"                  })"},{"line_number":345,"context_line":"        object_meta \u003d {\u0027id\u0027: 0, \u0027list\u0027: [], \u0027prefix\u0027: object_prefix,"},{"line_number":346,"context_line":"                       \u0027volume_meta\u0027: None}"},{"line_number":347,"context_line":"        object_sha256 \u003d {\u0027id\u0027: 1, \u0027sha256s\u0027: [], \u0027prefix\u0027: object_prefix}"},{"line_number":348,"context_line":"        extra_metadata \u003d self.get_extra_metadata(backup, volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_783944ef","line":345,"updated":"2018-10-09 15:07:05.000000000","message":"Why change the metadata to start at 0 instead of 1?  This is a backup format change and I think unnecessary to fix the bug described here.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1bbda108cace60b988cbf8ffa09df123dc53b872","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                      \u0027object_prefix\u0027: object_prefix,"},{"line_number":343,"context_line":"                      \u0027availability_zone\u0027: availability_zone,"},{"line_number":344,"context_line":"                  })"},{"line_number":345,"context_line":"        object_meta \u003d {\u0027id\u0027: 0, \u0027list\u0027: [], \u0027prefix\u0027: object_prefix,"},{"line_number":346,"context_line":"                       \u0027volume_meta\u0027: None}"},{"line_number":347,"context_line":"        object_sha256 \u003d {\u0027id\u0027: 1, \u0027sha256s\u0027: [], \u0027prefix\u0027: object_prefix}"},{"line_number":348,"context_line":"        extra_metadata \u003d self.get_extra_metadata(backup, volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_52a20341","line":345,"in_reply_to":"3f79a3b5_0c97999e","updated":"2018-10-10 18:08:41.000000000","message":"I understand the concerns, have made the appropriate changes.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ba57534ce25be2e9441d6b73fd59e978fdfce67c","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                      \u0027object_prefix\u0027: object_prefix,"},{"line_number":343,"context_line":"                      \u0027availability_zone\u0027: availability_zone,"},{"line_number":344,"context_line":"                  })"},{"line_number":345,"context_line":"        object_meta \u003d {\u0027id\u0027: 0, \u0027list\u0027: [], \u0027prefix\u0027: object_prefix,"},{"line_number":346,"context_line":"                       \u0027volume_meta\u0027: None}"},{"line_number":347,"context_line":"        object_sha256 \u003d {\u0027id\u0027: 1, \u0027sha256s\u0027: [], \u0027prefix\u0027: object_prefix}"},{"line_number":348,"context_line":"        extra_metadata \u003d self.get_extra_metadata(backup, volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8b5dec7d","line":345,"in_reply_to":"3f79a3b5_783944ef","updated":"2018-10-09 15:38:08.000000000","message":"So the other way to do it is in finalize_backup, L#430\nThis seems important as the parameter object_count is showing wrong value and seems useless if not corrected.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e8eb4136e275af13e597f70d488b5cd5624a802f","unresolved":false,"context_lines":[{"line_number":342,"context_line":"                      \u0027object_prefix\u0027: object_prefix,"},{"line_number":343,"context_line":"                      \u0027availability_zone\u0027: availability_zone,"},{"line_number":344,"context_line":"                  })"},{"line_number":345,"context_line":"        object_meta \u003d {\u0027id\u0027: 0, \u0027list\u0027: [], \u0027prefix\u0027: object_prefix,"},{"line_number":346,"context_line":"                       \u0027volume_meta\u0027: None}"},{"line_number":347,"context_line":"        object_sha256 \u003d {\u0027id\u0027: 1, \u0027sha256s\u0027: [], \u0027prefix\u0027: object_prefix}"},{"line_number":348,"context_line":"        extra_metadata \u003d self.get_extra_metadata(backup, volume)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0c97999e","line":345,"in_reply_to":"3f79a3b5_8b5dec7d","updated":"2018-10-10 14:43:37.000000000","message":"Agree with Eric, we can\u0027t change the backup format.\nif we do this, we will get back:\n\nbackup000\nbackup001\nbackup002\n....\n\nand if we don\u0027t want to change the backup format, we can keep the change in L345, and move L380 self+1 to L361.\n\nBut I don\u0027t think it\u0027s the best way.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"e8eb4136e275af13e597f70d488b5cd5624a802f","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        LOG.debug(\u0027backup MD5 for %(object_name)s: %(md5)s\u0027,"},{"line_number":378,"context_line":"                  {\u0027object_name\u0027: object_name, \u0027md5\u0027: md5})"},{"line_number":379,"context_line":"        object_list.append(obj)"},{"line_number":380,"context_line":"        object_id +\u003d 1"},{"line_number":381,"context_line":"        object_meta[\u0027list\u0027] \u003d object_list"},{"line_number":382,"context_line":"        object_meta[\u0027id\u0027] \u003d object_id"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_812052b3","line":380,"range":{"start_line":380,"start_character":0,"end_line":380,"end_character":22},"updated":"2018-10-10 14:43:37.000000000","message":"emm, yes, the reason of object_cnt is bigger than real object count, is we do a redundant +1 on object_id in the last step.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1bbda108cace60b988cbf8ffa09df123dc53b872","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        LOG.debug(\u0027backup MD5 for %(object_name)s: %(md5)s\u0027,"},{"line_number":378,"context_line":"                  {\u0027object_name\u0027: object_name, \u0027md5\u0027: md5})"},{"line_number":379,"context_line":"        object_list.append(obj)"},{"line_number":380,"context_line":"        object_id +\u003d 1"},{"line_number":381,"context_line":"        object_meta[\u0027list\u0027] \u003d object_list"},{"line_number":382,"context_line":"        object_meta[\u0027id\u0027] \u003d object_id"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_527763d2","line":380,"range":{"start_line":380,"start_character":0,"end_line":380,"end_character":22},"in_reply_to":"3f79a3b5_812052b3","updated":"2018-10-10 18:08:41.000000000","message":"yes, the object_meta[\u0027id\u0027] value serves different purpose than object_count variable.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"54d735629eb55554c1ba9e8428e4deb9e5dc21d3","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                             object_list,"},{"line_number":428,"context_line":"                             volume_meta,"},{"line_number":429,"context_line":"                             extra_metadata)"},{"line_number":430,"context_line":"        backup.object_count \u003d object_id"},{"line_number":431,"context_line":"        backup.save()"},{"line_number":432,"context_line":"        LOG.debug(\u0027backup %s finished.\u0027, backup[\u0027id\u0027])"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_873702e5","line":430,"updated":"2018-10-10 14:46:13.000000000","message":"BTW, if we change it, it\u0027s better to add some note in here to describe why we need object_id-1 in here. because L380.","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1bbda108cace60b988cbf8ffa09df123dc53b872","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                             object_list,"},{"line_number":428,"context_line":"                             volume_meta,"},{"line_number":429,"context_line":"                             extra_metadata)"},{"line_number":430,"context_line":"        backup.object_count \u003d object_id"},{"line_number":431,"context_line":"        backup.save()"},{"line_number":432,"context_line":"        LOG.debug(\u0027backup %s finished.\u0027, backup[\u0027id\u0027])"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_124b2b86","line":430,"in_reply_to":"3f79a3b5_873702e5","updated":"2018-10-10 18:08:41.000000000","message":"Done","commit_id":"e030c962899bd579339863ed7ef7e941f160b495"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1a2d3e116a3dcf1ee1b6825b2753946eee8e9b83","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                             extra_metadata)"},{"line_number":430,"context_line":"        # NOTE(whoami-rajat) : The object_id variable is used to name"},{"line_number":431,"context_line":"        # the backup objects and therefore differs from the object_count"},{"line_number":432,"context_line":"        # variable. The last iteration call of _backup_chunk()"},{"line_number":433,"context_line":"        # method increments the object_id value by 1 that shouldn\u0027t"},{"line_number":434,"context_line":"        # be reflected in the object_count variable."},{"line_number":435,"context_line":"        backup.object_count \u003d object_id - 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_74ea590e","line":432,"updated":"2018-10-12 15:03:37.000000000","message":"All iterations of _backup_chunk() increment object_id by one, this is kind of misleading...","commit_id":"d06a8dda9722a814f54098991f4af3d0fe910c76"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27b58ebb7a1ef1c3d7240a3baebed6ae7e39daa5","unresolved":false,"context_lines":[{"line_number":429,"context_line":"                             extra_metadata)"},{"line_number":430,"context_line":"        # NOTE(whoami-rajat) : The object_id variable is used to name"},{"line_number":431,"context_line":"        # the backup objects and therefore differs from the object_count"},{"line_number":432,"context_line":"        # variable. The last iteration call of _backup_chunk()"},{"line_number":433,"context_line":"        # method increments the object_id value by 1 that shouldn\u0027t"},{"line_number":434,"context_line":"        # be reflected in the object_count variable."},{"line_number":435,"context_line":"        backup.object_count \u003d object_id - 1"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ba721baf","line":432,"in_reply_to":"3f79a3b5_74ea590e","updated":"2018-10-12 15:34:03.000000000","message":"Ok. i have rephrased the note, please check.","commit_id":"d06a8dda9722a814f54098991f4af3d0fe910c76"}]}