)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb83422a5449529abbeb42518fb3d1a527e1e9c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the driver name to get stats log output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the manager calls tries to update the driver"},{"line_number":10,"context_line":"stats, it checks to ensure the driver is initialized."},{"line_number":11,"context_line":"When the driver hasn\u0027t been initialized, it logs"},{"line_number":12,"context_line":"a warning without the driver name.  This is confusing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9mSA%3D","line":9,"updated":"2013-12-09 20:15:57.000000000","message":"If you upload another patch I would change \u0027calls\u0027 -\u003e \u0027call\u0027","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d62aa198107ef47020d24e832a90ebab8c30c781","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the driver name to get stats log output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the manager calls tries to update the driver"},{"line_number":10,"context_line":"stats, it checks to ensure the driver is initialized."},{"line_number":11,"context_line":"When the driver hasn\u0027t been initialized, it logs"},{"line_number":12,"context_line":"a warning without the driver name.  This is confusing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9lsE%3D","line":9,"in_reply_to":"AAAATn%2F9mSA%3D","updated":"2013-12-09 22:11:44.000000000","message":"Done","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb83422a5449529abbeb42518fb3d1a527e1e9c4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the driver name to get stats log output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the manager calls tries to update the driver"},{"line_number":10,"context_line":"stats, it checks to ensure the driver is initialized."},{"line_number":11,"context_line":"When the driver hasn\u0027t been initialized, it logs"},{"line_number":12,"context_line":"a warning without the driver name.  This is confusing"},{"line_number":13,"context_line":"for multiple backends.   This patch adds the driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9mR0%3D","line":10,"updated":"2013-12-09 20:15:57.000000000","message":"This should be status instead of stats.","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d62aa198107ef47020d24e832a90ebab8c30c781","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the driver name to get stats log output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the manager calls tries to update the driver"},{"line_number":10,"context_line":"stats, it checks to ensure the driver is initialized."},{"line_number":11,"context_line":"When the driver hasn\u0027t been initialized, it logs"},{"line_number":12,"context_line":"a warning without the driver name.  This is confusing"},{"line_number":13,"context_line":"for multiple backends.   This patch adds the driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F9lr8%3D","line":10,"in_reply_to":"AAAATn%2F9mR0%3D","updated":"2013-12-09 22:11:44.000000000","message":"this is calling the driver.get_volume_stats() not status.","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"}],"cinder/volume/manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"eb83422a5449529abbeb42518fb3d1a527e1e9c4","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    def _report_driver_status(self, context):"},{"line_number":889,"context_line":"        LOG.info(_(\"Updating volume status\"))"},{"line_number":890,"context_line":"        if not self.driver.initialized:"},{"line_number":891,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s driver is \u0027"},{"line_number":892,"context_line":"                          \u0027uninitialized\u0027) %"},{"line_number":893,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__})"},{"line_number":894,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9mSI%3D","line":891,"updated":"2013-12-09 20:15:57.000000000","message":"I think this is a typo that has been fixed elsewhere.  Should be \u0027Unable to update status,\" right?\n\nAlso agree with Eric\u0027s comment.","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"eb293d82369bdefa41da2dbf8d5bb2ec49b545f0","unresolved":false,"context_lines":[{"line_number":888,"context_line":"    def _report_driver_status(self, context):"},{"line_number":889,"context_line":"        LOG.info(_(\"Updating volume status\"))"},{"line_number":890,"context_line":"        if not self.driver.initialized:"},{"line_number":891,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s driver is \u0027"},{"line_number":892,"context_line":"                          \u0027uninitialized\u0027) %"},{"line_number":893,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__})"},{"line_number":894,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9mN0%3D","line":891,"in_reply_to":"AAAATn%2F9mSI%3D","updated":"2013-12-09 20:30:24.000000000","message":"I don\u0027t think so... \"stats\" is the \"correct\" one AFAIK.  (Which implies the method name is off, here, but that doesn\u0027t need to be fixed in this review.)","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"413d9cfae2f563bc45e18f8423a18ccec549465f","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        if not self.driver.initialized:"},{"line_number":891,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s driver is \u0027"},{"line_number":892,"context_line":"                          \u0027uninitialized\u0027) %"},{"line_number":893,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__})"},{"line_number":894,"context_line":"        else:"},{"line_number":895,"context_line":"            volume_stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":896,"context_line":"            if volume_stats:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9mTc%3D","line":893,"updated":"2013-12-09 20:04:55.000000000","message":"Should this not include backend_name?  Doesn\u0027t help a lot if you have multiple backends of the same driver.","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d62aa198107ef47020d24e832a90ebab8c30c781","unresolved":false,"context_lines":[{"line_number":890,"context_line":"        if not self.driver.initialized:"},{"line_number":891,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s driver is \u0027"},{"line_number":892,"context_line":"                          \u0027uninitialized\u0027) %"},{"line_number":893,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__})"},{"line_number":894,"context_line":"        else:"},{"line_number":895,"context_line":"            volume_stats \u003d self.driver.get_volume_stats(refresh\u003dTrue)"},{"line_number":896,"context_line":"            if volume_stats:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9lsg%3D","line":893,"in_reply_to":"AAAATn%2F9mTc%3D","updated":"2013-12-09 22:11:44.000000000","message":"I\u0027ll add the driver.configuration.config_group name here.  Thanks for the catch :)","commit_id":"9d8a1880a24a4e76aa2ccd3e50fa99c35a2d26c9"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3fe2efd6c2d9f7e6589111d7b654291358b64382","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \u0027cinder.volume.drivers.huawei.HuaweiISCSIDriver\u0027:"},{"line_number":138,"context_line":"    \u0027cinder.volume.drivers.huawei.HuaweiVolumeDriver\u0027}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"class VolumeManager(manager.SchedulerDependentManager):"},{"line_number":142,"context_line":"    \"\"\"Manages attachable block storage devices.\"\"\""},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9lZg%3D","line":140,"updated":"2013-12-09 23:20:33.000000000","message":"Looks like a rebase went awry here...","commit_id":"67990bbbb2627b5696a24e059643f77326987097"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e30cb61cfa073db88d31e4d0a0bd5426c7f6fa3a","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                config_group \u003d (\u0027(config name %s)\u0027 %"},{"line_number":830,"context_line":"                                self.driver.configuration.config_group)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s\u0027"},{"line_number":833,"context_line":"                          \u0027%(config_group)s driver is uninitialized\u0027) %"},{"line_number":834,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__,"},{"line_number":835,"context_line":"                         \u0027config_group\u0027: config_group})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9laQ%3D","line":832,"updated":"2013-12-09 23:18:24.000000000","message":"Need a space at the end of the line here.","commit_id":"67990bbbb2627b5696a24e059643f77326987097"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"5c4dadb4b4197be43f4c41d55c7fbb0309d07c9e","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                config_group \u003d (\u0027(config name %s)\u0027 %"},{"line_number":830,"context_line":"                                self.driver.configuration.config_group)"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s\u0027"},{"line_number":833,"context_line":"                          \u0027%(config_group)s driver is uninitialized\u0027) %"},{"line_number":834,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__,"},{"line_number":835,"context_line":"                         \u0027config_group\u0027: config_group})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F9lXM%3D","line":832,"in_reply_to":"AAAATn%2F9laQ%3D","updated":"2013-12-09 23:32:50.000000000","message":"Done","commit_id":"67990bbbb2627b5696a24e059643f77326987097"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"fa05159ffaec96b99d562305a9aee043a2b975a2","unresolved":false,"context_lines":[{"line_number":896,"context_line":""},{"line_number":897,"context_line":"            LOG.warning(_(\u0027Unable to update stats, %(driver_name)s \u0027"},{"line_number":898,"context_line":"                          \u0027-%(driver_version)s \u0027"},{"line_number":899,"context_line":"                          \u0027%(config_group)s driver is uninitialized\u0027) %"},{"line_number":900,"context_line":"                        {\u0027driver_name\u0027: self.driver.__class__.__name__,"},{"line_number":901,"context_line":"                         \u0027driver_version\u0027: self.driver.get_version(),"},{"line_number":902,"context_line":"                         \u0027config_group\u0027: config_group})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F9ZVE%3D","line":899,"updated":"2013-12-11 23:05:14.000000000","message":"This should end with a \u0027.\u0027 please.","commit_id":"f119670acc8b35dc943056a1581921ae24766a42"}]}