)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"cc4ca488a627f98e71158cdb00b21b0f2bf619f6","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9XKA%3D","line":377,"updated":"2013-12-12 08:52:38.000000000","message":"The \u0027cast\u0027 to float isn\u0027t necessary here.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0619e6ab86fe24cdc4a0cdca22afe1fbaa13a027","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FzB0%3D","line":377,"in_reply_to":"AAAATn%2F9F7I%3D","updated":"2013-12-31 10:41:09.000000000","message":"I thought multiplying by a float 0.95 will force the result to be a float.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"705c7757a7decf29a78a8998fc1852376290cec9","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9F7I%3D","line":377,"in_reply_to":"AAAATn%2F9XKA%3D","updated":"2013-12-16 21:21:08.000000000","message":"It may be, since the code never guarantees that self.vg_free_space is float.  We should fix this by casting to float when this value is populated rather than used.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"75035eec32f1513188b4befea083d04117af87bd","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9z6s%3D","line":377,"in_reply_to":"AAAATn%2F9XKA%3D","updated":"2014-02-03 18:09:06.000000000","message":"https://review.openstack.org/#/c/70787/","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"d7fbfef16530ae4ef317b52a79f7c0137d453789","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9d9E%3D","line":377,"in_reply_to":"AAAAUH%2F9z6s%3D","updated":"2014-04-04 10:13:31.000000000","message":"Jon, sorry, I don\u0027t understand what you meant by that comment to another gerrit patch. Do you mean you will submit a change to reflect the removal of float here too? That would be the way ahead IMO, as this is a backport of that.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f362ad6d22265490e4c42a0006d5e453c6da2f37","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9beo%3D","line":377,"in_reply_to":"AAAAWH%2F9buU%3D","updated":"2014-04-04 15:25:11.000000000","message":"That change (70787) in particular is not a significant enough issue to bother backporting it to stable.  This patch works fine as is and should be backported directly.\n\nThis was about fixing up nits in master per JGriffith\u0027s comment, which has been done, so we need to go ahead and land this.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"5f0b688224d8fb2debe2d3cf9cac473613fe0cf3","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.update_volume_group_info()"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        # leave 5% free for metadata"},{"line_number":377,"context_line":"        return \"%sg\" % (float(self.vg_free_space) * 0.95)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    def create_thin_pool(self, name\u003dNone, size_str\u003dNone):"},{"line_number":380,"context_line":"        \"\"\"Creates a thin provisioning pool for this VG."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAWH%2F9buU%3D","line":377,"in_reply_to":"AAAAWH%2F9d9E%3D","updated":"2014-04-04 15:01:57.000000000","message":"The other patch just shows that the issue have been resolved upstream and hasn\u0027t fallen through the cracks.  Since it doesn\u0027t effect functionality, I did not propose it for backport, but I can do this if that\u0027s what is wanted.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"cc4ca488a627f98e71158cdb00b21b0f2bf619f6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if name is None:"},{"line_number":399,"context_line":"            name \u003d \u0027%s-pool\u0027 % self.vg_name"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.vg_pool_name \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9XKQ%3D","line":401,"updated":"2013-12-12 08:52:38.000000000","message":"This looks like you created a new member variable, was that intentional, is it useful?","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"705c7757a7decf29a78a8998fc1852376290cec9","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if name is None:"},{"line_number":399,"context_line":"            name \u003d \u0027%s-pool\u0027 % self.vg_name"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.vg_pool_name \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9F7E%3D","line":401,"in_reply_to":"AAAATn%2F9XKQ%3D","updated":"2013-12-16 21:21:08.000000000","message":"Does not appear to be needed.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"68775e8801307ba828ab419842cee6b5344593c3","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if name is None:"},{"line_number":399,"context_line":"            name \u003d \u0027%s-pool\u0027 % self.vg_name"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        self.vg_pool_name \u003d \u0027%s/%s\u0027 % (self.vg_name, name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FyNA%3D","line":401,"in_reply_to":"AAAATn%2F9XKQ%3D","updated":"2013-12-31 17:52:13.000000000","message":"Let\u0027s remove this or log it","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"cc4ca488a627f98e71158cdb00b21b0f2bf619f6","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, self.vg_pool_name]"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        self._execute(*cmd,"},{"line_number":409,"context_line":"                      root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9XK8%3D","line":406,"updated":"2013-12-12 08:52:38.000000000","message":"Since a user might not expect this behavior I would log at info level the total (requested) size and the available size.","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"68775e8801307ba828ab419842cee6b5344593c3","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, self.vg_pool_name]"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        self._execute(*cmd,"},{"line_number":409,"context_line":"                      root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAT3%2F%2FyM8%3D","line":406,"in_reply_to":"AAAATn%2F9XK8%3D","updated":"2013-12-31 17:52:13.000000000","message":"I think that\u0027s a good idea here","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"75035eec32f1513188b4befea083d04117af87bd","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        if not size_str:"},{"line_number":404,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        cmd \u003d [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str, self.vg_pool_name]"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        self._execute(*cmd,"},{"line_number":409,"context_line":"                      root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F9z8E%3D","line":406,"in_reply_to":"AAAATn%2F9XK8%3D","updated":"2014-02-03 18:09:06.000000000","message":"https://review.openstack.org/#/c/70783/","commit_id":"0553eb601fd8a1d0d365d8a4858a771efb034442"}]}