)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8009b49bf48a545673a66f6cf9e992b0999935d7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for the readonly state to be used. The creating state can be considered"},{"line_number":12,"context_line":"still \"available\", so this updates the protection to allow either"},{"line_number":13,"context_line":"\"available\" or \"creating\" states."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I866d9874cafbfc7a47485762155b8e9b2efd0160"},{"line_number":16,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_af9df76c","line":14,"updated":"2018-10-12 21:41:44.000000000","message":"Well, I\u0027d mention story 2002158 probably...","commit_id":"4a3d4789a59edd339fb96bb6f07ae09bb0fd64f5"}],"cinder/volume/api.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a83d87bb18a0e2383fc826df4e8930408a2a60bc","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        context.authorize(vol_action_policy.UPDATE_READONLY_POLICY,"},{"line_number":1584,"context_line":"                          target_obj\u003dvolume)"},{"line_number":1585,"context_line":"        if volume[\u0027status\u0027] not in [\u0027available\u0027, \u0027creating\u0027]:"},{"line_number":1586,"context_line":"            msg \u003d _(\u0027Volume %(vol_id)s status must be available \u0027"},{"line_number":1587,"context_line":"                    \u0027to update readonly flag, but current status is: \u0027"},{"line_number":1588,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"},{"line_number":1589,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_da79dec5","line":1586,"range":{"start_line":1586,"start_character":54,"end_line":1586,"end_character":63},"updated":"2018-10-16 11:12:15.000000000","message":"or creating","commit_id":"144359ec39b52234f5ba0ce953723014d1e4db39"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"571e21941594e082eb6b1052daf9eb6518ea1621","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"        context.authorize(vol_action_policy.UPDATE_READONLY_POLICY,"},{"line_number":1584,"context_line":"                          target_obj\u003dvolume)"},{"line_number":1585,"context_line":"        if volume[\u0027status\u0027] not in [\u0027available\u0027, \u0027creating\u0027]:"},{"line_number":1586,"context_line":"            msg \u003d _(\u0027Volume %(vol_id)s status must be available \u0027"},{"line_number":1587,"context_line":"                    \u0027to update readonly flag, but current status is: \u0027"},{"line_number":1588,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"},{"line_number":1589,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_99dcc745","line":1586,"range":{"start_line":1586,"start_character":54,"end_line":1586,"end_character":63},"in_reply_to":"3f79a3b5_da79dec5","updated":"2019-04-10 18:05:54.000000000","message":"Creating is still an \"available\" state. See associated bug for a little more description.","commit_id":"144359ec39b52234f5ba0ce953723014d1e4db39"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"39f3e7e2407731015084036721e06567a6a9ba6e","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"    def update_readonly_flag(self, context, volume, flag):"},{"line_number":1619,"context_line":"        context.authorize(vol_action_policy.UPDATE_READONLY_POLICY,"},{"line_number":1620,"context_line":"                          target_obj\u003dvolume)"},{"line_number":1621,"context_line":"        if volume[\u0027status\u0027] not in [\u0027available\u0027, \u0027creating\u0027]:"},{"line_number":1622,"context_line":"            msg \u003d _(\u0027Volume %(vol_id)s status must be available \u0027"},{"line_number":1623,"context_line":"                    \u0027to update readonly flag, but current status is: \u0027"},{"line_number":1624,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_e7d8427c","line":1621,"updated":"2020-04-20 14:32:47.000000000","message":"A question since this isn\u0027t obvious to me... is there a potential for this to cause issues during a volume clone (create from volume) or a create-from-image that\u0027s still in progress, if it\u0027s set to read-only early in the process?","commit_id":"f0d6ebbfa1eb4d1216950d1c4c5516037a2706a6"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4ff31ce12562e841fffc2bef1551609f320eb7fc","unresolved":false,"context_lines":[{"line_number":1618,"context_line":"    def update_readonly_flag(self, context, volume, flag):"},{"line_number":1619,"context_line":"        context.authorize(vol_action_policy.UPDATE_READONLY_POLICY,"},{"line_number":1620,"context_line":"                          target_obj\u003dvolume)"},{"line_number":1621,"context_line":"        if volume[\u0027status\u0027] not in [\u0027available\u0027, \u0027creating\u0027]:"},{"line_number":1622,"context_line":"            msg \u003d _(\u0027Volume %(vol_id)s status must be available \u0027"},{"line_number":1623,"context_line":"                    \u0027to update readonly flag, but current status is: \u0027"},{"line_number":1624,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4c43b2_c7c70664","line":1621,"in_reply_to":"3f4c43b2_e7d8427c","updated":"2020-04-20 14:40:44.000000000","message":"Very good question. It\u0027s been so long since I initial did this, I don\u0027t recall some of the details. I will have to trace through that code path and see if that is a concern.","commit_id":"f0d6ebbfa1eb4d1216950d1c4c5516037a2706a6"}]}