)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebe22b65ed75d0a006347360e995a658179e5b0a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the Stein cycle upgrade-checkers goal. It only includes a placeholder"},{"line_number":11,"context_line":"for actual checks. Follow up patches will need to be added for anything"},{"line_number":12,"context_line":"we identify as needing specific checking."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2e532d313d12e60848b17e869882e52ec456929b"},{"line_number":15,"context_line":"Signed-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_07071683","line":13,"updated":"2018-10-15 14:51:00.000000000","message":"Story: 2003657\nTask: 26123","commit_id":"ede3fad889869f516f1212db4e1c33bfd5ffaf94"}],"cinder/cmd/status.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebe22b65ed75d0a006347360e995a658179e5b0a","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def main():"},{"line_number":40,"context_line":"    inst \u003d Checks()"},{"line_number":41,"context_line":"    return uc.main(inst.check)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_077ab6ee","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":30},"updated":"2018-10-15 14:51:00.000000000","message":"This is wrong, you need to pass the config and project name in.","commit_id":"ede3fad889869f516f1212db4e1c33bfd5ffaf94"}],"doc/requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1689ac4bee13e5faba9681b4511517b8c2b88da2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":11,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":12,"context_line":"sphinxcontrib-apidoc\u003e\u003d0.2.0  # BSD"},{"line_number":13,"context_line":"oslo.upgradecheck\u003e\u003d0.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_66559351","line":13,"updated":"2018-10-16 13:56:27.000000000","message":"You shouldn\u0027t need this if it\u0027s in requirements.txt already.\n\nhttps://github.com/openstack/cinder/blob/master/tox.ini#L130","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"577e0915e4361fab5daf4b84a15c3f8b34c3cb6d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":11,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":12,"context_line":"sphinxcontrib-apidoc\u003e\u003d0.2.0  # BSD"},{"line_number":13,"context_line":"oslo.upgradecheck\u003e\u003d0.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_e52419c6","line":13,"in_reply_to":"3f79a3b5_26223bbb","updated":"2018-10-17 15:50:12.000000000","message":"Done","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1057a6ee2ef8ed6c7d8cdf945058553fb65a9d6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"ddt\u003e\u003d1.0.1 # MIT"},{"line_number":11,"context_line":"fixtures\u003e\u003d3.0.0 # Apache-2.0/BSD"},{"line_number":12,"context_line":"sphinxcontrib-apidoc\u003e\u003d0.2.0  # BSD"},{"line_number":13,"context_line":"oslo.upgradecheck\u003e\u003d0.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_26223bbb","line":13,"in_reply_to":"3f79a3b5_66559351","updated":"2018-10-16 14:00:06.000000000","message":"I was getting job failures without it, but I\u0027m not entirely sure why, especially given it should be picked up by the job like you point out with the tox settings. I\u0027ll test some more.","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"}],"doc/source/cli/cinder-manage.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1689ac4bee13e5faba9681b4511517b8c2b88da2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"cinder-manage"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_66b11391","line":2,"updated":"2018-10-16 13:56:27.000000000","message":"nit: this could have been done in a separate change before this one to decouple it from the cinder-status stuff, I don\u0027t know how much core reviewers will care. Unless this is just being copied from somewhere else in the existing docs?\n\n(later)\n\nOK I see it:\n\nhttps://docs.openstack.org/cinder/latest/man/cinder-manage.html\n\nI would suggest splitting this out into a refactor change before this in the series, to move the cinder-manage page from man/ to cli/ (and don\u0027t forget the redirect link).","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1057a6ee2ef8ed6c7d8cdf945058553fb65a9d6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"cinder-manage"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_a1fcf50b","line":2,"in_reply_to":"3f79a3b5_66b11391","updated":"2018-10-16 14:00:06.000000000","message":"Yeah, I probably should do that first, then have this. I was going to clean that up with a follow up patch, but probably better to get it right in the first place.","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"577e0915e4361fab5daf4b84a15c3f8b34c3cb6d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"cinder-manage"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"------------------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_c5279dc8","line":2,"in_reply_to":"3f79a3b5_a1fcf50b","updated":"2018-10-17 15:50:12.000000000","message":"Done","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"}],"doc/source/cli/cinder-status.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1689ac4bee13e5faba9681b4511517b8c2b88da2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"``cinder-status upgrade check``"},{"line_number":58,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":59,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":60,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":61,"context_line":"  the Cinder API database and one or more cell databases. It may also make"},{"line_number":62,"context_line":"  requests to other services\u0027 REST API via the Keystone service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_06d93fef","line":61,"range":{"start_line":60,"start_character":28,"end_line":61,"end_character":57},"updated":"2018-10-16 13:56:27.000000000","message":"You probably want to drop the cell and cinder API database talk - there is only one cinder DB right?","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"577e0915e4361fab5daf4b84a15c3f8b34c3cb6d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"``cinder-status upgrade check``"},{"line_number":58,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":59,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":60,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":61,"context_line":"  the Cinder API database and one or more cell databases. It may also make"},{"line_number":62,"context_line":"  requests to other services\u0027 REST API via the Keystone service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_051ef574","line":61,"range":{"start_line":60,"start_character":28,"end_line":61,"end_character":57},"in_reply_to":"3f79a3b5_01112950","updated":"2018-10-17 15:50:12.000000000","message":"Done","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d1057a6ee2ef8ed6c7d8cdf945058553fb65a9d6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"``cinder-status upgrade check``"},{"line_number":58,"context_line":"  Performs a release-specific readiness check before restarting services with"},{"line_number":59,"context_line":"  new code. This command expects to have complete configuration and access"},{"line_number":60,"context_line":"  to databases and services within a cell. For example, this check may query"},{"line_number":61,"context_line":"  the Cinder API database and one or more cell databases. It may also make"},{"line_number":62,"context_line":"  requests to other services\u0027 REST API via the Keystone service catalog."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  **Return Codes**"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_01112950","line":61,"range":{"start_line":60,"start_character":28,"end_line":61,"end_character":57},"in_reply_to":"3f79a3b5_06d93fef","updated":"2018-10-16 14:00:06.000000000","message":"Oops, yep.","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0f53d5d1b1c91d635f07c92e6b99ae2fc1a922d9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"::"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  cinder-status \u003ccategory\u003e \u003caction\u003e [\u003cargs\u003e]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_524c9fc8","line":19,"range":{"start_line":19,"start_character":28,"end_line":19,"end_character":34},"updated":"2018-10-18 08:37:09.000000000","message":"nit: s/action/command to be consistent with L32","commit_id":"1729c889c2d81917c3e56189e05f3f91949208f9"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"fa029c0e4dd0aeec7e577fc3a4e0c110eb69662e","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"::"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  cinder-status \u003ccategory\u003e \u003caction\u003e [\u003cargs\u003e]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Description"},{"line_number":22,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_38d2ec60","line":19,"range":{"start_line":19,"start_character":28,"end_line":19,"end_character":34},"in_reply_to":"3f79a3b5_524c9fc8","updated":"2018-10-22 06:23:30.000000000","message":"Addressed in this follow up patch,\nhttps://review.openstack.org/#/c/612248/","commit_id":"1729c889c2d81917c3e56189e05f3f91949208f9"}],"doc/source/cli/index.rst":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1689ac4bee13e5faba9681b4511517b8c2b88da2","unresolved":false,"context_lines":[{"line_number":8,"context_line":"--------------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"These commands are used to manage existing installations. They are designed to"},{"line_number":11,"context_line":"be run by operators in an evnironment where they have direct access to the"},{"line_number":12,"context_line":"Cinder database."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. toctree::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_46fc173e","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":37},"updated":"2018-10-16 13:56:27.000000000","message":"environment","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"577e0915e4361fab5daf4b84a15c3f8b34c3cb6d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"--------------------------"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"These commands are used to manage existing installations. They are designed to"},{"line_number":11,"context_line":"be run by operators in an evnironment where they have direct access to the"},{"line_number":12,"context_line":"Cinder database."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. toctree::"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_0507d520","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":37},"in_reply_to":"3f79a3b5_46fc173e","updated":"2018-10-17 15:50:12.000000000","message":"Done","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"}],"lower-constraints.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"577e0915e4361fab5daf4b84a15c3f8b34c3cb6d","unresolved":false,"context_lines":[{"line_number":163,"context_line":"warlock\u003d\u003d1.3.0"},{"line_number":164,"context_line":"WebOb\u003d\u003d1.7.1"},{"line_number":165,"context_line":"wrapt\u003d\u003d1.10.11"},{"line_number":166,"context_line":"oslo.upgradecheck\u003d\u003d\u003d0.1.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3f79a3b5_25045119","line":166,"range":{"start_line":166,"start_character":17,"end_line":166,"end_character":21},"updated":"2018-10-17 15:50:12.000000000","message":"too many \u003d","commit_id":"2dc2562b0c6ce47d2ed73d3c0c56a0b2351a812c"}],"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebe22b65ed75d0a006347360e995a658179e5b0a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"oslo.rootwrap\u003e\u003d5.8.0 # Apache-2.0"},{"line_number":31,"context_line":"oslo.serialization!\u003d2.19.1,\u003e\u003d2.18.0 # Apache-2.0"},{"line_number":32,"context_line":"oslo.service!\u003d1.28.1,\u003e\u003d1.24.0 # Apache-2.0"},{"line_number":33,"context_line":"oslo.upgradecheck  # Apache-2.0"},{"line_number":34,"context_line":"oslo.utils\u003e\u003d3.33.0 # Apache-2.0"},{"line_number":35,"context_line":"oslo.versionedobjects\u003e\u003d1.31.2 # Apache-2.0"},{"line_number":36,"context_line":"osprofiler\u003e\u003d1.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_874ec6bf","line":33,"updated":"2018-10-15 14:51:00.000000000","message":"I know this matches what\u0027s in g-r but seems it should be:\n\noslo.upgradecheck\u003e\u003d0.1.0 # Apache-2.0\n\nThat\u0027s what keystone is doing anyway:\n\nhttps://review.openstack.org/#/c/608785/5/requirements.txt","commit_id":"ede3fad889869f516f1212db4e1c33bfd5ffaf94"}],"setup.cfg":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ebe22b65ed75d0a006347360e995a658179e5b0a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    cinder-rootwrap \u003d oslo_rootwrap.cmd:main"},{"line_number":68,"context_line":"    cinder-rtstool \u003d cinder.cmd.rtstool:main"},{"line_number":69,"context_line":"    cinder-scheduler \u003d cinder.cmd.scheduler:main"},{"line_number":70,"context_line":"    cinder-status \u003d cinder.cmd.status:main"},{"line_number":71,"context_line":"    cinder-volume \u003d cinder.cmd.volume:main"},{"line_number":72,"context_line":"    cinder-volume-usage-audit \u003d cinder.cmd.volume_usage_audit:main"},{"line_number":73,"context_line":"wsgi_scripts \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3f79a3b5_47442e9f","line":70,"updated":"2018-10-15 14:51:00.000000000","message":"Should also at least stub out the CLI docs:\n\nhttps://docs.openstack.org/cinder/latest/cli/","commit_id":"ede3fad889869f516f1212db4e1c33bfd5ffaf94"}]}