)]}'
{"cinder/backup/drivers/tsm.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37a57c1e21c32746223fdff340b9aa89d992938e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from cinder import exception"},{"line_number":38,"context_line":"from cinder.i18n import _"},{"line_number":39,"context_line":"from cinder import interface"},{"line_number":40,"context_line":"import cinder.privsep.path"},{"line_number":41,"context_line":"from cinder import utils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_557d31e4","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":26},"updated":"2018-10-22 05:40:09.000000000","message":"can we rather use from cinder.privsep import path?","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"77bb3dee2509db1e03a67e11ac6ae40831bc8b5a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from cinder import exception"},{"line_number":38,"context_line":"from cinder.i18n import _"},{"line_number":39,"context_line":"from cinder import interface"},{"line_number":40,"context_line":"import cinder.privsep.path"},{"line_number":41,"context_line":"from cinder import utils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c8af467a","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":26},"in_reply_to":"3f79a3b5_557d31e4","updated":"2018-10-23 13:57:20.000000000","message":"I don\u0027t think this is a good idea -- this form clearly indicates that privileged code is being called any time it\u0027s used, which is helpful for understanding the code.","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1985b90b4a0f872379e9ff96f36f2ac1e5f9bb93","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from cinder import exception"},{"line_number":38,"context_line":"from cinder.i18n import _"},{"line_number":39,"context_line":"from cinder import interface"},{"line_number":40,"context_line":"import cinder.privsep.path"},{"line_number":41,"context_line":"from cinder import utils"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3e6cf031","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":26},"in_reply_to":"3f79a3b5_c8af467a","updated":"2018-10-23 15:04:25.000000000","message":"Ok. i saw the same convention used in cinder code here\nhttps://github.com/openstack/cinder/blob/35ccb75c1c88a68ebc279586ff71299ca8f2b664/cinder/volume/targets/nvmet.py#L23\nso suggested that.","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37a57c1e21c32746223fdff340b9aa89d992938e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    \"\"\""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    try:"},{"line_number":112,"context_line":"        cinder.privsep.path.symlink(volume_path, backup_path)"},{"line_number":113,"context_line":"    except processutils.ProcessExecutionError as exc:"},{"line_number":114,"context_line":"        err \u003d (_(\u0027backup: %(vol_id)s failed to create device hardlink \u0027"},{"line_number":115,"context_line":"                 \u0027from %(vpath)s to %(bpath)s.\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d570610c","line":112,"range":{"start_line":112,"start_character":8,"end_line":112,"end_character":35},"updated":"2018-10-22 05:40:09.000000000","message":"if the import is changed, this would be look better as path.symlink(...)","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"}],"cinder/volume/drivers/veritas_cnfs.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37a57c1e21c32746223fdff340b9aa89d992938e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from cinder import exception"},{"line_number":22,"context_line":"from cinder.i18n import _"},{"line_number":23,"context_line":"from cinder import interface"},{"line_number":24,"context_line":"import cinder.privsep.path"},{"line_number":25,"context_line":"from cinder.volume.drivers import nfs"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_75594d8b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":26},"updated":"2018-10-22 05:40:09.000000000","message":"ditto","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"37a57c1e21c32746223fdff340b9aa89d992938e","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        tgt_vol_path \u003d self._get_local_volume_path(cnfs_share, tgt_vol_name)"},{"line_number":157,"context_line":"        src_vol_path \u003d self._get_local_volume_path(cnfs_share, src_vol_name)"},{"line_number":158,"context_line":"        tgt_vol_path_spl \u003d tgt_vol_path + \"::snap:vxfs:\""},{"line_number":159,"context_line":"        cinder.privsep.path.symlink(src_vol_path, tgt_vol_path_spl)"},{"line_number":160,"context_line":"        LOG.debug(\"VeritasNFSDriver: do_clone_volume %(src_vol_path)s \""},{"line_number":161,"context_line":"                  \"%(tgt_vol_path)s %(tgt_vol_path_spl)s\","},{"line_number":162,"context_line":"                  {\u0027src_vol_path\u0027: src_vol_path,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1550195f","line":159,"range":{"start_line":159,"start_character":8,"end_line":159,"end_character":36},"updated":"2018-10-22 05:40:09.000000000","message":"ditto","commit_id":"08ba04dd4e4a46b415af15a6668626dddd29e0c1"}]}