)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"fb1234f4b6ccc7023bb8010e0faa7b03c17ccc77","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lixiaoy1 \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-23 05:28:19 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log exception during volume creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to add logging of exceptions during volume creation."},{"line_number":10,"context_line":"This is only for _create_raw_volume, and other patches will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_ba8cacd8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":13},"updated":"2018-10-22 12:33:57.000000000","message":"This is actually setting user messages, so I was a little surprised by the amount of change until I saw what it was actually doing. Might be better to have this saying something like:\n\nSet user message on volume create failure","commit_id":"0c96bd4f8a449db0f0422e06d3f84ed31d006466"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"672c050c5d1109cd1af2eab766e8b41362034245","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lixiaoy1 \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-24 18:14:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log exception during volume creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to add logging of exceptions during volume creation."},{"line_number":10,"context_line":"This is only for _create_raw_volume, and other patches will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_4016915a","line":7,"updated":"2018-10-24 14:19:49.000000000","message":"The commit message was reverted with patchset 3, so it is not accurate again.","commit_id":"c528e940eb6c54f0194ffd4bac65a872f87d7305"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f575fddd5d183873a3e5e35e4330530f65b16968","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     lixiaoy1 \u003cxiaoyan.li@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-10-24 18:14:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Log exception during volume creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is to add logging of exceptions during volume creation."},{"line_number":10,"context_line":"This is only for _create_raw_volume, and other patches will be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_b337bde4","line":7,"updated":"2018-10-26 11:54:01.000000000","message":"The commit message was reverted with patchset 3, so it is not accurate again.","commit_id":"c528e940eb6c54f0194ffd4bac65a872f87d7305"}],"cinder/message/message_field.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"42a3c83cab1ca23e728dc2102aa5438acb4fba5c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_80ee22b3","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":25},"updated":"2018-10-22 13:04:50.000000000","message":"-1: This name is not consistent with the naming adopted here and sounds like you are creating a backend, not a volume. Following the pattern, CREATE_VOLUME would be the most intuitive right?","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"42a3c83cab1ca23e728dc2102aa5438acb4fba5c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_20338e63","line":41,"range":{"start_line":41,"start_character":39,"end_line":41,"end_character":73},"updated":"2018-10-22 13:04:50.000000000","message":"create volume","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b69b67271f8cd2711ad99ab17e495428055d1b0c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4dd028f5","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":25},"in_reply_to":"3f79a3b5_3535fca7","updated":"2018-10-23 13:22:39.000000000","message":"\"CREATE_VOLUME\" is too broad.  The intent here to name it something that relates only to the driver operation and not the entire create flow is a good idea.","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"44cfd5c43ed464f200e16485e825cdffda627c75","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_9f37344c","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":25},"in_reply_to":"3f79a3b5_4d4fc88b","updated":"2018-10-24 01:29:25.000000000","message":"Same opinion with Eric. I set the id to CREATE_VOLUME_FROM_BACKEND. Is it OK? @Rajat, or do you think CREATE_VOLUME_ON_BACKEND is better? :)","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4940e6936d0cf2ced736e79e60ebf70de9416417","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4d4fc88b","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":25},"in_reply_to":"3f79a3b5_4dd028f5","updated":"2018-10-23 13:34:28.000000000","message":"maybe CREATE_VOLUME_ON_BACKEND ?","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"1d7e569e445ee87addd5d9d9a17fffed4ca9f3b8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_BACKEND \u003d (\u0027008\u0027, _(\u0027create volume from backend storage\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"},{"line_number":44,"context_line":"           ATTACH_VOLUME,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3535fca7","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":25},"in_reply_to":"3f79a3b5_80ee22b3","updated":"2018-10-23 02:49:00.000000000","message":"Agree, and maybe Lisa means the error from driver(backend)?\n\nbut I think CREATE_VOLUME is okay in here, and detail field can describe how to cause this error.","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"42a3c83cab1ca23e728dc2102aa5438acb4fba5c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        _(\"Image signature verification failed.\"))"},{"line_number":84,"context_line":"    DRIVER_FAILED_CREATE \u003d ("},{"line_number":85,"context_line":"        \u0027012\u0027,"},{"line_number":86,"context_line":"        _(\u0027Volume failed to create in backend storage.\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    ALL \u003d (UNKNOWN_ERROR,"},{"line_number":89,"context_line":"           DRIVER_NOT_INITIALIZED,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4026ca24","line":86,"range":{"start_line":86,"start_character":11,"end_line":86,"end_character":53},"updated":"2018-10-22 13:04:50.000000000","message":"Driver failed to create the volume","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"44cfd5c43ed464f200e16485e825cdffda627c75","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        _(\"Image signature verification failed.\"))"},{"line_number":84,"context_line":"    DRIVER_FAILED_CREATE \u003d ("},{"line_number":85,"context_line":"        \u0027012\u0027,"},{"line_number":86,"context_line":"        _(\u0027Volume failed to create in backend storage.\u0027))"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    ALL \u003d (UNKNOWN_ERROR,"},{"line_number":89,"context_line":"           DRIVER_NOT_INITIALIZED,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ff0f4888","line":86,"range":{"start_line":86,"start_character":11,"end_line":86,"end_character":53},"in_reply_to":"3f79a3b5_4026ca24","updated":"2018-10-24 01:29:25.000000000","message":"Done","commit_id":"d8338f9437b7a8684063b4ec142e0e77b3dac0ff"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f575fddd5d183873a3e5e35e4330530f65b16968","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    COPY_IMAGE_TO_VOLUME \u003d (\u0027005\u0027, _(\u0027copy image to volume\u0027))"},{"line_number":39,"context_line":"    UNMANAGE_VOLUME \u003d (\u0027006\u0027, _(\u0027unmanage volume\u0027))"},{"line_number":40,"context_line":"    EXTEND_VOLUME \u003d (\u0027007\u0027, _(\u0027extend volume\u0027))"},{"line_number":41,"context_line":"    CREATE_VOLUME_FROM_BACKEND \u003d (\u0027008\u0027,"},{"line_number":42,"context_line":"                                  _(\u0027create volume from backend storage\u0027))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    ALL \u003d (SCHEDULE_ALLOCATE_VOLUME,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_676051a5","line":41,"range":{"start_line":41,"start_character":18,"end_line":41,"end_character":22},"updated":"2018-10-26 11:54:01.000000000","message":"ON might be better IMO, but this is an improvement from before.","commit_id":"67b2159f2fa9299359ef5d409309390cf184595a"}]}