)]}'
{"cinder/api/contrib/volume_type_encryption.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"826cf7b3fb12b317b9796d3b2db2937e69c43b3f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                                           volume_type_id)"},{"line_number":54,"context_line":"        # If there is at least one volume in the list"},{"line_number":55,"context_line":"        # returned, this type is in use by a volume."},{"line_number":56,"context_line":"        return bool(volume_list)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _authorize_policy(self, context, new_policy):"},{"line_number":59,"context_line":"        # TODO(cl566n): In future release, this _authorize_policy function"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9e3eaf24","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":32},"updated":"2018-11-01 14:25:17.000000000","message":"IMO, changing to \"return len(volume_list) \u003e 0\" will be much clearer.","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d76969a888ee0959d8eb58c8f5fb19b60beb81e6","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                                                           volume_type_id)"},{"line_number":54,"context_line":"        # If there is at least one volume in the list"},{"line_number":55,"context_line":"        # returned, this type is in use by a volume."},{"line_number":56,"context_line":"        return bool(volume_list)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _authorize_policy(self, context, new_policy):"},{"line_number":59,"context_line":"        # TODO(cl566n): In future release, this _authorize_policy function"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c5e5283f","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":32},"in_reply_to":"3f79a3b5_9e3eaf24","updated":"2018-11-02 04:18:28.000000000","message":"+1","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"826cf7b3fb12b317b9796d3b2db2937e69c43b3f","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                                  backup.container)) as client:"},{"line_number":977,"context_line":"            # If a source snapshot is provided we assume the base is diff"},{"line_number":978,"context_line":"            # format."},{"line_number":979,"context_line":"            diff_format \u003d bool(src_snap)"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"            backup_name \u003d self._get_backup_base_name(backup.volume_id,"},{"line_number":982,"context_line":"                                                     backup_id\u003dbackup.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3e72fb19","line":979,"range":{"start_line":979,"start_character":12,"end_line":979,"end_character":40},"updated":"2018-11-01 14:25:17.000000000","message":"Here too, using a trenary expression like: diff_format \u003d True if src_snap else False\nwill be much clearer, IMO.","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"}],"cinder/scheduler/filters/extra_specs_ops.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"826cf7b3fb12b317b9796d3b2db2937e69c43b3f","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def match(value, req):"},{"line_number":42,"context_line":"    if req is None:"},{"line_number":43,"context_line":"        return bool(value is None)"},{"line_number":44,"context_line":"    words \u003d req.split()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op \u003d method \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1e813fc3","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":34},"updated":"2018-11-01 14:25:17.000000000","message":"Same as before, can change to \"return value is None\" or \"return not value\"","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d76969a888ee0959d8eb58c8f5fb19b60beb81e6","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def match(value, req):"},{"line_number":42,"context_line":"    if req is None:"},{"line_number":43,"context_line":"        return bool(value is None)"},{"line_number":44,"context_line":"    words \u003d req.split()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    op \u003d method \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0549e02d","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":34},"in_reply_to":"3f79a3b5_1e813fc3","updated":"2018-11-02 04:18:28.000000000","message":"return not value is better IMO","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"}],"cinder/volume/drivers/dell_emc/vnx/client.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"826cf7b3fb12b317b9796d3b2db2937e69c43b3f","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                         src_lun\u003dsrc_lun)"},{"line_number":236,"context_line":"        new_lun \u003d self.vnx.get_lun(lun_id\u003ddst_id)"},{"line_number":237,"context_line":"        new_wwn \u003d new_lun.wwn"},{"line_number":238,"context_line":"        return bool(not new_wwn or new_wwn !\u003d dst_wwn)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def cleanup_migration(self, src_id, dst_id\u003dNone):"},{"line_number":241,"context_line":"        \"\"\"Invoke when migration meets error."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_de62e741","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":54},"updated":"2018-11-01 14:25:17.000000000","message":"Can also change to \"return not new_wwn or new_wwn !\u003d dst_wwn\"","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"d0cbd1e3480dcd229b0cc2604fec33bb16a9fc07","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        data \u003d image_utils.qemu_img_info(path,"},{"line_number":667,"context_line":"                                         run_as_root\u003dself._execute_as_root)"},{"line_number":668,"context_line":"        virt_size \u003d data.virtual_size / units.Gi"},{"line_number":669,"context_line":"        return bool(virt_size \u003d\u003d size)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"    def _touch_path_to_refresh(self, path):"},{"line_number":672,"context_line":"        # Touching parent directory forces NFS client to flush its cache."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d36f40f9","line":669,"range":{"start_line":669,"start_character":15,"end_line":669,"end_character":19},"updated":"2018-11-01 13:52:00.000000000","message":"bool() seems unnecessary here.","commit_id":"028a6578aa5d6f52c0eacade8aa23ae99dda051a"}]}